Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <e07c1f0f-19e3-4af8-9d57-fa66d50edec2@oracle.com>
Date:   Wed, 13 Dec 2023 16:09:34 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] dcache: remove unnecessary NULL check in dget_dlock()
Content-Language: en-US
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     Christian Brauner <brauner@kernel.org>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-doc@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
        Waiman Long <longman@redhat.com>
References: <20231106134417.98833-1-vegard.nossum@oracle.com>
 <fb2cf7c5-cced-4ea3-bf5a-a442a0e64bda@oracle.com>
 <20231213150515.GM1674809@ZenIV>
From:   Vegard Nossum <vegard.nossum@oracle.com>
Autocrypt: addr=vegard.nossum@oracle.com; keydata=
 xsFNBE4DTU8BEADTtNncvO6rZdvTSILZHHhUnJr9Vd7N/MSx8U9z0UkAtrcgP6HPsVdsvHeU
 C6IW7L629z7CSffCXNeF8xBYnGFhCh9L9fyX/nZ2gVw/0cVDCVMwVgeXo3m8AR1iSFYvO9vC
 Rcd1fN2y+vGsJaD4JoxhKBygUtPWqUKks88NYvqyIMKgIVNQ964Qh7M+qDGY+e/BaId1OK2Z
 92jfTNE7EaIhJfHX8hW1yJKXWS54qBMqBstgLHPx8rv8AmRunsehso5nKxjtlYa/Zw5J1Uyw
 tSl+e3g/8bmCj+9+7Gj2swFlmZQwBVpVVrAR38jjEnjbKe9dQZ7c8mHHSFDflcAJlqRB2RT1
 2JA3iX/XZ0AmcOvrk62S7B4I00+kOiY6fAERPptrA19n452Non7PD5VTe2iKsOIARIkf7LvD
 q2bjzB3r41A8twtB7DUEH8Db5tbiztwy2TGLD9ga+aJJwGdy9kR5kRORNLWvqMM6Bfe9+qbw
 cJ1NXTM1RFsgCgq7U6BMEXZNcsSg9Hbs6fqDPbbZXXxn7iA4TmOhyAqgY5KCa0wm68GxMhyG
 5Q5dWfwX42/U/Zx5foyiORvEFxDBWNWc6iP1h+w8wDiiEO/UM7eH06bxRaxoMEYmcYNeEjk6
 U6qnvjUiK8A35zDOoK67t9QD35aWlNBNQ2becGk9i8fuNJKqNQARAQABzShWZWdhcmQgTm9z
 c3VtIDx2ZWdhcmQubm9zc3VtQG9yYWNsZS5jb20+wsF4BBMBAgAiBQJX+8E+AhsDBgsJCAcD
 AgYVCAIJCgsEFgIDAQIeAQIXgAAKCRALzvTY/pi6WOTDD/46kJZT/yJsYVT44e+MWvWXnzi9
 G7Tcqo1yNS5guN0d49B8ei9VvRzYpRsziaj1nAQJ8bgGJeXjNsMLMOZgx4b5OTsn8t2zIm2h
 midgIE8b3nS73uNs+9E1ktJPnHClGtTECEIIwQibpdCPYCS3lpmoAagezfcnkOqtTdgSvBg9
 FxrxKpAclgoQFTKpUoI121tvYBHmaW9K5mBM3Ty16t7IPghnndgxab+liUUZQY0TZqDG8PPW
 SuRpiVJ9buszWQvm1MUJB/MNtj1rWHivsc1Xu559PYShvJiqJF1+NCNVUx3hfXEm3evTZ9Fm
 TQJBNaeROqCToGJHjdbOdtxeSdMhaiExuSnxghqcWN+76JNXAQLlVvYhHjQwzr4me4Efo1AN
 jinz1STmmeeAMYBfHPmBNjbyNMmYBH4ETbK9XKmtkLlEPuwTXu++7zKECgsgJJJ+kvAM1OOP
 VSOKCFouq1NiuJTDwIXQf/zc1ZB8ILoY/WljE+TO/ZNmRCZl8uj03FTUzLYhR7iWdyfG5gJ/
 UfNDs/LBk596rEAtlwn0qlFUmj01B1MVeevV8JJ711S1jiRrPCXg90P3wmUUQzO0apfk1Np6
 jZVlvsnbdK/1QZaYo1kdDPEVG+TQKOgdj4wbLMBV0rh82SYM1nc6YinoXWS3EuEfRLYTf8ad
 hbkmGzrwcc7BTQROA01PARAA5+ySdsvX2RzUF6aBwtohoGYV6m2P77wn4u9uNDMD9vfcqZxj
 y9QBMKGVADLY/zoL3TJx8CYS71YNz2AsFysTdfJjNgruZW7+j2ODTrHVTNWNSpMt5yRVW426
 vN12gYjqK95c5uKNWGreP9W99T7Tj8yJe2CcoXYb6kO8hGvAHFlSYpJe+Plph5oD9llnYWpO
 XOzzuICFi4jfm0I0lvneQGd2aPK47JGHWewHn1Xk9/IwZW2InPYZat0kLlSDdiQmy/1Kv1UL
 PfzSjc9lkZqUJEXunpE0Mdp8LqowlL3rmgdoi1u4MNXurqWwPTXf1MSH537exgjqMp6tddfw
 cLAIcReIrKnN9g1+rdHfAUiHJYhEVbJACQSy9a4Z+CzUgb4RcwOQznGuzDXxnuTSuwMRxvyz
 XpDvuZazsAqB4e4p/m+42hAjE5lKBfE/p/WWewNzRRxRKvscoLcWCLg1qZ6N1pNJAh7BQdDK
 pvLaUv6zQkrlsvK2bicGXqzPVhjwX+rTghSuG3Sbsn2XdzABROgHd7ImsqzV6QQGw7eIlTD2
 MT2b9gf0f76TaTgi0kZlLpQiAGVgjNhU2Aq3xIqOFTuiGnIQN0LV9/g6KqklzOGMBYf80Pgs
 kiObHTTzSvPIT+JcdIjPcKj2+HCbgbhmrYLtGJW8Bqp/I8w2aj2nVBa7l7UAEQEAAcLBXwQY
 AQIACQUCTgNNTwIbDAAKCRALzvTY/pi6WEWzD/4rWDeWc3P0DfOv23vWgx1qboMuFLxetair
 Utae7i60PQFIVj44xG997aMjohdxxzO9oBCTxUekn31aXzTBpUbRhStq78d1hQA5Rk7nJRS6
 Nl6UtIcuLTE6Zznrq3QdQHtqwQCm1OM2F5w0ezOxbhHgt9WTrjJHact4AsN/8Aa2jmxJYrup
 aKmHqPxCVwxrrSTnx8ljisPaZWdzLQF5qmgmAqIRvX57xAuCu8O15XyZ054u73dIEYb2MBBl
 aUYwDv/4So2e2MEUymx7BF8rKDJ1LvwxKYT+X1gSdeiSambCzuEZ3SQWsVv3gn5TTCn3fHDt
 KTUL3zejji3s2V/gBXoHX7NnTNx6ZDP7It259tvWXKlUDd+spxUCF4i5fbkoQ9A0PNCwe01i
 N71y5pRS0WlFS06cvPs9lZbkAj4lDFgnOVQwmg6Smqi8gjD8rjP0GWKY24tDqd6sptX5cTDH
 pcH+LjiY61m43d8Rx+tqiUGJNUfXE/sEB+nkpL1PFWzdI1XZp4tlG6R7T9VLLf01SfeA2wgo
 9BLDRko6MK5UxPwoYDHpYiyzzAdO24dlfTphNxNcDfspLCgOW1IQ3kGoTghU7CwDtV44x4rA
 jtz7znL1XTlXp6YJQ/FWWIJfsyFvr01kTmv+/QpnAG5/iLJ+0upU1blkWmVwaEo82BU6MrS2 8A==
In-Reply-To: <20231213150515.GM1674809@ZenIV>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVJKa0ppanBEc0dHUDlGTEVwdVM4K1NTVDk1cmE5QXhGSFdSUlNETGkvQXpC?=
 =?utf-8?B?U05mOGh3a0RPbE9BWDJrbDRDVnFqenpQQTgySk5Hby9aK2kxQkVhNlRRTms2?=
 =?utf-8?B?Vnh0RWNEUjVwcDg1d3U3bkNDdS9sYldtZzJrcnlqc0VkMmR0dDVJbm00Q0ZC?=
 =?utf-8?B?YzBueHNNZXN1Q24vdS85a0Y3cHNaeTJGNEs3UHAyWGVMTE9HL0FJZk9SdmNR?=
 =?utf-8?B?K25URU5CMnduNlRuVndwTUduSVpwUUFVK2lDQVBoeWRGOFpPaWFXc1pBNzYz?=
 =?utf-8?B?b2ovbGFIeWFPWWRYMXRqczNuYlo3b0lFWlhhdllXb2NZTlZocE5sN3pjQ0di?=
 =?utf-8?B?bFVwTXFQVnpYaUVVcGJKY1o0bGJBU0tPeFVEUHNWaUpJWm1KVFFEa1BOZ1FM?=
 =?utf-8?B?ODdhbmVOZnJ0c0hqSXY1dEhGM1FPRmV4bFphQU9oTU1xUzNHR1F5ZXFvdUJZ?=
 =?utf-8?B?c2J5UkdKanFROG1Tc3NkQWRMWHp6d3FlTFE2TzBGZkpicVJlem1MbUVIR2VW?=
 =?utf-8?B?eGtMN0hyZFEycTFRdUxyWEdMZXJyR3Z0Z1dYbEF1bDU0bGtrQWRIc1hzL3Nh?=
 =?utf-8?B?OHQ3VmdHQ1dYNlFBRVcrSzF5TXZzanBvdmhTSVBUZjVvUE5LVlpxTEsxdm83?=
 =?utf-8?B?YXQzZk9WbVBBQWF3Ry9wLzBPTDF3ZDJad1RNcEdyeWdvd1hTVjN6UzZvSTc5?=
 =?utf-8?B?d2dUV0tSQTdUUzJOUHNCTGtCcFlHaGVLMnFQeTRlakwwNjhsV0duSkIwbyt6?=
 =?utf-8?B?M1BoZm5ReW5jUDBsdi9mUytBNFBoUS9INGs3Q1BVK0NwY0NMNGVQUWpqUlN2?=
 =?utf-8?B?OXZsQllsNTU0bERGVGNDZFozdTIyTUx3RU9MUDVXZ3FRMzJkM2ZzcTdyWkgz?=
 =?utf-8?B?L2ROZUNmVW5zUHpsMDJCQWl2OENOMVZwVmZEdWx5ZHVWS1FEbG1YcWluMUVh?=
 =?utf-8?B?NXlaTWptT1IxTGNCVmE2WTd5QUxrcXlXV245ckhuZXlTS005K05DRVAwSFlr?=
 =?utf-8?B?Sm9ubUVvK3plRjJxWVpEdFhaeUo0OVMyaXpIbmtmRGhDdVpXeUVDVGc3aUxh?=
 =?utf-8?B?bHZCbWxhTHMvR0hBbXdRUUxEc00rVGMraDVVVDVVYitQbmRVWDVkb3piZXFG?=
 =?utf-8?B?anpkemNoQ2MwcVAxTTQzNFI0em1aZWQyenNoYmZZeXdtcXo1cEZnYWJtMkhQ?=
 =?utf-8?B?aFdaY1RZNExMeEExR2s5bnpGcjBMczZOV2xiaXN2eXpxZFhlYUxlTDNVd3lO?=
 =?utf-8?B?ZklCTU9yNk1Lcm5ES2pqWk1nSml4WlRyWWxUSnlFVEg0NXhXcmV0cklJMzdD?=
 =?utf-8?B?RUd5MFJtWXVJN2FSUTNNcHZxWHEweDY2dDQrc1BGRTNJSWk5V2RxVG12a3hY?=
 =?utf-8?B?cmFpTDQzMGtFa3hWdzFqVmovakg0amhjRExRNC9TT280TTZaeU9oWkZ4M21v?=
 =?utf-8?B?UnR0bmd1azdUcnpxemREYmtYK2o1cFZtMUhMK3lkbXVDclJwa3BEb0hNOGt3?=
 =?utf-8?B?N05FMGJ2Um9TWEtYQzh3WkorTEEwTkZUbDRnRUcySVcvZW9mVXFpK05pREgw?=
 =?utf-8?B?ZHhQUGtQNWZoeVMxNCttSnQxcEthQmQwZDFwdEtJU2hoVlpoZXowZUl0WkxP?=
 =?utf-8?B?RGlVOGdpclN2U0VwYVhUM21ZV01tOFpVWGNhWktiT2lGc3FEZldVcHdRT1d2?=
 =?utf-8?B?TUNvZGZ3MnhOQ0E4a2daUTU4M2ZMUTRacVNjWGk5QzBMQWdDdTYvYXV0OEdD?=
 =?utf-8?B?RlhBS0NkaDJHY1REQ0p5YTNzZitoT3ZhdHAxdjdHQWQvQVJ3NzZrQytPc21Q?=
 =?utf-8?B?SnAxRmY4QUxOcisyci8xR052bWtEUHJmUklhSTlqcGtVVHp3NnY3eXNKdnp6?=
 =?utf-8?B?UnVZUUZsY2tWckRCdHNzZTJzaUxnak1PcmZMZUJqUWY0bDliR0hhcmI3L2hE?=
 =?utf-8?B?YU4zbU11N1htUEozLzg5QmNXTjdDbWQ0aXdFeHlsbCtpakY5TDBJQk9vNEVX?=
 =?utf-8?B?RC9IcmlZMlllV3llc0JrU1RLSlpjbTUvWWxwODBrcklGdDA2UitxWWdKZXlK?=
 =?utf-8?B?eExXL2Z5YTdKVHA0aVQ2Mk5RVkxoL1BKb2xUN2phTXhKbzljbGlpRWV6dmdT?=
 =?utf-8?B?SW45R0hqR2pPVXR0WjYwVW9jbDNXRHdBY3ArWjhsOUMwYmx0Y2hJL3FFWFVO?=
 =?utf-8?B?d0E9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: OIYYa98gxUZcWBTrHvqQs+E9M6/A0jguMOv7OGsauK716Jsu6BUlHcf3kYKYFI3k0La9AKIIyF52RD27oHAi/c1h9D2JHsKkyMW8RpuRTEPOprK1Kw5Npnjz05f9HWPcGGgWINnbuGJZ8yJOxrXuDdGCXVWYlj/gJeW2s8HaOoYOqS2UCMdq5ql0GLYOQ6EI4EKwTJLjp5eBgyaY//hnC+VxMZilu0WRzQ772s4KwVdj7aRQWbGQi7JfBkP+rZ++Mpfm9ajNjY43eAlNDDp5jVP40ZXDIBoi/hwa6DspNdbOOqsc+6/PZzvZkYeJ//5jKo6KRUIvpDiLsa+zYT0+UeyUj1Vq9RQUtyRXyI4k2CFK6uEFc3Ut57IZZYZMGspT0aieJWlEIhoLoXZ0QZN7UoytGFVlIliG+tO6IEadSiiKkf0eNtdP9Mz/q4qCHvjA+/w7rpxfSMTQ6NFyycpF4Rqde0OnnzLv0jJInaKfUocnojCm3b21DcHQeY28Rx4oE39rsVlbOQYkVhUuUyjPb+ts+F25e6clmNwXJwmRBObWhLF2xfrnJIMIZyPXirOJOLciOORxUfP1Ek1YiYKRzAVPqTMwgpdFYpRnMrQKnrk=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0aeba598-1ede-4f28-152b-08dbfbed86cd
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5433.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 15:09:39.1552
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vXddW0efT195ZdC8qn3raWBSpxwB1XB6giHZdLRt8mABULuHbTcUDuC54nudd/LvsXqZ+HK+KJY7HEbtNy5Im/Rqn2WSq8pYn1SEEhNcxkg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4370
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-13_08,2023-12-13_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 spamscore=0
 mlxscore=0 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2312130107
X-Proofpoint-GUID: TlbXwvn16BZpFYVmxwm-UXylbgsJTYRI
X-Proofpoint-ORIG-GUID: TlbXwvn16BZpFYVmxwm-UXylbgsJTYRI
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 13 Dec 2023 07:10:12 -0800 (PST)


On 13/12/2023 16:05, Al Viro wrote:
> On Wed, Dec 13, 2023 at 03:40:33PM +0100, Vegard Nossum wrote:
>> [Fixed up a couple of bad addresses in Cc]
>>
>> Hi,
>>
>> I didn't get a response to this v2 of the patch below and I don't see it
>> in vfs.git.
>>
>> Was there something wrong or is it just awaiting review? Is there
>> anything I can do or help with? I would be happy to try to review other
>> patches if there is anything outstanding.
> 
> commit 1b6ae9f6e6c3e3c35aad0f11b116a81780b8aa03 (work.dcache)
> Author: Vegard Nossum <vegard.nossum@oracle.com>
> Date:   Mon Nov 6 14:44:17 2023 +0100
> 
>      dcache: remove unnecessary NULL check in dget_dlock()
> 

Ahh, there are two vfs.git -- my bad. Thanks!


Vegard