Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5388890rdb; Wed, 13 Dec 2023 07:22:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IEYnMkN349GMOCkXqEUPcVg8++lr7lA1bE0BUoCIK4GCYrgqT7JrjdwtFd2nCHlUkwu+fHl X-Received: by 2002:a05:6a00:218f:b0:6cb:d2cb:5234 with SMTP id h15-20020a056a00218f00b006cbd2cb5234mr9784656pfi.32.1702480974328; Wed, 13 Dec 2023 07:22:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702480974; cv=none; d=google.com; s=arc-20160816; b=ZVnmzY+tfwdDUaweU9Rcjm09uFVK7/QMxbB3vdCOj1TU3WI8nRw2oQx7Uqm7znelT9 jfeNJUIF2+7viytuinHtwkGI+AhjtlV2Fvyl4B9TENu9XsGTGuU/7Ym4Ieuyi8+Po8Yk JcIQk+QHOJnLU2P+KnGhgCRjXd5np6MvGde/UpSzBufPmO4C3xSaV1rCMKHqfyxl4rWo hDOhWD2qESwfFaLigpqa6XI02xZzy8dR1E4owjPhWRV4JGEI7KnIR6q0cEdrBIJDw6pn vGBNzLxUEIBKKlfe363a3S2SDzMfD8QUp1BXf3NVGiKJY6F1DwNr//sLsga0an/Q8QtK +Crg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=jR2E31LcqjTn0icH0/JJtOo1eUiMw8DDtROuVwRGRaY=; fh=RisOi2g01QJ0zO3kV+4Lpq0Elfhd2+0lH04aMslOHLQ=; b=K/sBk5gK+fOSvUgkLzaKMRL/I+kscdDRc1evqk/TWdVVxUxm61zbVTNX14MFUAQ4gD 5nSjTVg3aQjTI3voK3i2yIeVYFcXNALHDt/azuPvt3GJUSmX7rFkIBWf34IscBkm5UEo 05vsoLCovMqSl0UiX5DPwgOUx0qKKffm8lRBf0ho7GElbSysqI3f9Fm0+rIqS62A5BjA YYi8FbhCE2MtchRGju4EMYN2l+x2cIT2eSTNmyIE4IkersK78nqBBhprfZybWqJPOdNC cpP7Nelc+qKovvqxWPUkVRzlC13xTp6ZNPfZ86RgiLiBpozCqeZpjJipQ9B/bpjdi5He HyyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fNrPOmca; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id d18-20020a056a00199200b006ce51863712si9829821pfl.330.2023.12.13.07.22.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 07:22:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fNrPOmca; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id EA54780747BF; Wed, 13 Dec 2023 07:22:43 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442499AbjLMPWb (ORCPT + 99 others); Wed, 13 Dec 2023 10:22:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442501AbjLMPWa (ORCPT ); Wed, 13 Dec 2023 10:22:30 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71437100 for ; Wed, 13 Dec 2023 07:22:35 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8C93C433C7; Wed, 13 Dec 2023 15:22:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702480955; bh=tf/O8dGetCNcpoy6MZUH2WfyxvXI3zJrSEHCm5FUzJ0=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=fNrPOmca6s3S/ZPvqGYwmmGm4U8Nux2est+54hkCERW/9/h6pAIACO4u6ENd52nTP EzwruVq8O270QaA6xO+4M1jqR7JOygVP/qryhESjvj3bZC0IsQkf/aOzVantjhURS1 IC+VRRLEolr7n6scU0vjCCr1HaKCECn4b6yEwVexHKV8/BU1Q+T5FIlHvT3G3mK7WQ cPbb114J80/xlnGDBNqk9P/hPTkncp3zlbGBxVT7iIfDaYqChaTdnomlhP8DSzq56a 682Ysi6huUkV6dFXXafuGxIwf4WFBw5G/b/3U78HTGnz3fJ4Aa5R0GvziJYQl4m6We 8OcivlPMheioQ== From: Maxime Ripard To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Emma Anholt , Jonathan Corbet , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard Cc: Hans Verkuil , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev In-Reply-To: <20231207-kms-hdmi-connector-state-v5-18-6538e19d634d@kernel.org> References: <20231207-kms-hdmi-connector-state-v5-0-6538e19d634d@kernel.org> <20231207-kms-hdmi-connector-state-v5-18-6538e19d634d@kernel.org> Subject: Re: (subset) [PATCH v5 18/44] drm/vc4: hdmi: Create destroy state implementation Message-Id: <170248095242.191897.1505855856456253349.b4-ty@kernel.org> Date: Wed, 13 Dec 2023 16:22:32 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 13 Dec 2023 07:22:44 -0800 (PST) On Thu, 07 Dec 2023 16:49:41 +0100, Maxime Ripard wrote: > Even though we were rolling our own custom state for the vc4 HDMI > controller driver, we were still using the generic helper to destroy > that state. > > It was mostly working since the underlying state is the first member of > our state so the pointers are probably equal in all relevant cases, but > it's still fragile so let's fix this properly. > > [...] Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime