Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5388935rdb; Wed, 13 Dec 2023 07:22:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IFNBCV72eD/XQ0aL1y4RvtkDfGTF3YtMBA2wbjFp5bBd09qa6mJkky2T0M2pxiLHNkQyb2Q X-Received: by 2002:a05:6a00:2451:b0:6ce:52b1:f9f8 with SMTP id d17-20020a056a00245100b006ce52b1f9f8mr4487403pfj.27.1702480977685; Wed, 13 Dec 2023 07:22:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702480977; cv=none; d=google.com; s=arc-20160816; b=gbMYw3uu+RCxv3Z0/pqxFjytmDsBzJgsuY7+sld7qh/iewe2xFbouQ7b+eanMxTLRc +vyON1clhs8K7jrl04Yvi9z+IphZTmKX9EAo3AODRX0gEQEOzxb1jUuF34YFyJUulTX9 djG63BCjm+7QtRGuEDvGn8CR9YRbbBkdCkD9wCHr+rZHzzhSZTJip7FANuLTs4EO5msP Btz9nTsbg/H+d7rS+XYBnXWnsxgjxymiCe3APNbwWJcExxC5eQcCZZS1kFHLbO/BMFEl BzOKW7Fw1xsLew8klMSIfP6QyPCePBTOevoLhKSOby/iPPdnbmcd8/RXwGQfUmkeh3Xe U74Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=R5eDIdujefU2hmDOrR3McK9fC3HERT/QsBUIdFu9lb0=; fh=F11qbXj7uBf11h9NZktEHFM06lvj1JwQy50xZu2UMqQ=; b=YGvu0mxIntW634eN37TIxiMVSuPI+HpKck3Qrd5J5y5XuwJMkcoEKzbYQmYc03AiUM lP7NRizDe+0aclJoaimsbJuW+iErachbOO2/tlQuk63xx4qoMnrI6HgnI1+L48YKz/rx hY+CD2X0VhhNqMTWZVJqcwJR3inzd1q0uAlNuiIJchebDYJTYcXJz20p54gYyYAcKmWy KqfMsIt1vYXTb+JTGeuimb+YYcmUh6FsdUXnqOPmE8tQh2+qvgV2nw6p8veIsO6QaslI LA+ZMb8Z65+KGYbj4W4oF3cPeJj09PBJIW4ixYICAOAvWWtbRwoT9BYdMQ0qOjfF6CJz 87dQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GDrZI2XB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id y31-20020a056a00181f00b006cd8db77f84si9563367pfa.274.2023.12.13.07.22.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 07:22:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GDrZI2XB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 6682D8031AF9; Wed, 13 Dec 2023 07:22:47 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442501AbjLMPWd (ORCPT + 99 others); Wed, 13 Dec 2023 10:22:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442482AbjLMPWc (ORCPT ); Wed, 13 Dec 2023 10:22:32 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67D55F3 for ; Wed, 13 Dec 2023 07:22:39 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 945C5C433C7; Wed, 13 Dec 2023 15:22:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702480959; bh=g9AfdMsMWQPrTFn3Rfxxtm16T5CwU3D5GqboUlkSxB8=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=GDrZI2XBTh3hJVVSXnxYxcQ4Ww8ny4IzmGeEg2lCyPdTBuIsmFvcdHOOWb3OtN+sK Tois1SqVzSuh4dUcqTnrm6GeKSz2YO2M+zSACcHSe0kaK2xIDt21NRwR5vhw9AFhaN oOWOyxDTSykwywZ7/ug2xhYAC1x58VCuQkgHji75L/2zZdCu9wGzUx+m0hLEdOnjty MR9/mY93zS4jpNKKATj/S1wq7Lv2Qdto6ywA3JCiSKgGgLTyPgGohLQ0YcKBw1GjxE 62s77VFc1bViQj0yc3xnuDiL9x+2Jp0315SB85Qy+InXIFG9zFEPAYk4JOu/zZBjJA n9F+eN/wC2Dmw== From: Maxime Ripard To: Frank Binns , Donald Robson , Matt Coster , Maarten Lankhorst , Thomas Zimmermann , Alex Bee Cc: David Airlie , Daniel Vetter , Sarah Walker , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org In-Reply-To: <20231208170856.1748413-1-knaerzche@gmail.com> References: <20231208170856.1748413-1-knaerzche@gmail.com> Subject: Re: (subset) [PATCH] drm/imagination: vm: Fix heap lookup condition Message-Id: <170248095546.191897.14747854434891174089.b4-ty@kernel.org> Date: Wed, 13 Dec 2023 16:22:35 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 13 Dec 2023 07:22:47 -0800 (PST) On Fri, 08 Dec 2023 18:08:56 +0100, Alex Bee wrote: > When conditionally checking for heap existence of a certian address in > pvr_vm_bind_op_map_init the condition whether the map request comes from a > user is incorrect: The context must not be the kernel-context to be a > user(space) context and should be looked up in pvr_heaps. > > That makes addresses coming from userspace not being verfied against the > defined ranges and prevents firmware loading for meta cores. > > [...] Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime