Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <d70255fb-7dc0-4119-b52a-9e8a955f0712@wolfvision.net>
Date:   Wed, 13 Dec 2023 16:32:09 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/4] usb: typec: tipd: add function to request firmware
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20231207-tps6598x_update-v1-0-dc21b5301d91@wolfvision.net>
 <20231207-tps6598x_update-v1-2-dc21b5301d91@wolfvision.net>
 <ZXMudF++A9/y4TNk@kuha.fi.intel.com>
 <196acb44-fb0d-45b6-a9c3-b5a289a41917@wolfvision.net>
 <ZXhq/IJp9KVCkQYb@kuha.fi.intel.com>
 <f942ad57-e2e1-4896-83f5-a1acc0805afa@wolfvision.net>
 <ZXnKqsy2rEJxmXhG@kuha.fi.intel.com>
Content-Language: en-US
From:   Javier Carrasco <javier.carrasco@wolfvision.net>
In-Reply-To: <ZXnKqsy2rEJxmXhG@kuha.fi.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MU5IYkVKRHlRRC9DdUtXa1c0aEpUN0xGdkx5OVhmbSt0UU9NT2xEdXJENFpu?=
 =?utf-8?B?OWVGajBXRm5UOWljRmJ2R2dONHFDek5XOStLaXlXbUhUT04zS09laGtySk1G?=
 =?utf-8?B?YUUxY2Q5N2ZhRjE2bWY4SEJuMGFEbTBTNVpTVXJ6NVVJVEVKM0NvRVNWcmlw?=
 =?utf-8?B?RktKbTA5cmI3K0d0akNOZWVUMnNYUGV1RWVsSlhEdWc1a09FUTZPbE5NeUIx?=
 =?utf-8?B?R0kySEFQZUx1Z2s5NFJTOGpRSEpjcVZPbUtlcjlwdTdUbGY3d3BHYnIvR0NR?=
 =?utf-8?B?Uks0ZFNGTnpyRmp4WmtBWTVTMHF6N29aZXplUEI5ZWtsVzhUUFZuSXdJcHBP?=
 =?utf-8?B?NWFkb1dOcGo3UUg3RjFSYTczRXM0RUlnbTZYb1Q3N2lTamlzdmJwbUxTSXBZ?=
 =?utf-8?B?enh6OWZkamRxTUx0czc0cVd3TW5pQUsrdTNqaUI5aWF0QmdyL096MEFkemJO?=
 =?utf-8?B?cmtlYzB6aXZGSzh4SGx0dHdSS00rUjROT090MXBYc1Uxdlh0WDBMWmZWMlUx?=
 =?utf-8?B?MDhQTjBKTDh2clROOUlpZVltQlk0OXhXdHhRV2pHc2xoVmw2enZJbFVVRnVu?=
 =?utf-8?B?anpSYXE0TXpxeHdUZUliSyt5cHhTSDIwQXE3aVdtcEpHWXFEZ0FySFhKNCtJ?=
 =?utf-8?B?ZWI4eCs0aUFxOERkOEV4NXF5RFZNNEsyd213R1dDbHo0TEhxZDM0N3MrU3FS?=
 =?utf-8?B?N1grbHNqNU40YVYvWVpsQjdJa2xOQW1OUE8vRThaMTJUSGJNOXp2eGV4Ull0?=
 =?utf-8?B?MFBtSDFXcnhBZW41bG1FQS9lQ0ViZWdFWjJBbGhucjBSVnAzaGQvdHBZeGgy?=
 =?utf-8?B?aXhON1BuNW1uNk4zZ3I4cTRSY3lXRUJIS0x2eFVGdEFwaDVwTWhxQ2ZCV3F4?=
 =?utf-8?B?TFJsQ25RaDFSR21NTzlLN0dBRG5ybFVqbG9GWnV1eS95Y204d21OL0hicHVF?=
 =?utf-8?B?S1E5bUNITTBXWEpZby91YSsrR1FhN1lXbG40aVRxY2dVbzMwRytwZnhUQ2lj?=
 =?utf-8?B?LzRvd3R4clhSWFVoWlRGK3RhWWErTVhEYnpIVFMyTUx2OUJzVlZYWnYycFRH?=
 =?utf-8?B?WUFZcmJaNFliWEtESDZCUXpTcy9KTWFZa2ExeHFYOUt0N0tCQ0VTQXU2Rzkr?=
 =?utf-8?B?dVBYNnU2YlN5VlN3ZkRiRTJsZEZqVFpDc3dEclhRcFhSb0UzSU5rQVVoWHZZ?=
 =?utf-8?B?ZmYxUDVBS296cGpBeXhDRjdZdEdNRkdBemxrcmRMZGM4OWw5anlIOHF3OWF1?=
 =?utf-8?B?bXlENXhzeUpCTnJTWEdtNWVPcjZib1BEc1l0ZmlkRWl2UW1UQVg2Z2xMZWFO?=
 =?utf-8?B?aFQ3WmpBWk14YityOXUrSTBmRXFyNzkyMFVHTzllNlBnRjJpZVZVZ3pWdVFr?=
 =?utf-8?B?NG9Rb0R4bGRwNklaanF2K21Fc0JpWG5rQ2hydGZlbUFSYVM0VnI2cmlLZXZz?=
 =?utf-8?B?MVhoUGpKa0p3MWw4QlFFQ2hVVVNiU2dMZTlhQ3Y3UFRtTUxlSERDVTNqTUhM?=
 =?utf-8?B?czNYdU5ubGhlVyswczRzZ3Q4ZUVPazlObXZ6YlBZYnVYTndGSmlCM0g5TVE3?=
 =?utf-8?B?TGhYb1FoYmNnNVJUNEM4RGZBWG9sNjRoNWdPQnhTTC9NejMrUlRiZmhlNXkx?=
 =?utf-8?B?Mm1tRUprQXhYSjU4QTBEdzdlZVVhQ3lXeldlS2Jjb0N5OXZqclhMSFJXMEs3?=
 =?utf-8?B?V2Y5NFpjYlZZaGlQaGpORGQzSkJZc2ZSNGNBZlZTTDlpOE45blJVZTE4dm9U?=
 =?utf-8?B?TFIzcmFVeUN0eW5udEJHSlRTWFVYdDllT0tXdEF6T1Q3TC9LaThuOTJxbGd0?=
 =?utf-8?B?LzR2VFFFVmFQVG9ZN3U2cjdiUGtUSFdDcENKSGc4ZElyYy8zMWtlYUJEaCs2?=
 =?utf-8?B?emdpcG5YaUU1YW9IV29OWmlVYUVWT0RIUFRtanZzWDlqSlg2OTZLdDBGdVE2?=
 =?utf-8?B?clI3MEhJZmg0TWs2ay9QTGJIRUVBLzRXcndTbTk1SkZiY210bXY1Ukx0aTRy?=
 =?utf-8?B?VE12RTUveW9aZ3dmTUVsdW14TUlDSlB4SVlDS1p6ZTVPM2pCbHZYTkp6ZUMz?=
 =?utf-8?B?OWZGWG94UHBiMEhLOU9Ra2J6eWtaaUF1b1ZSN0lEbUx0SXBqRS9wNGNNZ0d3?=
 =?utf-8?B?ZDg5blVvNDNvcFErYlEwc2pHbGR6ZVVOQ3FYT1VlNkNYMVdROUxTMlBtUENi?=
 =?utf-8?B?TlE9PQ==?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c2c6400-3384-4508-4593-08dbfbf0ad0c
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 15:32:12.0079
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +SvcyiOBUwalTCgfGq5wOwCg8pYmrBQg8pfVFVRdr2iIG2oT0/MBaxG+A1fOPuGfYE09qU4ZgpCTSRV8RFzqHe5dlVWFtHkvRvFuOPSUpM0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8907
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 13 Dec 2023 07:34:52 -0800 (PST)

On 13.12.23 16:15, Heikki Krogerus wrote:
> On Tue, Dec 12, 2023 at 03:41:35PM +0100, Javier Carrasco wrote:
>> I wonder why then there is no general solution that does not force the
>> driver to be built as a module.
> 
> Why would you need anything like that? Are you saying that even if you
> put the firmware into your ramdisk, the driver still fails to find the
> firmware if it's statically build? If so, then there is something else
> wrong.
> 
The firmware is always found unless the file system is still not ready,
which is the case on the system I am working on. If the driver is built
as a module, the issue is gone as expected.

My point was that there is no limitation to have the driver built-in and
no documentation to reference, so anyone could stumble on the same
issue. And as you said, this driver is not special in that sense, so
other drivers might be facing the same eventuality.
Am I missing any existing documentation for the fact that the firmware
must be put into the ramdisk or the driver must be built as a module? Or
is it only based on common sense?

Anyway the next version will not have any probe deferring and only
return an error if the firmware is not available.

Thanks and best regards,
Javier Carrasco