Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Wed, 13 Dec 2023 16:37:57 +0100
From:   Marek =?UTF-8?B?QmVow7pu?= <kabel@kernel.org>
To:     Christian Marangi <ansuelsmth@gmail.com>
Cc:     Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
        Daniel Golle <daniel@makrotopia.org>,
        "David S. Miller" <davem@davemloft.net>,
        Li Zetao <lizetao1@huawei.com>, linux-kernel@vger.kernel.org,
        linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 1/2] leds: trigger: netdev: display only supported
 link speed attribute
Message-ID: <20231213163757.1d576bb7@dellmb>
In-Reply-To: <20231213150033.17057-1-ansuelsmth@gmail.com>
References: <20231213150033.17057-1-ansuelsmth@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

> +	/* Display only supported entry */
> +	if (attr == &dev_attr_link_10.attr &&
> +	    (test_bit(ETHTOOL_LINK_MODE_10baseT_Half_BIT, supported_link_speed) ||
> +	     test_bit(ETHTOOL_LINK_MODE_10baseT_Full_BIT, supported_link_speed)))
> +		return attr->mode;
> +
> +	if (attr == &dev_attr_link_100.attr &&
> +	    (test_bit(ETHTOOL_LINK_MODE_100baseT_Half_BIT, supported_link_speed) ||
> +	     test_bit(ETHTOOL_LINK_MODE_100baseT_Full_BIT, supported_link_speed)))
> +		return attr->mode;
> +
> +	if (attr == &dev_attr_link_1000.attr &&
> +	    (test_bit(ETHTOOL_LINK_MODE_1000baseT_Half_BIT, supported_link_speed) ||
> +	     test_bit(ETHTOOL_LINK_MODE_1000baseT_Full_BIT, supported_link_speed)))
> +		return attr->mode;
> +
> +	if (attr == &dev_attr_link_2500.attr &&
> +	    test_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT, supported_link_speed))
> +		return attr->mode;
> +
> +	if (attr == &dev_attr_link_5000.attr &&
> +	    test_bit(ETHTOOL_LINK_MODE_5000baseT_Full_BIT, supported_link_speed))
> +		return attr->mode;
> +
> +	if (attr == &dev_attr_link_10000.attr &&
> +	    test_bit(ETHTOOL_LINK_MODE_10000baseT_Full_BIT, supported_link_speed))
> +		return attr->mode;

Why only the T modes? There are much more ethtool modes for these
speeds, for example at least 5 modes for 1000 mbps speed:
  1000baseT_Half
  1000baseT_Full
  1000baseKX_Full
  1000baseX_Full
  1000baseT1_Full

There are also 2 possible modes for 2500 mbps
  2500baseT
  2500baseX

Ditto for 10 mbps and 100 mbps.

So if you're doing this, why not do it properly?

There is an aarray
  static const struct phy_setting settings[]
in
  drivers/net/phy/phy-core.c
and a function phy_speeds() which will tell you which speeds are
supported for a given ethtool mode bitmap.

Or you can add another function there,
  bool phy_speed_supported(unsigned long mask, unsigned int speed)
and use that one.

Marek