Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Wed, 13 Dec 2023 15:38:38 +0000
From:   Lee Jones <lee@kernel.org>
To:     Jean Delvare <jdelvare@suse.de>
Cc:     Pavel Machek <pavel@ucw.cz>, linux-leds@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] leds: rgb: Drop obsolete dependency on COMPILE_TEST
Message-ID: <20231213153838.GM111411@google.com>
References: <20231202214353.7c02f23c@endymion.delvare>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231202214353.7c02f23c@endymion.delvare>
Precedence: bulk

On Sat, 02 Dec 2023, Jean Delvare wrote:

> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Lee Jones <lee@kernel.org>
> ---
>  drivers/leds/rgb/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

It's not clear to me what this patch improves.

Going to choose to keep the status quo on this one.

> --- linux-6.6.orig/drivers/leds/rgb/Kconfig
> +++ linux-6.6/drivers/leds/rgb/Kconfig
> @@ -4,7 +4,7 @@ if LEDS_CLASS_MULTICOLOR
>  
>  config LEDS_GROUP_MULTICOLOR
>  	tristate "LEDs group multi-color support"
> -	depends on OF || COMPILE_TEST
> +	depends on OF
>  	help
>  	  This option enables support for monochrome LEDs that are grouped
>  	  into multicolor LEDs which is useful in the case where LEDs of
> 
> 
> -- 
> Jean Delvare
> SUSE L3 Support

-- 
Lee Jones [李琼斯]