Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <63debea9-4329-4e0c-a028-ad9233f13b64@oracle.com>
Date:   Wed, 13 Dec 2023 16:02:35 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 05/16] fs: Add RWF_ATOMIC and IOCB_ATOMIC flags for
 atomic write support
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     axboe@kernel.dk, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
        jejb@linux.ibm.com, martin.petersen@oracle.com, djwong@kernel.org,
        brauner@kernel.org, dchinner@redhat.com, jack@suse.cz,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-xfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com,
        linux-scsi@vger.kernel.org, ming.lei@redhat.com,
        jaswin@linux.ibm.com, bvanassche@acm.org,
        Prasad Singamsetty <prasad.singamsetty@oracle.com>
References: <20231212110844.19698-1-john.g.garry@oracle.com>
 <20231212110844.19698-6-john.g.garry@oracle.com>
 <20231213133110.GL1674809@ZenIV>
Content-Language: en-US
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20231213133110.GL1674809@ZenIV>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWVqWmtnajg0MGVPckduS3dwMWh4N2NBM1Nwc0JzNys5emwyRjBLSWpxVmhY?=
 =?utf-8?B?Z0hpbDlnamYrZU9KbkJpbDc5dW96MkpndENOdUtUb0x0cFg4VXI0YUxPVGNC?=
 =?utf-8?B?WXJtb2JMWDBBMG1DUXNyOUVyQzZ1cWI3VVFJbzNOQmVGb2pLWmMzTFNVako5?=
 =?utf-8?B?NDFLWXZvNkFhQ29kZlprN2ZEYlZERUovYVVVTFRmc0NwKzRQL2haOW15Y2s5?=
 =?utf-8?B?dmdoYUQ4QS80RW9vZjVGaUdubEhpbXkxWS9lRzNDejJEWHlTbm5hMFJNMFYv?=
 =?utf-8?B?UmgzMEdIeXZtcTFmcFZmMDl4RElTeTUweXZNTk01eWNpejN6ajd6a2E3dXZp?=
 =?utf-8?B?OGxKTG8yc2dBWXc1VmxacVlyR2NIcTZoUjBwbzVZcmFabWljdGFqdC9Uc01h?=
 =?utf-8?B?MlF5YmdyRlUxWVFqektCQVFNdkc0NFMzWld6WmM2QWdZa2lCMWZaUFEvMzdQ?=
 =?utf-8?B?OTBQTFMzenZWWUpVQlJnUGdGNytKc3BKNVcrM0dFb0M1TDVuSk8yVUFWQVNC?=
 =?utf-8?B?bkRzWUFtNnZuc1dvMkZoaVVhbWM1UmwzVDFFQm9Vd2FEWWN0cVJ6b1pDU09E?=
 =?utf-8?B?MHVuc2RMcFdXY0xKa25HYklubXMzeFliaVd0YjBBVDJzbENsNWFlSmErSkZm?=
 =?utf-8?B?VWZuQjF6a2M2NTVDMDB5ZExVODF1SHlxSnVnY1ZvenpweFBxdWhyRWFsenV5?=
 =?utf-8?B?eFlLU20yQklqNDdQaEVUb3dyRTUwaExVbExGVDBSdnExdTJlWTNMR1VDS2JY?=
 =?utf-8?B?Zm9uTGUyNXZPck1uTUczVXRSQ1JVTzB5dXVXQ01VWkx6R0hVNFJxdGZVdlhL?=
 =?utf-8?B?dVBrVmFFWjl4YnVKb1BOcHcvVzVGWmNoOHpZeGtqOTNNcFpablZ3VlNOc0E5?=
 =?utf-8?B?Z2ZDT3B0RzlWT1RiZE94TlpMcFQ0eE9CQzFXRnNsS2FHT1ZGaTRCcVpiVjNt?=
 =?utf-8?B?cUdxUUxTNFNseUtuRjI5U3ZYdDJDSlNqRnlSeWdsT2dHNzZvQVM0cnhqa2hs?=
 =?utf-8?B?NFE3djlXeHNKazc4TVJDV0hiQlJxSFUvdThqalB5QUxJNzlycjlkTS9ESkZr?=
 =?utf-8?B?cUlPR3hseHNHUFVDWHNQa2xYclNweFNaNXJndDZhVFFlZmFVb1dUanJiK2ZT?=
 =?utf-8?B?L1ZKZTFmKzFDQ1VyUHdYMEVLYXlNWFRuSTc0elBxa253bkM3cUdzY1o5MnlZ?=
 =?utf-8?B?WnFJZGJFZ0V0V29lWmhDYWFUdU5jYXBjUktMSEo4dVZSRzZNdmhiMldXSkFa?=
 =?utf-8?B?M1pDUnpWWThmbG9peXVRNHhLOXZCMVhnaEExYVhVUVpidm1VNDVNelVpZ1p3?=
 =?utf-8?B?SDVUUlEzenQ1MmlKWk43enhrMTQzUUd4dlQ2WCt1VjgyaEhDWk1mTWlOeHJm?=
 =?utf-8?B?aTM1RXlHR1NTRGdvdzUxRzRFRHpWZXVBZ0g5MHBnN2RWbG42NjQzTC9hRUpx?=
 =?utf-8?B?S3R3SmU0YkJtTC9UYWNDSzVzYjd1RlZwVWJ2bkxWbWtkQlVZZmpkZUdOeUhG?=
 =?utf-8?B?ZDExVnBLb1ZxL3lxc1kvVjI4WmpoclExNUFvbEo3aXlsNWRSM2Z1Rmh2SGVV?=
 =?utf-8?B?dXZrU04ySk1WRmt6WWxkamlpOXFGZ3NkV2NiRGhYSlhKVnJQeEY4cWpSNzJw?=
 =?utf-8?B?bGlSSGJkS003R2lPRVJuSWdoR3M5UWdRN3FDTmhIY2xBT3ZjdzAramVtTG1j?=
 =?utf-8?B?Y3ZvRjNXbWE5RkNRVDRwV0R4Y21jNzBWY2I1c2ZSWlAwbk1kaE9uZmt6N05i?=
 =?utf-8?B?VWFyM3FlbkNkVHBndDdIK2dFb3B4eE1wbXZ1MlNXVmJEZWorTnVNMnlPMC82?=
 =?utf-8?B?U3lxVDdObnJjRzhUSnZNRUJGTG5pNDNKb3UwVVBCbUM2eU9RU2RMbmNCSzhm?=
 =?utf-8?B?MVYzaDFtWW5SOUVvTW9waUNjQ2FUb0hzM0tvVGUzRU5nZDdyc2dZbFVkRGdG?=
 =?utf-8?B?TlllamtEcFhJRWJLdHpkVHNIeHVzdDNNaVBzcGFpWWdrR1FWNndTUUdUUWx5?=
 =?utf-8?B?elJjQXlKVFl2TDVmd1JYbDhnN3Vxb2dZc0o0eHVjNm5ENWk4SHZ1U01NWVNF?=
 =?utf-8?B?YW15Tlg0M1l5MVVldzlidHkrMFg0ckFZUWlkOXNab21KNmRKMVJJOHNoWjR5?=
 =?utf-8?B?MU1WbnY5QXFxK05UK3dIaTU2czhMMnZWSDdHeS96RG5RcERxdVVEY1JpaTZP?=
 =?utf-8?B?UUE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?MUlyQVBkRWVTZ0ZoUTZJd0dOTCtlWmJpTCtVWXc0YUlOWmE2dUh3bUM4ajV1?=
 =?utf-8?B?QTVGZ2tRMjc2N1pCUDhUTDRzYTlmb3V6dmUwSWMzK01IM2JpYUpSZEVFUXpD?=
 =?utf-8?B?b0tPa056NTV5a1pPTDJ5dVhwZnRuNkdlNlh6YzRidS92T2dmbzdoUDZuSG1P?=
 =?utf-8?B?bktZaWgrelVpTlZRS0J6NWcwSEkrTFE2UFo5THNNRkpsZjl1U1FjVmlSaXRp?=
 =?utf-8?B?ODgzT01nU04wV2tFcE14T3Y5S1pMV2dGNzFDQzVJZkpIU0JOZHNLK204aE5o?=
 =?utf-8?B?T0xHeHNNMG10WDJPcHUrTTJERXBJNTA0VHJGcTFDVldzaHRGWHUxc2J0QVNC?=
 =?utf-8?B?TkVwQjYzeEZxRStpZVBvd2dqL0xVUWpQd1JvbkdwQ2VHcGQ4NDhXWDAvNW1I?=
 =?utf-8?B?L3hKQkl1KzdHb3ErM1IxV3dNVHlqTU1xOEVxRDFuK2NLOU1haisrejlLdStF?=
 =?utf-8?B?ZXZCTlJhSG1GZHFqYjZQMXVVQ2dlbTVmaU9FbmJNTlRVdkdzR0RSTkh1Ylky?=
 =?utf-8?B?andGZGtWZm9kS3B6TE0xaVY3V0tUVUl1K1JJb21LNHBVSDAraUYwTys3NEw0?=
 =?utf-8?B?TnVUc0lZSkJUOHRsK1hWa0lSd0VQdWtLNFFwRFU0YjMvRkw0WGl6RmJncXRr?=
 =?utf-8?B?T3l2UEZ5dzEwMUNzazdSVWQxS1BVblVUT3o0SSthUWRWR1pVRmtqa1ZtR0pl?=
 =?utf-8?B?WHZOelg1WkZhU3ZGNFFxZE0rMXJkWlFRU3lNSnlPR2xYUHJ1eEhQMGl4NGRh?=
 =?utf-8?B?bVIwY2x0RlFhS3pmN1o3cm5hMmVMcXVsT0tUSU95ZnlYeWlOVmtVWDZZTGJK?=
 =?utf-8?B?ZSsybzhtSlcyRFNuUC9wM0lxRW5Fam9xZFZvNDl2dzF4L2JEc0Z0QysySjZq?=
 =?utf-8?B?TE9TOVlBV0VzdGtEaE52VEtJaXdFS2ZwQVRpU1ZVRE9tRkp0UGFEWEdIVHkv?=
 =?utf-8?B?MnFsTEJTLzAxOE5tSzlJMlpreldWSG1QVXpIK0RrVkVkTU5JdGxLS1ZGVTk2?=
 =?utf-8?B?R1lQZzdqVEdmcVE3N085SEVSVHJsV3A1Nm8zb1laWWZacTdDa3ZzaGhwK2xM?=
 =?utf-8?B?SEZjSWRVbW9ZMVJPME1RVHRrczdzdE1OMVNaeEVlam5sRUpuTHhBZ2szVWMw?=
 =?utf-8?B?RTBJbllBTG9jM1g1Q2EzbXJENGovWXdFMkNuMnpvaFk1ZEdvSTZZWUh1enFj?=
 =?utf-8?B?WmxVRVpsNXNUM3c5SlBHUUJlaXpMdk1OK2E3S0ZiR2d3aitMbGNQcEF1c3JO?=
 =?utf-8?B?N0ppdHpDUXl4TGZBN0RTRTMwZHZQU3FNaTNoUGdvOUlZVEg1VTFHSjIvdVEv?=
 =?utf-8?B?Y0xyOGZBTUtoVjh3UDlSY25CNEdZbGNwSTVrbkhLekZJY1Z2MHZadnF4NnE3?=
 =?utf-8?B?RFJtZWY5MTJoZC90YTZlZ2RtTDAwSHZrbGo0V2FtK1NxaWRHUTduK0gwR1dE?=
 =?utf-8?B?cWtrcWJTTHhvRVpCRVp6WHN0eWJzSWpjVHp1QXU0RW1CaVNmREFDS2g0TitH?=
 =?utf-8?Q?w00rEfGndksoC0mg1PbVa7yfulC?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 87c6f73d-14e5-41fb-2790-08dbfbf4ef0b
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 16:02:40.7464
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Migkg1mZXN7avobHaOhTr4ADnt/llIW4/fuB0srxWOyQcIqgw3zfmSPZdTIj+cBIEGnWkuxEh6PuG4Uzk6z4XA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6895
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-13_09,2023-12-13_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 phishscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2312130113
X-Proofpoint-GUID: 5cnQBkZG4Gc4Ip7h2IIdFsxpTfNilV2K
X-Proofpoint-ORIG-GUID: 5cnQBkZG4Gc4Ip7h2IIdFsxpTfNilV2K
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 13 Dec 2023 08:03:27 -0800 (PST)

On 13/12/2023 13:31, Al Viro wrote:
>> Add file mode flag FMODE_CAN_ATOMIC_WRITE, so files which do not have the
>> flag set will have RWF_ATOMIC rejected and not just ignored.
>>
>> Signed-off-by: Prasad Singamsetty<prasad.singamsetty@oracle.com>
>> Signed-off-by: John Garry<john.g.garry@oracle.com>
>> ---
>>   include/linux/fs.h      | 8 ++++++++
>>   include/uapi/linux/fs.h | 5 ++++-
>>   2 files changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/linux/fs.h b/include/linux/fs.h
>> index 70329c81be31..d725c194243c 100644
>> --- a/include/linux/fs.h
>> +++ b/include/linux/fs.h
>> @@ -185,6 +185,9 @@ typedef int (dio_iodone_t)(struct kiocb *iocb, loff_t offset,
>>   /* File supports async nowait buffered writes */
>>   #define FMODE_BUF_WASYNC	((__force fmode_t)0x80000000)
>>   
>> +/* File supports atomic writes */
>> +#define FMODE_CAN_ATOMIC_WRITE	((__force fmode_t)0x100000000)
> Have you even tried to compile that on e.g. arm?

i386 and now arm32, and no grumblings.

I think that the issue is that we only ever do a bitwise OR or test that 
bit 33 for a 32b value, and it is a void operation and ignored.

However if I have file.f_mode = FMODE_CAN_ATOMIC_WRITE and compile for 
arm32, then it complains.