Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5446130rdb; Wed, 13 Dec 2023 08:52:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IETZL6rKJtfg1B2VS0vtRcwvHQH07Os9L1LQmUCfQ674BSOB+o83rOkLTW880UbH1MvFzKi X-Received: by 2002:a17:902:7847:b0:1d3:33b1:f57b with SMTP id e7-20020a170902784700b001d333b1f57bmr1422646pln.14.1702486346560; Wed, 13 Dec 2023 08:52:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702486346; cv=none; d=google.com; s=arc-20160816; b=m3f+lj4RDsxRlOWGEzJgN5duq5nbV72LqELST6wcqBUWRy47KsxWyFsApz2KQz8QrM YPdw/8i6+6TVreP+Jrky6btuKYBch01PHhiPWhK1fhLknqnC+HWYEJxpqPe1g5Or5HKN FBZPE4JS72Ec3ADlbRAT8DrwlaeBwFjP7tLmxw8zso7+DQkGySuEY5bb43Bfg1gL8CpN jY163Aq5XvRvECojdKkuiv69ccxApQuKMqPj7opCPDIyaV3TTWjsTZce8uCACEMFanon BkCwq7CjyQH7caOfo/KWjYst32BlxvfrO+pjBUmUvHo7WfcLefxLTlof1w5aCAa6QQmF 5dxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=hcU4d4c9EhwDhCpZ+xb05RdkC86nsBALUhVrkSRZ1Dw=; fh=Sw1rtAM+hKyOoOQVYiiLzcdjc4spg79Z/tN6UmWUAKs=; b=s8O0sM/er+eXWKjLqY/109lbvkjgH/0fuZFtcA0pS79c+Yt6/NhPrQNYWm2KtBZnNp VyQTqGBMAEa1XpWVDSj5wEK39gF3tpDSf/G499VIiWy/cTmIM3ngt1Q26tFupu9TMtit tU2apBvNU4EVbqnq43N12021jHa+8hRy7g0tLORoGXkj2YRKmnDS1Q6dcIK6a3q4RPgg 1FIyRvFa0/gE4glQKKseaBiSb5xyCy+yfa1qF4m0mzUkyI93OuBb59mJs6s1SNyui/jH cw7PJwgTSW9vCKbmFQ66qHPRVU0f/OBUGGDvm9fdMxI3M8Z8eXcuptfOasvf6TiUDLrY +KOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="TI9tH/ip"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id r23-20020a170902be1700b001d09ffdfe1fsi9721400pls.171.2023.12.13.08.52.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:52:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="TI9tH/ip"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 836C2802FD30; Wed, 13 Dec 2023 08:52:25 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378912AbjLMQwP (ORCPT + 99 others); Wed, 13 Dec 2023 11:52:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378960AbjLMQwJ (ORCPT ); Wed, 13 Dec 2023 11:52:09 -0500 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FC0CB9 for ; Wed, 13 Dec 2023 08:52:15 -0800 (PST) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-54cea1f30cbso1538180a12.1 for ; Wed, 13 Dec 2023 08:52:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702486334; x=1703091134; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hcU4d4c9EhwDhCpZ+xb05RdkC86nsBALUhVrkSRZ1Dw=; b=TI9tH/ipcl9K7i14cVskk3TqvSimXxuaFFvLRYrJur6UzVjkBXbJ/ocMHfspeLjTX6 9Gj7GUZeU22Rr4yPGiSKGFE55rYw090pVwcqUag4202Ik+yzSXpwtgsBRhjmjkfx6sCL LXn4UyKGgl9H0fxvhQyJhdUikLmQ+u/s8AqDjNHx2A6qMPUzEzXi055BawstDcU3Ma6B +RkP0ijaCVmXbiQgqjvhtvc9hRTDUmyYEpbbdw/QnEzWUOf/KYHh3hRKDbpnNlx/HBGy nBojjgRg5f9HNna0GhEXYetMtp63BkTVeDr+9JruaDVn9kCK+hXnPIWxdJgUrTQ5E1lE YG6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702486334; x=1703091134; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hcU4d4c9EhwDhCpZ+xb05RdkC86nsBALUhVrkSRZ1Dw=; b=J9GydbKMHIvve7FQWk5KbwMEQMT60mdz/lreKYkyQGaaYeloD/TNCY4+e1j1lzUjPu nf9bK5KHB08QxcrR2Wn8WwwC8pDy6hF3JhzBA7C8Vqil1weFrxcifYJbX+Iv9KK+yfns KLMRciL/hzxbIMEp5KeBak1LQ6apO5cm5lKZxYpOlkQ1Lz9d54lDudGgRGoCV02jFJcH +EmZxSFh+zQ3rfCypRSNo9GtxeHYF8j/RpEyB9MC4EoPZe4zpAiNeCKHumokNOd3KZ5P wmoo/SgaJZFZ4/tI9o7rGQDkAvOIR+s/CgNwfhs/7kit9EToxPEWbSUF4nmh27N5ST02 Nyyw== X-Gm-Message-State: AOJu0YxsbtNpG2MVMYlvphnExPdHQZlXloP4+eRR1M/mALvSygL55aBG vCyHXevkBbVT0nwHGdZoYMaDLLktAtM= X-Received: by 2002:a50:c189:0:b0:54c:6fc0:483a with SMTP id m9-20020a50c189000000b0054c6fc0483amr8757847edf.2.1702486334020; Wed, 13 Dec 2023 08:52:14 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p54a07fa0.dip0.t-ipconnect.de. [84.160.127.160]) by smtp.gmail.com with ESMTPSA id v1-20020a50d581000000b00550ce74f7eesm4994896edi.67.2023.12.13.08.52.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:52:13 -0800 (PST) Date: Wed, 13 Dec 2023 17:52:12 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 05/10] staging: rtl8192e: Remove constant variable forced_short_gi Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 13 Dec 2023 08:52:25 -0800 (PST) ht_info->forced_short_gi is set to 0 and unchanged. Therefore all equations result accordingly and ht_info->forced_short_gi can be removed. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl819x_HT.h | 1 - drivers/staging/rtl8192e/rtl819x_HTProc.c | 1 - drivers/staging/rtl8192e/rtllib_tx.c | 5 ----- 3 files changed, 7 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index 43472b2250c2..e6cd906dc0ac 100644 --- a/drivers/staging/rtl8192e/rtl819x_HT.h +++ b/drivers/staging/rtl8192e/rtl819x_HT.h @@ -110,7 +110,6 @@ struct rt_hi_throughput { u8 current_mpdu_density; u8 forced_ampdu_factor; u8 forced_mpdu_density; - u8 forced_short_gi; u8 current_op_mode; enum ht_extchnl_offset CurSTAExtChnlOffset; u8 cur_tx_bw40mhz; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index d424b7729a01..578d9276035f 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -527,7 +527,6 @@ void HTInitializeHTInfo(struct rtllib_device *ieee) ht_info->cur_short_gi_20mhz = false; ht_info->cur_short_gi_40mhz = false; - ht_info->forced_short_gi = false; ht_info->current_mpdu_density = ht_info->mpdu_density; ht_info->CurrentAMPDUFactor = ht_info->ampdu_factor; diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c index 0fa6f674a844..f7098a2ba8b0 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -340,11 +340,6 @@ static void rtllib_query_HTCapShortGI(struct rtllib_device *ieee, if (!ht_info->current_ht_support || !ht_info->enable_ht) return; - if (ht_info->forced_short_gi) { - tcb_desc->bUseShortGI = true; - return; - } - if (ht_info->cur_bw_40mhz && ht_info->cur_short_gi_40mhz) tcb_desc->bUseShortGI = true; else if (!ht_info->cur_bw_40mhz && ht_info->cur_short_gi_20mhz) -- 2.43.0