Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5448275rdb; Wed, 13 Dec 2023 08:56:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IHe+bfYeb9zgzih+f8LzF1X8hM78ARclMVbs9xHTBGF6yFHnl4tkuwEyoP0rGdxtbqp2v2s X-Received: by 2002:a17:902:c20d:b0:1d0:6ffd:9e0c with SMTP id 13-20020a170902c20d00b001d06ffd9e0cmr8887203pll.94.1702486606502; Wed, 13 Dec 2023 08:56:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702486606; cv=none; d=google.com; s=arc-20160816; b=sDKdzUa7QXcIazkuU2tWwtcDCjxdVBPT9+/UYrAeEtoBuRG2dtFEosjPdbJFPsquMy CeiaMVBxME9YbzU7HoWixd87dZGv9zId7xzbTtYknfn2q/+CJd2e2vQGH97Gp4UrwBWQ sw0da042O/DSGi+ZCiJ/kUjHVRohCFcKmz7WYCnqX6HDIRztoxBYMSSILFUd5PZAdVIr m9utwqEZmc3jSC8kixhWVmeF5hNm8zd33Cmk3rbdg9ejHevXgoOzKlCATyXJdceSiiUR hwqPkNP5zF/mGabmGsjNNWxgEv6FlV3cfLACmZXKi/qoj+llDtUDqTTrWFt+4dUP7bKB OleQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6C+G+He17NccpRYXyvfr/RRpub5+8DDVn1CdeNstsjM=; fh=qMh/9I8quKSv1BTsA2RWgew2xwaa8LbFTONQopkBi9A=; b=mgumPx5VNvpvNsRSuSPvS0XPEuT0nqWWuPhUHBjEoCcXfomrGxjoS+c9BUaILkQbpm whB3MxpX+505OXhIGyxSShmGtzc0tN8SchP+2hUnX5/rA1JlejParJbLzmB6QFpl+NOs 57TvQO+PG9eIPTypMAQzH0mX962cKmV89CcsAg0FrhDX0kcNezA3eX7iJRtuBrtvSsmE bv5jFtOiqenjStan6/38FKEJ/npd/FLRYhHso5kKDGnplYfQK73X1qTnxXTd4CmL65JG IpXWS4q8foI2Szp7Wxlpsdj1RHBS6/ceKw9TjgiZXc7ya37SLBqJv6IgRf7YaMvyMRPA McuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=eMShkFmE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id z9-20020a170902834900b001cf68d533fasi9572127pln.633.2023.12.13.08.56.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:56:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=eMShkFmE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 6283880737ED; Wed, 13 Dec 2023 08:56:07 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235204AbjLMQzb (ORCPT + 99 others); Wed, 13 Dec 2023 11:55:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233248AbjLMQza (ORCPT ); Wed, 13 Dec 2023 11:55:30 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F6AAAC for ; Wed, 13 Dec 2023 08:55:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6C+G+He17NccpRYXyvfr/RRpub5+8DDVn1CdeNstsjM=; b=eMShkFmEwwZe5F929p52bl4FOD CvbkWqFICiRnUUQ1L//RWI2/P+5TDUv56GmEj4i+95Nj9pWhwp/2RoOLS0MxofbBB4waUmwKHwaHN LwsuQ5EtxnSmzd04hX7iyhhjz252+MtHuP1bq512XRDW+lIkoqFAwRZi+v1H+hgV5ldaKBzUxpDuz KEXf2wwntJZbJtQhnH85vu/dp4kfYJqSvdPYD0jN/DShb1Nr8aEzy5/ITthEmGObyXHmJjR6RlMi2 GSZyllH0Swb0VsZ/MWVlpCb+puMSougMmcBgJyQb7yqH3NA5tL6iYP6RHmFQ9Tt0H64UUxeHpNEfz GCJfbewQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rDSWB-00FWGw-0R; Wed, 13 Dec 2023 16:55:31 +0000 Date: Wed, 13 Dec 2023 08:55:31 -0800 From: Christoph Hellwig To: Saeed Mahameed Cc: Aron Silverton , Jakub Kicinski , Greg Kroah-Hartman , Jason Gunthorpe , David Ahern , Arnd Bergmann , Leon Romanovsky , Jiri Pirko , Leonid Bloch , Itay Avraham , linux-kernel@vger.kernel.org, Saeed Mahameed Subject: Re: [PATCH V3 2/5] misc: mlx5ctl: Add mlx5ctl misc driver Message-ID: References: <20231128175224.GR436702@nvidia.com> <20231128103304.25c2c642@kernel.org> <2023112922-lyricist-unclip-8e78@gregkh> <20231204185210.030a72ca@kernel.org> <20231205204855.52fa5cc1@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 13 Dec 2023 08:56:07 -0800 (PST) On Thu, Dec 07, 2023 at 10:54:02AM -0800, Saeed Mahameed wrote: > Also I would like to repeat, this is not touching netdev, netdev's policies > do not apply to the greater kernel or RDMA, and we have use cases with > pure-infiniband/DPU/FPGA cards that have no netdev at all, or other cases > with pur virtio instances, and much more. Yes. I mean just about every complex block driver has some kind of vendor spcific tooling for debugging, statistics, etc. Trying to deny it just because one function expose by a device is a network device is even more silly than disallowing it for pure net devices (which already tend to be complex beasts).