Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <62ff5c86-a63a-46f2-88f8-6c1589433a89@intel.com>
Date:   Wed, 13 Dec 2023 09:01:35 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 02/26] x86/fpu/xstate: Refine CET user xstate bit
 enabling
To:     "Yang, Weijiang" <weijiang.yang@intel.com>,
        Maxim Levitsky <mlevitsk@redhat.com>
CC:     <linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>,
        <dave.hansen@intel.com>, <pbonzini@redhat.com>,
        <seanjc@google.com>, <peterz@infradead.org>, <chao.gao@intel.com>,
        <rick.p.edgecombe@intel.com>, <john.allen@amd.com>
References: <20231124055330.138870-1-weijiang.yang@intel.com>
 <20231124055330.138870-3-weijiang.yang@intel.com>
 <c22d17ab04bf5f27409518e3e79477d579b55071.camel@redhat.com>
 <cdf53e44-62d0-452d-9c06-5c2d2ce3ce66@intel.com>
 <20d45cb6adaa4a8203822535e069cdbbf3b8ba2d.camel@redhat.com>
 <a3a14562-db72-4c19-9f40-7778f14fc516@intel.com>
 <039eaa7c35020774b74dc5e2d03bb0ecfa7c6d60.camel@redhat.com>
 <eb30c3e0-8e13-402c-b23d-48b21e0a1498@intel.com>
 <e7d7709a5962e8518ccb062e3818811cdbe110f8.camel@redhat.com>
 <917a9dc4-bcae-4a1d-b5b5-d086431e8650@intel.com>
Content-Language: en-US
From:   "Chang S. Bae" <chang.seok.bae@intel.com>
Autocrypt: addr=chang.seok.bae@intel.com; keydata=
 xsDNBGSA2vUBDADAwzfMqLVNww/IEr38sv7+HhLgYlJOOFtZVuNNNXGhlB84co6oFj/91Ssr
 sowT4iLrR0Nlolv31ZRt04ciu5Fb8ql+Uy8ugr7h4qdIYkHxr93a6TPjQYfkSPiSzx9+atDm
 gvZs/0DQxTvkQAPz+n63pCX0Gkym+P9uGCcLjCNLu0Zl38OVwI9So19XjYT8iZJI9iIFW4/k
 ZWOio+rlWQe4O42CtGMk5TeeAC4qlpmzouiqtV9XIEZ53FDAoeMRQihAT1s4MNXauxeMi+zG
 83l/bBNv5F4YQOXbAdtwmrc6ZCDCIcmA4219+aDCdY9HV55v2C08KhyV7sAspIsTaVvhD+Q5
 N1m0VbdMfCB2b/+Oqr9bZdq7kQskDNhSyDtwW2Ih0WcjTHYVFx74XmMBBjjTOsg+jWhhB8ej
 dwLSUnF6XBmZP+VLzZxNh7HT5WHEoaVh1jY0eHElq8+Whd6dj5J9711fNWj9oAGVGtgFUlX6
 6j6SFDIH9y2+jZfFVwHEnV8AEQEAAc0nQ2hhbmcgUy4gQmFlIDxjaGFuZy5zZW9rLmJhZUBp
 bnRlbC5jb20+wsEOBBMBCgA4FiEENnasvWK0f3CE98bLXjTdY77jqUsFAmSA2vUCGwMFCwkI
 BwIGFQoJCAsCBBYCAwECHgECF4AACgkQXjTdY77jqUtGCgwAm3WbV+Jfcyo7LnrNsURikjTO
 37PlNWCyKliOm00KGenk37lXOumyflUY6A1u0Bcww7GoEgIfLEVnB4BkxlUy4TjDAipS2w4G
 FKgxT2c66LaWrV7ZBbaiAzmZX/YMce4lJWELKpE+3O1DNNZ5niGeOg67GHNWlI9j2O+fnZB/
 Pg12ZVN5dTIGFo2WmuIa8ez/ecF0YmIUO4KPoazOWmlHpUGC/Mep8uL2JZl1o5qvAQTCDAwl
 hfnzQz94m9Vtuw9ERp+Rt4fnJQBnuONjh8ksEg5KNVMbBJs4mVyXI0/R6S2QRAfuIkusr782
 UrBWV8xEl8NeXYxFySekFkSEu7SlxnGFyA9yZ5wKPS5ePJu78Qm8418e+0IciYCDAkKUTOGN
 MzCmpuXYGb5keJ3u6KVTLKWUQCZIcMCyv3CO1zpTon0y234SVCyFS7rKlazX5X11G29f6qjf
 0+U+vfElsNUK2JpPmBvZUAOC2R+wGCsGBeoJnLasQ3Nqi9hhRYNBkkRkzsDNBGSA2vUBDADn
 qUpvOm4/uxqoQpSff/SmYVvEaI/rCp6lxHhW2BL+5TT4o8F5s83eqj8Mwt82dYDye7ELq6XC
 aP1rXoWHViSTYZyW7IdvEfAVQHGp9CuSiPo3goLxZzVrZhnHI4V+pczP9BP/2PocBoX80Y28
 gwVsOYYD79QuSTtMDzCXpHyX7eooX166ps/JVABlw4vWmZ5AVfYS/FxLjRBX8rXHUxSL30fC
 +YEi82+zHm2AHA2PtegzZfh8uSXG8MS+ev7Dejx+0IhzuCjht83OITDSUGw8cNrv76L01O8N
 xAijtyLAbwJL5azzcsLlhCHaOTYqJ+XsD8fG/ctFLchRD0kFY7NXQGNgLslc/lEOoc5b+9V5
 BAhCN9VbQBMCuutIeR9MlH5C7FFkEEyHQ9UeyCLczPsUEolknpMGDXpfZDZxL8vYXiXOve3h
 Lgf66KqqVqg63kXZaEEcXD/jfJwSzz6VDl3Kd5clwONdlhgN4OJAKBN25jyNeRt7zI5VXEsj
 4IhSzqMAEQEAAcLA9gQYAQoAIBYhBDZ2rL1itH9whPfGy1403WO+46lLBQJkgNr1AhsMAAoJ
 EF403WO+46lLqXYMAJPJM8/L/XbGBf5S3peReqMPuTjwmdOrU5WSKRI6tq055F8Hf04IOSoH
 Al3KIP19Wz8oWkRvBPQ3y2lQTQWiX/irZ0EE9o3XyKbXNQi6YvclvZZAY+ZU+eDpmCjcuuV5
 CfS5O2AI40S+NRAkZYD0ec6iOGInUfFWAnvp7yBU6PkLucSo0ckCxN5guWeFXoaTF2ENEFWe
 gw3SJSQMZZsRQfNKJ+Lbg4MICTK8dDdKb+aecISOXmfNDT5UP5vFU0n7iD2EeLHB3GMCunu3
 +lg3u1Ig8zQGSqrU2ln0O2GF0yggDY+KAual2HlGiHcriqLaM/IXE3njvdantLYaMUTyD/as
 4+mygInmNpmPCx4ukxB2Ak7gAEWs3qkgQxmArdoAOh9PX9nOm6j78Nttcwkhcxrbvy6udvKH
 Exkss92WasR0o12O1NDtXMkrADnTCEX3oNhq2j23A97bQGI3ttOnSbJQGMa13D0KN2oAvPPw
 QkQDm7wWI9p7y/dzNpPNWICDtQ==
In-Reply-To: <917a9dc4-bcae-4a1d-b5b5-d086431e8650@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rzd0akhDYVQxUWxYdVlINGRXb01lK2dIc3h3QmhMQ0tndDJpUUpEMGQ0M2FC?=
 =?utf-8?B?R3JBQmRDeU8xR1pYbUhPQ2c4TklxaDFVaTRuclJBakpQaDgwRGFTOE5LaGUx?=
 =?utf-8?B?bkF3bFZvcDlab1g1cmt2WWpwZkFHTTVKeHdtRUExdUZJMWNDSkdFRGxYemdk?=
 =?utf-8?B?Nm9jMndVMEUxVlVpZGxPVmoxdmd3VVBWZlBlZUlyUm5oOWdUc3pERTlYVDlS?=
 =?utf-8?B?SXJXTVgyNEh6RHFYd3hscElVejRVcmZEa3dNMys2VldpSURCdjhNS0RLSVJp?=
 =?utf-8?B?RXN0aG1wSG5ybVpmb0J4Y0JLLzJKdGh4WURLNHJpR1Z2VEJFc2ZkYXJJek52?=
 =?utf-8?B?cWQxaUhULytRczQ5MEhaT1cvRjBtd3hvejFnYi93SVRhR1NBQmdXWXllZnRZ?=
 =?utf-8?B?N2wzcklWaWVNY1ZZa1l0cHpmcVlEakJRNXVzZ0hrRndSYm1pQWVUWUkvMUNB?=
 =?utf-8?B?aHR4elRuUVl2OHN1RnR4RmU0THRUQjRNcXM0dmlZK3FXaVhObmRaY09Hanh6?=
 =?utf-8?B?WWxoQlA5L0tmWXNGZGZ6L0xpVnRIVzZJSHZ5TjNsU2ozdTl3Z1pnTERwNC9H?=
 =?utf-8?B?ZzhsVkNEZnRqNHk0eS84S250VGVmVndEUkx1MHFkWWlmYzhTd2JYYm5BejA4?=
 =?utf-8?B?MFRWMHYySFA3V2lUQlFjVXNheHRnVTNZSjNFTmFRWkhyWlE1YkZhd3BjVTlQ?=
 =?utf-8?B?eWgzODROUGZvN3BXRVk5SWM5QTVsaUluZk1FRExiOGlXUWxKa2pJcnJmMWVj?=
 =?utf-8?B?WnZTYjY2ME52OXUrazd2YnRtZmxjSTIzV3ZvM1h2ZTZCbUx4TmgxYWV4d1pN?=
 =?utf-8?B?Q1QyQzlhRG9BYkFPUGF3WVpmRWsvajRUdkVlTDFKQVRaWHJldnJiU0NQekpn?=
 =?utf-8?B?bENKLzBLbUkzT2pFQW9hSm05dGR6ZWd1bmQ5YlBkdW1pNXlJNG1ySlBHb0NZ?=
 =?utf-8?B?OTY0bk9YNmxwa3MwSTFnRkNOTDh4aXlzei9iWW96OWhabEV6RkwyZGtCeHYy?=
 =?utf-8?B?UWt4TitEVkl3OWROKzFVVmovTWlxMFMySmpzM213WmdCMFIyWFZpYnZMRzBw?=
 =?utf-8?B?S2hvMmNoYmM1V21oajN6NVdPTTRUcUcxT2RnQlRDZGZReU9FVEJzOFk1ZDU3?=
 =?utf-8?B?N3Vra2hpY0J0WFl6Qk1mMGh0bTlYM2Jla0ZZejh4UmN0MFA2eEFRSForYkVl?=
 =?utf-8?B?OG55V3AxeFdoRUFKS1JDdjRtbTlEWTcvekRRVlpkWVZYQUhieW5RSElFNVYx?=
 =?utf-8?B?cXpGZVJsOUlaVUE3WnFYeklIN2VocGZ5bHlvYmRMRWljdXJtZkk5THBtcEVY?=
 =?utf-8?B?SVpveGdhTTBlYmM3c3VUUlRhZVFrczRlZk1FUEk5dUlmaTczOVJyeE1HSUNO?=
 =?utf-8?B?OWp0dXNnejhRUHJTeUJNZHJDQjJtS1lPZGxYTFc1MG5KeHd5eE5jZmkrZHQx?=
 =?utf-8?B?NmovemlBMnk5dW5raEVTbUp6VmE5QlBlQ29QTUtzU1NTQTh0MFRLQVhYRjUx?=
 =?utf-8?B?cG1INHhiNVVQMVpta0pSTXpJMlY4aEZEK20vMUFERkFPMnJvMXpmQjNiak5u?=
 =?utf-8?B?czF6UDBFQ2pVNG5TcUdaNjdzWEdFNGgxUGRkWnNNT0FPeU44Nmxac21aTGxw?=
 =?utf-8?B?dGlQVlFtZ2ZsZ0JWay9UMFRLSWNOZ2lwTlFpb0I1aXdPbWZwdFdOZGJaZjEz?=
 =?utf-8?B?QmxKcU94cWhkS1JCWXdxL3RqZFpIVEd3TnFXODY4Q2ZvUXFlUkUrSFVoS0xj?=
 =?utf-8?B?c1V1bWxkdDhQQ253L1B0SzFja3NSUXFtTnFFcEpQbGhJUmk2SEFEN01aUTBt?=
 =?utf-8?B?U0tnYU9IZlhPTGJoSWFMTEY2aUc0bWZ1c2JPM3pFSHhsZzRpa0JKbWxWZXhT?=
 =?utf-8?B?YXpCL2kreGtFUXpzZDJCaEF1U0wzckdtWDk3RndmK3RNbEMwK2hqRHQ1Rm5t?=
 =?utf-8?B?TDQ4d2ZFWWQvZkNMU2R4OWx5VjkwMms4TnhGM0dKVlphbmxMYldzRTlhNDVM?=
 =?utf-8?B?djQvcDVDQVBUMTQwSWo4bVR0Z0tDbzNTVzd1aU1qaHZCMEFWck50YmVweGhO?=
 =?utf-8?B?R1VCQjlWSDhCU1A2L24vazlKSmdBMFZGYzJqVzducFlnRUNsR0g3RUZqVlJv?=
 =?utf-8?B?VHV0K2h4d0lwemVYWkhCU2FYQlR5S21VVW8zdTl2R0o4ZlJmVWd0Z1I1UVFt?=
 =?utf-8?B?dFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d5ba02ae-dca0-4b68-87b6-08dbfbfd2b72
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB7164.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 17:01:37.8991
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z0Pz4txnR3q1XhfLjCXiJrrDCQci2jKdD3pDVF4dE8x8ZkskCMUPAZWfbFFdB7tBcUiws6NWu+ppnIFr/U8HoqzfztHLjHI0geAEtcNfCIM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8101
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 13 Dec 2023 09:01:58 -0800 (PST)

On 12/13/2023 1:30 AM, Yang, Weijiang wrote:
> 
> Let me involve Chang, the author of the code in question.
> 
> Hi, Chang,
> In commit 70c3f1671b0c ("x86/fpu/xstate: Prepare XSAVE feature table for 
> gaps in state component numbers"),
> you modified the loop as below:
>          for (i = 0; i < ARRAY_SIZE(xsave_cpuid_features); i++) {
> -               if (!boot_cpu_has(xsave_cpuid_features[i]))
> +               unsigned short cid = xsave_cpuid_features[i];
> +
> +               /* Careful: X86_FEATURE_FPU is 0! */
> +               if ((i != XFEATURE_FP && !cid) || !boot_cpu_has(cid))
>                          fpu_kernel_cfg.max_features &= ~BIT_ULL(i);
>          }
> 
> IMHO the change resulted functional change of the loop, i.e., before 
> that only it only clears the bits without CPUIDs,
> but after the change, the side-effect of the loop will clear the bits of 
> blank entries ( where xsave_cpuid_features[i] == 0 )
> since the loop hits (i != XFEATURE_FP && !cid), is it intended or 
> something else?

The code was considered as much *simpler* than the other [1]. Yes, it 
clears those not listed in the table but they were either non-existed or 
disabled at that moment.

Thanks,
Chang

[1] https://lore.kernel.org/lkml/87y2eha576.fsf@nanos.tec.linutronix.de/