Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <58d1f6a6-458d-44d1-8bcb-adb90aab50a5@amd.com>
Date:   Wed, 13 Dec 2023 12:04:04 -0500
User-Agent: Mozilla Thunderbird
Cc:     yazen.ghannam@amd.com, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org,
        avadhut.naik@amd.com, john.allen@amd.com, william.roche@oracle.com,
        muralidhara.mk@amd.com
Subject: Re: [PATCH v3 1/3] RAS: Introduce AMD Address Translation Library
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
References: <20231210194932.43992-1-yazen.ghannam@amd.com>
 <20231210194932.43992-2-yazen.ghannam@amd.com>
 <20231211195739.GIZXdps9DNvOgCR5Xs@fat_crate.local>
 <295f3cc9-6140-4813-b107-8c8b60f8aaa1@amd.com>
 <20231212153449.GEZXh9mSJ5epD13Dp7@fat_crate.local>
 <b9beb435-30e4-44a3-b27d-0567a8e873bd@amd.com>
 <20231213164837.GHZXngZW3TYvBN41Ma@fat_crate.local>
From:   Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20231213164837.GHZXngZW3TYvBN41Ma@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1RDYzREUy9ySXRUcU9uTlBxSUpwMHFnSVZJd2ZtcWZOR0Z1dko5QnZJZktk?=
 =?utf-8?B?WXVGV1B6bk5sUnZYSVpHLzFyUFpvZmlFcEhkZmJVdGRBVFlGdjY1OUhNN3lV?=
 =?utf-8?B?ekMreFEvakJXUWgyM2lZYWorN2JLSm9NQ3duUDNPZndKSFU3amppcUJDQnhL?=
 =?utf-8?B?UFlOODF2Y1JWU0gra3o3bXorVm0yWmN6eFZkVFd6UXpQV2JoSDJnRlRESjhu?=
 =?utf-8?B?UjlsVWsxdEdhdHUrWW9kMkJBdFpkQVZaVlFiOUhaOHMwRDIvUjNxT1ZHUkNW?=
 =?utf-8?B?M0o5SFNrdWV4eW1mMnA3bUVvUksxdU9IL2RuK2dIK2xjOWZGaVNPeFVVOWdU?=
 =?utf-8?B?czE3enZsdmR6K3NBamIrV2ZibHVkNFRTNW4yMlduZTZhcHRReS9STUNlMVlG?=
 =?utf-8?B?WnpGZkRFd2NrQ05heW5pTHQ4bExkQWx6WUsxSlJycVVLcTY0YSt0OGpaOUMx?=
 =?utf-8?B?YkVjbS81OHRDYU8zZVA1dEtDQUdoNDhPSFlES2xRaWN4cHgvdEVYVTVHclBq?=
 =?utf-8?B?QWJtN2JrTU1OYTBmbTVQYzBKa1NNdjlmN1YyQnREVVlWZDJqcUZuK1ZIcjdH?=
 =?utf-8?B?SG9yTjJjM3UwdlJ6YURDc2NCUEhXKzE1b3gwRGpQZjZxOC8yZllvcGlyNEJO?=
 =?utf-8?B?MnlqaktEUndlWHRSa1EyWlZSMm1KODkvWi9PM3hMei9Idk1WZnR2dy9GSDNO?=
 =?utf-8?B?ZSszNDR6eGl2WnJjWnAxZjZsWEQvMzNramhVTWF6OWN3ZUZWSXNrQXg4ak5F?=
 =?utf-8?B?MlBkY2dVTWx5RU4xTmkyZzc1SXBKZ2NnNVVrQ0JMWm1GZGNJMUJXN3JyYWFq?=
 =?utf-8?B?NGttMW15VDk2VitVOFlkR1o1VWY2VUFYTW5IeFl2NEVDanBjbTNuUVhOZVFp?=
 =?utf-8?B?WWdmbzZub0tLNmxMVFJCY1V6RGVBNGtDK1VZV3FJMTlZZCt3UEpUMjUxNkFi?=
 =?utf-8?B?N2JIQ3pIRk9yS1hQbkNZdHFyL1lIWXVGVmxpdWozb2J0NkE2cDFxSTdvcmR4?=
 =?utf-8?B?WDk0NFhNT2FiVDVHTFd3SnRsQnI5V1JscW0xNXMvZGVGQXVyKyttdTFNdHBZ?=
 =?utf-8?B?L1IzdlJ6YkxJOERBVWFCblVFZEJXZDJpakh2RS9UVFNwSEU2cXdjNWpwbGtF?=
 =?utf-8?B?OE4zL0I0NUZqTVBqemJhNnlRb2ZrakpSaU1EZHlBUFA4Z0FXT1RrRUpPK2Jr?=
 =?utf-8?B?OTVqNi9HTklqSmxDeEc3SXg0Vm9Wb3dUSG1jWS9SaittY0owdlpGT3hwOFQw?=
 =?utf-8?B?eDFraWhuNitadDFFT3JZT2V1SlFYZy84M00vUHFNcjdSMWw5dFcrb0s3QXgv?=
 =?utf-8?B?UEZWUktPUUUzdEE4UzRGV2E5eWVUMTFVZEtLNS9PTURvNnVUMU53MURhNGcr?=
 =?utf-8?B?TUxoc2lWSVdWSGFGSllWUUtDS1hCTGFYYSthZzIyQlBPK2s0WENQZU52QXJt?=
 =?utf-8?B?NEdtUFluMU5UVk9kVW1VbFpYc3RML1g5anRFZXUzcFY0c2pzbkhVb2xwWmdy?=
 =?utf-8?B?NG1CN0V5eDBhU3czUjNGOW1aa3BXV0JLZ29JQzYzQmZ4RlI0SnRNZWJBVU9F?=
 =?utf-8?B?WHpYZXlaeEg3ODhha1ZMc0RzYWhtYlAzQll1bVp2QWdxUDFEOHBBRXppTEpH?=
 =?utf-8?B?UWJQcVNLc1RPT1l1Z3pjWUljdk1hOWx4anlkYmZjcmZJWTBLcGpLU1VHU2NE?=
 =?utf-8?B?ZTN5RHhtQ1l3MEI0dnk0c0l4c2NUTnJPZ0JUd0IzTnBFTWM1ZzVhdUQ3cXpY?=
 =?utf-8?B?RkFtYWg0MjUzRzk1SEhBNFhRanJsUHdrK1owU0JGUHFEUUpvdERHcXU4QTJt?=
 =?utf-8?B?eUFvOTNSWnYwZHZ5NEdqd3orUnJBRW93OU1mcHBGQUkxNWxROFZyS0ZlU2hs?=
 =?utf-8?B?a05nT3hrRVBsS0VWSUgzSXVzd3hvSG5ZZzhXUysrTXRuTWNWbUNBdVh4VU0v?=
 =?utf-8?B?bXFycXZaN0FhdGQvTzk0UExPR04rR250L0M1NG9sLzhpajEyNVBRVEhsbWRw?=
 =?utf-8?B?bDZrQTY4QlRTdkJmRllJTW5KckJhWUFRTEtWNkRzQnhBL1IyQVdZUnFYRkFT?=
 =?utf-8?B?NGlQWlhUVWN1a0ZJbW5MREVwdTlLdyt5bkRxTmtOVVdHanF0VldGYitjME91?=
 =?utf-8?Q?LfBAHyIkm8cEeXhXPGq9rdrHz?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 77826518-ce2b-4e6a-f621-08dbfbfd845b
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 17:04:07.1033
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KR+5sMFow+UDKhVOaMGYNp01DpvDVs8PPry5iJa7yKiCqyuogusnQ3pyfNs7y3RhW6rUjmL+Ciip5w5FrJGs0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7369
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 13 Dec 2023 09:04:22 -0800 (PST)

On 12/13/2023 11:48 AM, Borislav Petkov wrote:
> On Wed, Dec 13, 2023 at 10:35:55AM -0500, Yazen Ghannam wrote:
>> I agree in principle. But I don't think it hurts to include an additional
>> line to avoid the confusion when the module doesn't load.
> 
> It does hurt because this turns into constant family updating the moment
> a new family appears. This is one of the major reasons why we do CPUID
> bits.
> 
>> Also, the SMCA feature is used here as a short-cut to match on systems with
>> a Data Fabric. We could use the Zen feature in the same way.
> 
> We could.
> 
> What is the main description of the environment an ATL library belongs
> into: a SMCA system or a Zen-based system?
> 

Systems with an AMD Data Fabric.

I wrote up this comment for the amd_atl_cpuids[].

/*
This library provides functionality for AMD-based systems with a Data 
Fabric. The set of systems with a Data Fabric is equivalent to the set 
of Zen-based systems and the set of systems with the Scalable MCA 
feature at this time. However, these are technically independent things.

It's possible to match on the PCI IDs of the Data Fabric devices, but 
this will be an ever-expanding list. Instead match on the SMCA and Zen 
features to cover all relevant systems.
  */

We could also introduce another software feature bit for Data Fabrics 
"DF". And this could be set when we discover them, like in the AMD_NB code.

Thoughts?

The library init has three checks for system support. Comments added here.

	// Load on systems with Data Fabrics (ZEN || SMCA).
	// Filters out legacy systems.
         if (!x86_match_cpu(amd_atl_cpuids))
                 return -ENODEV;

	// Make sure the kernel recognizes this system's Data Fabric.
	// Filters out new hardware.
         if (!amd_nb_num())
                 return -ENODEV;

...

	// Make sure the library supports this Data Fabric revision.
	// Filters out totally new logic that requires library updates.
         if (get_df_system_info())
                 return -ENODEV;

Thanks,
Yazen