Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Wed, 13 Dec 2023 19:28:59 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Nikita Shubin <nikita.shubin@maquefel.me>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Damien Le Moal <dlemoal@kernel.org>,
        Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>, linux-kernel@vger.kernel.org,
        Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v6 03/40] ARM: ep93xx: add regmap aux_dev
Message-ID: <ZXnp284IpfVEZX6A@smile.fi.intel.com>
References: <20231212-ep93xx-v6-0-c307b8ac9aa8@maquefel.me>
 <20231212-ep93xx-v6-3-c307b8ac9aa8@maquefel.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231212-ep93xx-v6-3-c307b8ac9aa8@maquefel.me>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Dec 12, 2023 at 11:20:20AM +0300, Nikita Shubin wrote:
> The following driver's should be instantiated by ep93xx syscon driver:
> 
> - reboot
> - pinctrl
> - clock
> 
> They all require access to DEVCFG register with a shared lock held, to
> avoid conflict writing to swlocked parts of DEVCFG.
> 
> Provide common resources such as base, regmap and spinlock via auxiliary
> bus framework.

...

>  struct platform_device;
> +struct regmap;

Perhaps more to add. See below.

...

> +enum ep93xx_soc_model {
> +	EP93XX_9301_SOC,
> +	EP93XX_9307_SOC,
> +	EP93XX_9312_SOC

It doesn't look like a termination, so leave trailing comma.

> +};

...

> +#include <linux/spinlock.h>

I don't see a user for this. Am I missing something?

-- 
With Best Regards,
Andy Shevchenko