Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5485123rdb; Wed, 13 Dec 2023 09:54:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IFAXKymiNA5BmONG4cAMK5ZrsFn9DgClVd87eeOCLOtwshOBeMogqEhzYJ7FpkhhGYOvF6o X-Received: by 2002:a05:6a00:178e:b0:6cb:4361:773c with SMTP id s14-20020a056a00178e00b006cb4361773cmr10163175pfg.5.1702490088356; Wed, 13 Dec 2023 09:54:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702490088; cv=none; d=google.com; s=arc-20160816; b=gG10sSp7qq2lcI3qFEUNZvV1jEOe06AAS32r1EYPfC4AtXTtUrHyp+CTP0S9kSqykG 0r9j2s6SrfJ+yMcahjgNzaNxJmJBjiJpaDzhNyaxk32qzAo24jkpp+CeLO2ZZz661EC8 JS/vh7J4Bt/DaYwyEKRydusBtlZXCTYFhhNu7PEZ1itjPDpfNs4v4BtrANSKnl3mWYsf yAP57IxyHtcukZkdeDqlDC3fNSpDwBM46mr+utEHR8fQbj7zOvew/UIre4ga3CChh3M9 9+3XmIePVpvkHjqnOHIxJRRdxirqz63ZRqqhu/aKca1KUiAqhgE4TFurhuc5ACoICNsk /EHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :feedback-id:dkim-signature:dkim-signature; bh=GFUxrXC+6NmQeYvpOTRSuHLgXL/L+nTvW94IaYCc+BQ=; fh=N6kOWzzoyFx46KhufQEFsHexRnrKpkm1lLeFNNXuCFg=; b=lTX/HsPvmDQZ53RKmCLUDIYqR/p9E8PBRGb1CprjWiRwqPTH7Ca+aWT29LfDfiC5wH 0lzn1G8TYNvMb2BKdmkUGICEcXzIsKvKWTA3vG61OFq9V4YoRIxP5GnKMObpm5OUTKCV XKBJSG2RXsAEVVSZgQC4NXe5WAK6t3dYcCOgNcXCgFSNbHpCpnsPbGjWTABuPcB+a7oC 0zBA8Fhgg3MWeA0jN/1Sm5GS1BYAzcndmRA1mvRqJd7ZL64CNv/zwvOsTqJCnuDFBpBq mkAtLI/d15HeL37UfY4QWFMVGZDzHX3ZxxB2wh1IBNZL/obiKdzby16VoHqiUXiv8CqP CtQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fastmail.org header.s=fm1 header.b=bKfYWj0z; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=TcjqPn1j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fastmail.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id ct17-20020a056a000f9100b006ce4d21cc8fsi10005434pfb.206.2023.12.13.09.54.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 09:54:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@fastmail.org header.s=fm1 header.b=bKfYWj0z; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=TcjqPn1j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fastmail.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 59D0D802F336; Wed, 13 Dec 2023 09:54:47 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233551AbjLMRyf (ORCPT + 99 others); Wed, 13 Dec 2023 12:54:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233676AbjLMRyU (ORCPT ); Wed, 13 Dec 2023 12:54:20 -0500 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3F2183 for ; Wed, 13 Dec 2023 09:54:26 -0800 (PST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 1D11E5C0304; Wed, 13 Dec 2023 12:54:26 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 13 Dec 2023 12:54:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1702490066; x= 1702576466; bh=GFUxrXC+6NmQeYvpOTRSuHLgXL/L+nTvW94IaYCc+BQ=; b=b KfYWj0zvATh5K7AenSccp4wpYBUkEKbTdlvAZHaWg2vpD+NB9ET3ny/k5dHj8bIM +OP7CxrCLc7AHFU04Y6CZ+f7EcL82KOJkQNisrGyoPOvPymO7+fZRAab2behmGjr MpZXS8FUsCDS4TfB5rbp2hbxJ9EpyzdDf4KsXk2mwowXw0fZUZAVu4QCzgHiG0dW cUUtOyK1+9GTDt0TAiIIHNurRbjpWaDH5lf+oR1kphwiNMBYyVhNRi8fJMJprqd+ mP53qnOuZ6H1tWpJ6BH2hUf4LlbO8/2cUYVt6NJJiMM+uFV62NRs/Qri70uqydDz Za2wYp+t4kC60112N4jBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1702490066; x= 1702576466; bh=GFUxrXC+6NmQeYvpOTRSuHLgXL/L+nTvW94IaYCc+BQ=; b=T cjqPn1jVJlYnWikHgl6xtHMAccUAYOe+I5S8qlv9vOfkCQveyucDgQ5zaFMs3Cx+ lQ8xxrI43zx3hlAkqYPOM6JuDWeDhNtr3acIczkbIjaQ1OqvXRbRMyFn2OQmcnUQ lCa778WOcc4XXl6FRt15SFGeRa4qCdgw52CNQEdxBTT2XJYXduvyWh90qLx3c1rd Rjz9BSS1azU8hB9PNv7dR62WBPwGOhM7p/SOtoBFE0u2rLYWTe8EZS7ailkXQTxM Z5d29AamCMpSjRWdVkgi0GSAAw4PPD5BqJBb9XRTe4wygBAEN/dZJTnvWf2/v7p9 Ih/63Zs5fbv0qVo+g3LWA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeljedggeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 13 Dec 2023 12:54:25 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH 1/5] staging: rtl8192e: rename variable HTGetHighestMCSRate Date: Wed, 13 Dec 2023 12:54:55 -0500 Message-ID: <20231213175459.5425-2-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231213175459.5425-1-garyrookard@fastmail.org> References: <20231213175459.5425-1-garyrookard@fastmail.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 13 Dec 2023 09:54:47 -0800 (PST) Coding style issue, checkpatch Avoid CamelCase, rename it. HTGetHighestMCSRate -> ht_get_highest_mcs_rate Signed-off-by: Gary Rookard --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_wx.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index 25097f1935a5..06542ac851fc 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -377,7 +377,7 @@ static u8 ht_pick_mcs_rate(struct rtllib_device *ieee, u8 *pOperateMCS) return true; } -u8 HTGetHighestMCSRate(struct rtllib_device *ieee, u8 *pMCSRateSet, +u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *pMCSRateSet, u8 *pMCSFilter) { u8 i, j; @@ -545,7 +545,7 @@ void HTOnAssocRsp(struct rtllib_device *ieee) pMcsFilter = MCS_FILTER_1SS; else pMcsFilter = MCS_FILTER_ALL; - ieee->HTHighestOperaRate = HTGetHighestMCSRate(ieee, + ieee->HTHighestOperaRate = ht_get_highest_mcs_rate(ieee, ieee->dot11ht_oper_rate_set, pMcsFilter); ieee->HTCurrentOperaRate = ieee->HTHighestOperaRate; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 0d6144548c34..eef7c2b8c660 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1767,7 +1767,7 @@ void HTResetSelfAndSavePeerSetting(struct rtllib_device *ieee, struct rtllib_network *pNetwork); void HT_update_self_and_peer_setting(struct rtllib_device *ieee, struct rtllib_network *pNetwork); -u8 HTGetHighestMCSRate(struct rtllib_device *ieee, u8 *pMCSRateSet, +u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *pMCSRateSet, u8 *pMCSFilter); extern u8 MCS_FILTER_ALL[]; extern u16 MCS_DATA_RATE[2][2][77]; diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c index a37250de7ba3..f92ec0faf4d5 100644 --- a/drivers/staging/rtl8192e/rtllib_wx.c +++ b/drivers/staging/rtl8192e/rtllib_wx.c @@ -134,7 +134,7 @@ static inline char *rtl819x_translate_scan(struct rtllib_device *ieee, ((ht_cap->ShortGI40Mhz) ? 1 : 0) : ((ht_cap->ShortGI20Mhz) ? 1 : 0); - max_mcs = HTGetHighestMCSRate(ieee, ht_cap->MCS, + max_mcs = ht_get_highest_mcs_rate(ieee, ht_cap->MCS, MCS_FILTER_ALL); rate = MCS_DATA_RATE[is40M][isShortGI][max_mcs & 0x7f]; if (rate > max_rate) -- 2.41.0