Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Wed, 13 Dec 2023 19:54:59 +0200
From:   Andy Shevchenko <andriy.shevchenko@intel.com>
To:     Nikita Shubin <nikita.shubin@maquefel.me>
Cc:     Sebastian Reichel <sre@kernel.org>, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v6 06/40] power: reset: Add a driver for the ep93xx reset
Message-ID: <ZXnv8zwHYHS7co2G@smile.fi.intel.com>
References: <20231212-ep93xx-v6-0-c307b8ac9aa8@maquefel.me>
 <20231212-ep93xx-v6-6-c307b8ac9aa8@maquefel.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231212-ep93xx-v6-6-c307b8ac9aa8@maquefel.me>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Dec 12, 2023 at 11:20:23AM +0300, Nikita Shubin wrote:
> Implement the reset behaviour of the various EP93xx SoCS
> in drivers/power/reset.
> 
> It used to be located in arch/arm/mach-ep93xx.

...

> +#include <linux/bits.h>

+ container_of.h

> +#include <linux/delay.h>

+ errno.h

> +#include <linux/mfd/syscon.h>
> +#include <linux/notifier.h>

> +#include <linux/platform_device.h>

Should this be the auxiliary one?

> +#include <linux/reboot.h>

+ device.h or slab.h where devm_kzalloc() is defined.
Depends on above dev_printk.h (it's guaranteed by device.h).

> +static const struct auxiliary_device_id ep93xx_reboot_ids[] = {
> +	{
> +		.name = "soc_ep93xx.reset-ep93xx",
> +	},
> +	{ /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(auxiliary, ep93xx_reboot_ids);

module.h
mod_devicetable.h

...

> +static struct auxiliary_driver ep93xx_reboot_driver = {
> +	.probe		= ep93xx_reboot_probe,
> +	.id_table	= ep93xx_reboot_ids,
> +};
> +module_auxiliary_driver(ep93xx_reboot_driver);

Not seeing the platform_device.h use...

-- 
With Best Regards,
Andy Shevchenko