Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5490840rdb; Wed, 13 Dec 2023 10:03:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IF7BvrhbS+8BGWMsjy6Sh6IHjfJIt9QfYYcDuh1J9UgOwQiX3semc9suE3y87XkPLKyGiRV X-Received: by 2002:a17:902:6846:b0:1d3:5d80:c9f7 with SMTP id f6-20020a170902684600b001d35d80c9f7mr501655pln.19.1702490625340; Wed, 13 Dec 2023 10:03:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702490625; cv=none; d=google.com; s=arc-20160816; b=yUkYhMEzjc/qzcg4OuIq5tUUlF8f/oz0tzPsAekHkADdPNR3Djdp3hsp7AreBnIVQi dOuJ+/ah9LXekLkwmbzMqrfgbo009myXpKRXAXErizvbT+XSiAEA/xfvedYgeaBoUUBM 6/kSC565+LbBGSw+GYKjW1pQQmHExFo5TldO7VedE5GrmfeV4T8Rz5eiAWVWULS77jn2 zfbxyZG8LWXoRuBJgtYKi7Xm5Jiwy+QA5zz/NOJO0H0oMOSqXKEJiDc4sZW5WgCZKwyX sI64ikfU2I/6/zbujavW3nsuG24O/oa+bthk5P1ICeAgxnr3zIbiK9EuyNI8BBTjGjFE x9Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=lII1VLpZch/lvc8yafo0aPr1YV2qUbvcEazS/kUALKo=; fh=HBNJCb1O5m4cQgWGcwqoKY3KTbKsr5rANYvH6uVWzvA=; b=v931gXdLKoThFoDMeqxrXmNVSBxsAdp7Xlt98ikLctqbV9BYUL+i45h/qRnmnz6UJ9 wL2g6d1l6XXzjnk2sobDRFrtiocwQ2bf/daD4KYTP5Pptl5dcnZI+DqRfBIgJhDMwPZ5 N+deHUNtKJT3AZT7K9Bq6x4ylO/XmJu+/2Lk8m3yLTnA174ldIGCZ7DaUjagD1wh3SRq vmk0Hvf0wbXTxH5UHcRySjDU2WaAmxmoXEFyhmDRW+BM9LvalgS2I9QPhf/AQV2kHsWL o3VlhlNaQ7xZc+Bcex2Cp0cV+kEX9RggQ3NYk1qF18skBs8qlgCnauUqFxNFcFp8Mkxk bo3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id k7-20020a63d847000000b005bd70a177a3si9483657pgj.876.2023.12.13.10.03.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 10:03:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id A596281BB1A1; Wed, 13 Dec 2023 10:03:34 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378704AbjLMSDT (ORCPT + 99 others); Wed, 13 Dec 2023 13:03:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233600AbjLMSDS (ORCPT ); Wed, 13 Dec 2023 13:03:18 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 36C9BDC for ; Wed, 13 Dec 2023 10:03:25 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BDAE7C15; Wed, 13 Dec 2023 10:04:10 -0800 (PST) Received: from [10.1.197.60] (eglon.cambridge.arm.com [10.1.197.60]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 974B93F762; Wed, 13 Dec 2023 10:03:21 -0800 (PST) Message-ID: <539bf63b-6d10-96cf-8a4b-7569474b2ae7@arm.com> Date: Wed, 13 Dec 2023 18:03:14 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v7 02/24] x86/resctrl: kfree() rmid_ptrs from rdtgroup_exit() Content-Language: en-GB To: babu.moger@amd.com, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Fenghua Yu , Reinette Chatre , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com References: <20231025180345.28061-1-james.morse@arm.com> <20231025180345.28061-3-james.morse@arm.com> <5fe8fc52-c1fd-4977-be92-901752ce8ec2@amd.com> From: James Morse In-Reply-To: <5fe8fc52-c1fd-4977-be92-901752ce8ec2@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.5 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 13 Dec 2023 10:03:34 -0800 (PST) Hi Babu, On 09/11/2023 20:28, Moger, Babu wrote: > On 10/25/23 13:03, James Morse wrote: >> rmid_ptrs[] is allocated from dom_data_init() but never free()d. >> >> While the exit text ends up in the linker script's DISCARD section, >> the direction of travel is for resctrl to be/have loadable modules. >> >> Add resctrl_exit_mon_l3_config() to cleanup any memory allocated >> by rdt_get_mon_l3_config(). >> >> There is no reason to backport this to a stable kernel. >> >> Signed-off-by: James Morse > Reviewed-by: Babu Moger Thanks! James