Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5491336rdb; Wed, 13 Dec 2023 10:04:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IHz8sNGPbmAmL2kGuKdTiZ/+rUy2Q4oWJQqMADtyFcHWxwdmgqHtBdSMsW1MrQawvUa7N+d X-Received: by 2002:a17:902:784a:b0:1d3:495d:cd30 with SMTP id e10-20020a170902784a00b001d3495dcd30mr1137462pln.114.1702490660863; Wed, 13 Dec 2023 10:04:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702490660; cv=none; d=google.com; s=arc-20160816; b=FoGM00iT2PFImZ2Vz5goDQr4GoBjbS/1p0Ywuhw3rNuqclcB0/Q5/pH2cESdcMDEI+ 30ggHP49OPtNhM9RXsUQH+g7FpFT3PRW/GQJS6W6guHSJOwDdL/99ri5RIaI3eQ8YFY+ 1S57JJJP6Wqe5krYhfrp5KVPUWPi8erfX7Mexcf3ILySVVwGxm2STXKwRWiq1YEUeeCu REA5jeogFogYQS8DwBNFbH+6059RxFx4E3OPZsGa3eIIaDTNRfB7mq7AsnSnu38fUdCB CecY+gRLQbViIefcqFBG85OOuESuRbEHX+KfecDa7A62WYxhr11eOHHAwMnpWRBuENY0 QWRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=NXarnu3pmnxEMbl8p8+ayHJGBrI80l2/rLKZxfR2iMk=; fh=V3EXrfhtPXQ8VZs+995Yo8T+zOpBnshrD4ANVkhZrjM=; b=l8k/93nVX4lFvkp/Ayfz+E/psl5B3NMeqH0eS8u2d6M17DL5sS6aWfm9QS2qx+X7k3 pPHTpUeNF0O2iEzjeYWBL/gH5z5n/Kzo1Z+JvIJrL1gvfoqS+aJUaMkdZQ54DxAhjAob bdBQ+Ydytu6/z0IAvHjR2UaliGbdEi8c7h1Q1nDjYDIDGfiq42juk2MU6tgevRHgHqdw prybw+YNdWz3UjtEBkmsc/1GvYymJ9TfDCPsUfXrBTdoEr9B9xi51tGeH/Yp7kfOOW+o jXksdFQO/YtzYZUA1AvsiBtboVe7eqF/LKCj/khJitKvqCRYFBBPzC32aYM6kaXh5Tz+ asow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id o66-20020a634145000000b005c1eadbacb3si9679482pga.104.2023.12.13.10.04.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 10:04:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 4F32B804C6FD; Wed, 13 Dec 2023 10:04:14 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378704AbjLMSEA (ORCPT + 99 others); Wed, 13 Dec 2023 13:04:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235513AbjLMSDz (ORCPT ); Wed, 13 Dec 2023 13:03:55 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 37D5EE8 for ; Wed, 13 Dec 2023 10:04:01 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A9A0AC15; Wed, 13 Dec 2023 10:04:46 -0800 (PST) Received: from [10.1.197.60] (eglon.cambridge.arm.com [10.1.197.60]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 78D313F762; Wed, 13 Dec 2023 10:03:58 -0800 (PST) Message-ID: <79cdd108-d522-b1e0-6623-9c0e43534afc@arm.com> Date: Wed, 13 Dec 2023 18:03:52 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v7 05/24] x86/resctrl: Track the closid with the rmid Content-Language: en-GB To: Reinette Chatre , x86@kernel.org, linux-kernel@vger.kernel.org Cc: Fenghua Yu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , Babu Moger , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com References: <20231025180345.28061-1-james.morse@arm.com> <20231025180345.28061-6-james.morse@arm.com> From: James Morse In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.5 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 13 Dec 2023 10:04:14 -0800 (PST) Hi Reinette, On 09/11/2023 17:41, Reinette Chatre wrote: > On 10/25/2023 11:03 AM, James Morse wrote: >> @@ -732,10 +752,10 @@ static int dom_data_init(struct rdt_resource *r) >> } >> >> /* >> - * RMID 0 is special and is always allocated. It's used for all >> - * tasks that are not monitored. >> - */ >> - entry = __rmid_entry(0); >> + * These are used for rdtgroup_default control group, which will be >> + * setup later in rdtgroup_init(). > > This sentence I provided was intended to just replace two sentences, not the > entire paragraph you had. Note that I explicitly stated "change last two > sentences". Without the original text the above "These" is not clear. > If you just want to copy&paste here is the entire intended comment: > > RESCTRL_RESERVED_CLOSID and RESCTRL_RESERVED_RMID are special and > are always allocated. These are used for the rdtgroup_default > control group, which will be setup later in rdtgroup_init(). Thanks! I probably got muddled with whether this was against the existing code or not. James