Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Wed, 13 Dec 2023 20:13:13 +0200
From:   Andy Shevchenko <andriy.shevchenko@intel.com>
To:     Nikita Shubin <nikita.shubin@maquefel.me>
Cc:     Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v6 16/40] spi: ep93xx: add DT support for Cirrus EP93xx
Message-ID: <ZXn0OTsoHcVTly3g@smile.fi.intel.com>
References: <20231212-ep93xx-v6-0-c307b8ac9aa8@maquefel.me>
 <20231212-ep93xx-v6-16-c307b8ac9aa8@maquefel.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231212-ep93xx-v6-16-c307b8ac9aa8@maquefel.me>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Dec 12, 2023 at 11:20:33AM +0300, Nikita Shubin wrote:
> - add OF ID match table
> - add device tree DMA request, so we can probe defer, in case DMA is not
>   ready yet
> - drop DMA platform code

...

> +	espi->dma_rx = dma_request_chan(dev, "rx");
> +	if (IS_ERR(espi->dma_rx)) {
> +		ret = PTR_ERR(espi->dma_rx);
> +		dev_err_probe(dev, ret, "rx DMA setup failed");

		ret = dev_err_probe(...);

>  		goto fail_free_page;
>  	}

...

> +	espi->dma_tx = dma_request_chan(dev, "tx");
> +	if (IS_ERR(espi->dma_tx)) {
> +		ret = PTR_ERR(espi->dma_tx);
> +		dev_err_probe(dev, ret, "tx DMA setup failed");

Ditto.

>  		goto fail_release_rx;
>  	}

...

Otherwise LGTM.

-- 
With Best Regards,
Andy Shevchenko