Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Wed, 13 Dec 2023 19:33:49 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Nikita Shubin <nikita.shubin@maquefel.me>,
        Hartley Sweeten <hsweeten@visionengravers.com>,
        Alexander Sverdlin <alexander.sverdlin@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Sergey Shtylyov <s.shtylyov@omp.ru>,
        Damien Le Moal <dlemoal@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-ide@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v6 36/40] ata: pata_ep93xx: remove legacy pinctrl use
Message-ID: <20231213183349.hdjoxxszrrc4hqrg@pengutronix.de>
References: <20231212-ep93xx-v6-0-c307b8ac9aa8@maquefel.me>
 <20231212-ep93xx-v6-36-c307b8ac9aa8@maquefel.me>
 <ZXn0-pHxIztvRFLK@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="hwsnzd5s6bhsmoqq"
Content-Disposition: inline
In-Reply-To: <ZXn0-pHxIztvRFLK@smile.fi.intel.com>
Precedence: bulk


--hwsnzd5s6bhsmoqq
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 13, 2023 at 08:16:26PM +0200, Andy Shevchenko wrote:
> On Tue, Dec 12, 2023 at 11:20:53AM +0300, Nikita Shubin wrote:
> > Drop legacy acquire/release since we are using pinctrl for this now.
>=20
> ...
>=20
> > -	if (IS_ERR(drv_data->dma_rx_channel)) {
> > +	if (PTR_ERR_OR_ZERO(drv_data->dma_rx_channel)) {
>=20
> This seems incorrect.
>=20
> >  		ret =3D PTR_ERR(drv_data->dma_rx_channel);
> >  		return dev_err_probe(dev, ret, "rx DMA setup failed");
>=20
> 		return dev_err_probe(...);
>=20
> >  	}
>=20
> I think you wanted
>=20
> 	ret =3D PTR_ERR_OR_ZERO(drv_data->dma_rx_channel);
> 	if (ret)
> 		return dev_err_probe(dev, ret, "rx DMA setup failed");

How is that different from

	if (IS_ERR(drv_data->dma_rx_channel))
		return dev_err_probe(dev, PTR_ERR(drv_data->dma_rx_channel), "....");

(which seems to be more idiomatic to me)? While I was involved in
creating PTR_ERR_OR_ZERO, I don't particularily like it (today).

Also note that you want a \n at the end of error messages.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--hwsnzd5s6bhsmoqq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmV5+QwACgkQj4D7WH0S
/k7P7wgAsKHiIZEGiHCPIsRxffuVGHyfChdfi9FNHXa6YOcrVkAqOlbOe3uq+ab2
Ox0facnFCB5/BnVywxpivfme8J3KYfKvzG2KLLTzsVkCmIPA3L6ulgoSihKp/eWZ
yWM+XYHag7xo2f4bGCOYPs68QOtZDDdOiQKo+ATvzAqhIhpjBd/5Ie3U3VNcrKT4
TIajgdpwXYNaPZDUKy8JwQ8uVVUqQebW02xgNV1VhreG6/ywbX5mvWlnQLp5D/6c
3aJXEJTwe9IcRo5W4mC8xQltsrrtiuRWW3Q/wPS1qsmqIS8Dmn3mmcBoKq7iGxmM
1RZZFHo+yr0rRsB3Re0Q/E4Do2LnCQ==
=BQyO
-----END PGP SIGNATURE-----

--hwsnzd5s6bhsmoqq--