Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Wed, 13 Dec 2023 12:40:11 -0600
From:   Rob Herring <robh@kernel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Abel Vesa <abel.vesa@linaro.org>, Iskren Chernev <me@iskren.info>,
        Shawn Guo <shawn.guo@linaro.org>,
        Rajendra Nayak <quic_rjendra@quicinc.com>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        devicetree@vger.kernel.org, Danila Tikhonov <danila@jiaxyga.com>,
        linux-gpio@vger.kernel.org,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rohit Agarwal <quic_rohiagar@quicinc.com>,
        Vinod Koul <vkoul@kernel.org>, linux-kernel@vger.kernel.org,
        Richard Acayan <mailingradian@gmail.com>,
        Melody Olvera <quic_molvera@quicinc.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Martin Botka <martin.botka@somainline.org>,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        krishna Lanka <quic_vamslank@quicinc.com>,
        Stephan Gerhold <stephan@gerhold.net>,
        Andy Gross <agross@kernel.org>,
        Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH 01/10] dt-bindings: pinctrl: qcom: create common LPASS
 LPI schema
Message-ID: <170249281039.1698604.14736933847927766425.robh@kernel.org>
References: <20231208215534.195854-1-krzysztof.kozlowski@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231208215534.195854-1-krzysztof.kozlowski@linaro.org>
Precedence: bulk


On Fri, 08 Dec 2023 22:55:25 +0100, Krzysztof Kozlowski wrote:
> Just like regular TLMM pin controllers in Qualcomm SoCs, the Low Power
> Audio SubSystem (LPASS) Low Power Island (LPI) TLMM blocks share a lot
> of properties, so common part can be moved to separate schema to reduce
> code duplication and make reviewing easier.
> 
> Except the move of common part, this introduces effective changes:
> 1. To all LPASS LPI bindings: Reference pinmux-node.yaml in each pin
>    muxing and configuration node, to bring definition of "function" and
>    "pins" properties.
> 
> 2. qcom,sc7280-lpass-lpi-pinctrl: Reference pinctrl.yaml in top leve.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../pinctrl/qcom,lpass-lpi-common.yaml        | 75 +++++++++++++++++++
>  .../qcom,sc7280-lpass-lpi-pinctrl.yaml        | 49 ++----------
>  .../qcom,sc8280xp-lpass-lpi-pinctrl.yaml      | 49 +-----------
>  .../qcom,sm6115-lpass-lpi-pinctrl.yaml        | 48 +-----------
>  .../qcom,sm8250-lpass-lpi-pinctrl.yaml        | 49 +-----------
>  .../qcom,sm8350-lpass-lpi-pinctrl.yaml        | 49 +-----------
>  .../qcom,sm8450-lpass-lpi-pinctrl.yaml        | 49 +-----------
>  .../qcom,sm8550-lpass-lpi-pinctrl.yaml        | 49 +-----------
>  .../qcom,sm8650-lpass-lpi-pinctrl.yaml        | 49 +-----------
>  9 files changed, 109 insertions(+), 357 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-common.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>