Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Wed, 13 Dec 2023 20:47:26 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Lee Jones <lee@kernel.org>
Cc:     linux-kernel@vger.kernel.org,
        Alex Vinarskis <alex.vinarskis@gmail.com>
Subject: Re: [PATCH v1 1/1] mfd: intel-lpss: Fix the fractional clock divider
 flags
Message-ID: <ZXn8PixKBaxRUIZm@smile.fi.intel.com>
References: <20231211111441.3910083-1-andriy.shevchenko@linux.intel.com>
 <20231213161352.GQ111411@google.com>
 <ZXnZDjnor8oQNo2g@smile.fi.intel.com>
 <20231213161854.GR111411@google.com>
 <ZXnbGbjm-i7n4qU3@smile.fi.intel.com>
 <20231213174605.GS111411@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231213174605.GS111411@google.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Dec 13, 2023 at 05:46:05PM +0000, Lee Jones wrote:
> On Wed, 13 Dec 2023, Andy Shevchenko wrote:
> > On Wed, Dec 13, 2023 at 04:18:54PM +0000, Lee Jones wrote:
> > > On Wed, 13 Dec 2023, Andy Shevchenko wrote:
> > > > On Wed, Dec 13, 2023 at 04:13:52PM +0000, Lee Jones wrote:
> > > > > On Mon, 11 Dec 2023, Andy Shevchenko wrote:

...

> > > > > >  	tmp = clk_register_fractional_divider(NULL, name, __clk_get_name(tmp),
> > > > > > +					      0, lpss->priv, 1, 15, 16, 15,
> > > > > >  					      CLK_FRAC_DIVIDER_POWER_OF_TWO_PS,
> > > > > > -					      lpss->priv, 1, 15, 16, 15, 0,
> > > > > >  					      NULL);
> > > > > 
> > > > > What an ugly interface.  Intel-only too, right?
> > > > 
> > > > Nope, de facto way how custom clocks are being introduced.
> > > > See clk-provider.h for several similar APIs (that require an
> > > > additional, custom, flags to be supplied).
> > > 
> > > This call only has 2 call-sites, both Intel.
> > 
> > Yes, but the clock fractional divider is used wider.
> > 
> > And again, it's not related to Intel, as this how clock framework
> > does the custom clocks. I don't know how to say this clearer.
> 
> I'm not sure how you can say that.  Intel were the authors, hold the
> _only_ copyright and are the _only_ users.  If it were to be removed,
> there is only a single entity that would even notice.

_This_ API is indeed used by only Intel code right now, but the _design_
of the API is dictated by CCF, and not anyhow related to Intel.

> Anyway, it was just a passing comment.  Not positive, not negative.

Okay!

-- 
With Best Regards,
Andy Shevchenko