Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754812AbXLFHTi (ORCPT ); Thu, 6 Dec 2007 02:19:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753040AbXLFHTa (ORCPT ); Thu, 6 Dec 2007 02:19:30 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:47654 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752329AbXLFHT3 (ORCPT ); Thu, 6 Dec 2007 02:19:29 -0500 Date: Wed, 5 Dec 2007 23:19:04 -0800 From: Andrew Morton To: Kamalesh Babulal Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux390@de.ibm.com, Andy Whitcroft , Balbir Singh Subject: Re: 2.6.24-rc4-mm1 Kernel build fails on S390x Message-Id: <20071205231904.3dc4d130.akpm@linux-foundation.org> In-Reply-To: <47576959.4040706@linux.vnet.ibm.com> References: <20071204211701.994dfce6.akpm@linux-foundation.org> <47576959.4040706@linux.vnet.ibm.com> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2341 Lines: 56 On Thu, 06 Dec 2007 08:45:37 +0530 Kamalesh Babulal wrote: > Hi Andrew, > > The 2.6.24-rc4-mm1 kernel build fails on s390x, > > CC arch/s390/kernel/traps.o > In file included from include/asm/thread_info.h:39, > from include/linux/thread_info.h:21, > from include/linux/preempt.h:9, > from include/linux/spinlock.h:49, > from include/linux/seqlock.h:29, > from include/linux/time.h:8, > from include/linux/timex.h:57, > from include/linux/sched.h:53, > from arch/s390/kernel/traps.c:17: > include/asm/processor.h:191: warning: "struct seq_file" declared inside parameter list > include/asm/processor.h:191: warning: its scope is only this definition or declaration, which is probably not what you want > arch/s390/kernel/traps.c: In function `task_show_regs': > arch/s390/kernel/traps.c:226: error: implicit declaration of function `seq_printf' > make[1]: *** [arch/s390/kernel/traps.o] Error 1 > make: *** [arch/s390/kernel] Error 2 thanks. --- a/arch/s390/kernel/traps.c~proc-seqfile-convert-proc_pid_status-to-properly-handle-pid-namespaces-fix-2 +++ a/arch/s390/kernel/traps.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include #include diff -puN include/asm-s390/processor.h~proc-seqfile-convert-proc_pid_status-to-properly-handle-pid-namespaces-fix-2 include/asm-s390/processor.h --- a/include/asm-s390/processor.h~proc-seqfile-convert-proc_pid_status-to-properly-handle-pid-namespaces-fix-2 +++ a/include/asm-s390/processor.h @@ -165,6 +165,7 @@ struct stack_frame { /* Forward declaration, a strange C thing */ struct task_struct; struct mm_struct; +struct seq_file; /* Free all resources held by a thread. */ extern void release_thread(struct task_struct *); _ Unfortunately the current greg-versus-git-s390 snafu means that I'm not cross-building s390. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/