Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <66abc945-e539-4152-9044-2931934fb0fc@gmail.com>
Date:   Wed, 13 Dec 2023 20:22:45 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/5] staging: rtl8192e: rename variable
 HTGetHighestMCSRate
To:     Gary Rookard <garyrookard@fastmail.org>, gregkh@linuxfoundation.org
Cc:     linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20231213175459.5425-1-garyrookard@fastmail.org>
 <20231213175459.5425-2-garyrookard@fastmail.org>
Content-Language: en-US
From:   Philipp Hortmann <philipp.g.hortmann@gmail.com>
In-Reply-To: <20231213175459.5425-2-garyrookard@fastmail.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/13/23 18:54, Gary Rookard wrote:
> oding style issue, checkpatch Avoid CamelCase,
> rename it. HTGetHighestMCSRate -> ht_get_highest_mcs_rate
> 
> Signed-off-by: Gary Rookard<garyrookard@fastmail.org>
> ---
>   drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
>   drivers/staging/rtl8192e/rtllib.h         | 2 +-
>   drivers/staging/rtl8192e/rtllib_wx.c      | 2 +-
>   3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> index 25097f1935a5..06542ac851fc 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> @@ -377,7 +377,7 @@ static u8 ht_pick_mcs_rate(struct rtllib_device *ieee, u8 *pOperateMCS)
>   	return true;
>   }
>   
> -u8 HTGetHighestMCSRate(struct rtllib_device *ieee, u8 *pMCSRateSet,
> +u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *pMCSRateSet,
>   		       u8 *pMCSFilter)
>   {
>   	u8		i, j;
> @@ -545,7 +545,7 @@ void HTOnAssocRsp(struct rtllib_device *ieee)
>   		pMcsFilter = MCS_FILTER_1SS;
>   	else
>   		pMcsFilter = MCS_FILTER_ALL;


kernel@matrix-ESPRIMO-P710:~/Documents/git/kernels/staging$ cat 
~/Downloads/20231213-\[PATCH\ 1* | git am
Applying: staging: rtl8192e: rename variable HTGetHighestMCSRate
error: patch failed: drivers/staging/rtl8192e/rtl819x_HTProc.c:545
error: drivers/staging/rtl8192e/rtl819x_HTProc.c: patch does not apply
Patch failed at 0001 staging: rtl8192e: rename variable HTGetHighestMCSRate
hint: Use 'git am --show-current-patch=diff' to see the failed patch