Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   Min Li <min.li.xe@renesas.com>
To:     Simon Horman <horms@kernel.org>
CC:     Paolo Abeni <pabeni@redhat.com>, Min Li <lnimi@hotmail.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        "lee@kernel.org" <lee@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH net-next v6 1/6] ptp: clockmatrix: support 32-bit address
 space
Thread-Topic: [PATCH net-next v6 1/6] ptp: clockmatrix: support 32-bit address
 space
Thread-Index: AQHaI72WxBSXocJ/XESZT6513Vz+TbCacjaAgAABPgCAAgSWEIABPJKAgAoTE5A=
Date:   Wed, 13 Dec 2023 21:04:07 +0000
Message-ID: <OS3PR01MB65932B78E4262609241101F2BA8DA@OS3PR01MB6593.jpnprd01.prod.outlook.com>
References: <PH7PR03MB70644CE21E835B48799F3EB3A082A@PH7PR03MB7064.namprd03.prod.outlook.com>
 <20231205092429.GS50400@kernel.org>
 <d657f059d384419fe4df02580a4af9cf69e0e9c2.camel@redhat.com>
 <OS3PR01MB6593B50F4C5BF3687EE3FA97BA84A@OS3PR01MB6593.jpnprd01.prod.outlook.com>
 <20231207111055.GF50400@kernel.org>
In-Reply-To: <20231207111055.GF50400@kernel.org>
Accept-Language: en-CA, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?i/w7MjxcHPKlBuZbpPAvfwQ/yGfm4WX40kxEQhY7+FbK+1y0mddUXGV3HzVC?=
 =?us-ascii?Q?Qm4+02Bi3XkU56uPP9U2OeHhw7Hctw1fT8ydy8mxfk1ajXqw8cZ/sc8NIgPg?=
 =?us-ascii?Q?NFzQPmPttdQCzlY0JwswlF7rz9gA/BHxnpTed3xiiw2VER1e8wwb+1dfkjSj?=
 =?us-ascii?Q?ZC5fGdMbJmJylOMlDzDnevTSW8I4XwfV15NOA1gjB1NNk+RqApAE91aPkjsO?=
 =?us-ascii?Q?uJ+Jx8LNeoyp7A2EgudOV9bJFiFLEP1O1Zll/P4MqQsFWpyPiJFGuFiZptnK?=
 =?us-ascii?Q?istYnXMR/jNogoUP0LS01TlxLOpMfDAY76+7gpAAtuirMey1wcJ962Clar3K?=
 =?us-ascii?Q?vYa0FnOqjLW+kV8Hc6dkh55hdUhSWxA+TFvpnQFEPohx6QmHZl0dyp218rec?=
 =?us-ascii?Q?ig8jK3aOVXtSn5I9Jnpt4G+KAuzSMyqnIW1UyGGFRaDKerxHGqIkAl1XTzHw?=
 =?us-ascii?Q?CGpNRl0Kh4yLWS2Iu2LiX51xUIiZh+PVLBGIoXgIi32Umi38OeNIUn6wi88T?=
 =?us-ascii?Q?SqHnHZ0pfYr1K3F1R0ldn1GoBei4J0Bo25RkRkJMY8uRa5UcNH9kWqP96gIo?=
 =?us-ascii?Q?9ioP6xpj+OJud6HcFvGgmBbhcebSn1NZie/i/TyDfDXbzAvi2pQ4NZpcWpjx?=
 =?us-ascii?Q?HjcJ3d62ltuo2RB5YPPGOXGtCzPF1rinh5FtOuHv1VcSblPrWauJRKxgHsMR?=
 =?us-ascii?Q?+MDRLvGWsTsSMYWgxuL/5c8vqcu6y3qeN9bmCn1F7+aLmvF4x0uvR9/9sh3f?=
 =?us-ascii?Q?bKRrUn6+StTR0DooE198FD7jxiEJhs784st/ipBZIkbLX7+r+enbpKgNtV1E?=
 =?us-ascii?Q?LaMcaBy/Bn5VvWL+XF7uN806vCFGYl/SpFSlY1+sFJtoW4RTJLd6RNOP2u76?=
 =?us-ascii?Q?3ocOdQ+e1oMa5lBE1rlWOE+xruai8gI4FXT+PZlFgA/yzpLLvl9a/Z5ciHtB?=
 =?us-ascii?Q?hJ+PWQfWi0UAfhEnEgpIlc8AUN44fiBVh2ZmOBxT6AkW67ti9ItBgwjPqyuY?=
 =?us-ascii?Q?bEYKJL527uPQ+JJqCgHUvYeRfbVhg9/CRHi9Y6ecYTQ6ld3yBJSaGEGsu3WI?=
 =?us-ascii?Q?2pDF7UnGrK1cNtGCq4dNh2bljdS5zXoLZx1HhSX1/Mkca8Agy95dVPuoaMZH?=
 =?us-ascii?Q?c0SSlALDnUVQf7DNVupgAZOBGmnu35Q8/hkMNZTSQFIJlfzT7v5+vFvMm7rY?=
 =?us-ascii?Q?Eu9XLPZVk0KUIx4YpnFXezwpiUxYF1S56JDhEVTJTAGVNVFPlNX9hKGXP65V?=
 =?us-ascii?Q?xYu/GVNeAGcCDSCPXI4LmhrGvqO05UmSIvMGVflCe30lE7BUnGUVupo8v/PG?=
 =?us-ascii?Q?iMJmfFsFnpXfdJN7knTb4Xb1Rkp9WwTfWMFQPNqavfYwn5alpuAL1app40iA?=
 =?us-ascii?Q?M3WF7VddW8e5dlHqLLyX+CKzXNuVfw5+ETgsjBkRU0Td9HloXBTgybe++zXm?=
 =?us-ascii?Q?/PsC0b6oEqVEd5ZzpVAQnsD3kh0WEYED+L0U0wL1Bqa05ZzrVpw0S/Krvoxz?=
 =?us-ascii?Q?U8NMXXN+ZxCqQFALH/NvvqlyDqcSeqqg7Ef0seQjN0m7RLC9fvWhj2NgoJgF?=
 =?us-ascii?Q?W0Tp4ZRyWEjVq2E5YYARU5AXl0cewJsu0AC9EYwT?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB6593.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 055c265f-df41-474b-4b00-08dbfc1f0be8
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2023 21:04:07.6564
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0Pq9SsLPaZRhMCElK7SmURCikwblmk0sCBk9iU93eNvoOWMCtpdDlhLN80lIXX5uDqCUudUtZenCd21jZDn7EQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB7851
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 13 Dec 2023 13:04:24 -0800 (PST)

=20
> My reading is that this patch reverses the usage of module and regaddr.
> F.e. the following hunk:
>=20
> @@ -553,11 +554,11 @@ static int _sync_pll_output(struct idtcm *idtcm,
> 	val =3D SYNCTRL1_MASTER_SYNC_RST;
>=20
> 	/* Place master sync in reset */
> 	err =3D idtcm_write(idtcm, 0, sync_ctrl1, &val, sizeof(val));
> 	err =3D idtcm_write(idtcm, sync_ctrl1, 0, &val, sizeof(val));
> 	if (err)
> 		return err;
>=20
> 	err =3D idtcm_write(idtcm, 0, sync_ctrl0, &sync_src, sizeof(sync_src));
> 	err =3D idtcm_write(idtcm, sync_ctrl0, 0, &sync_src, sizeof(sync_src));
> 	if (err)
> 		return err;
>=20
> If that is really intended I think it needs to be explained, or possibly =
a
> separate patch.

Hi Simon

sync_ctrl0/1 was meant to be a module and it was in a wrong place. And this=
 patch is just correcting it.