Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <ab694710-ab50-46a7-bc48-1e329b165ae0@intel.com>
Date:   Wed, 13 Dec 2023 13:54:21 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 02/29] selftests/resctrl: Return -1 instead of errno on
 error
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231211121826.14392-1-ilpo.jarvinen@linux.intel.com>
 <20231211121826.14392-3-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231211121826.14392-3-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REVHT1dkUkxJYVVmWXJjNy80cUUxeDZPQjl5N2M3eGQ2Q21wUzZ1c1k2UFZX?=
 =?utf-8?B?SWFET0tBQlhaNlFRWnIyMlBwWU1WOXBUd0txY24zakdjQzhoN0JvM3JpTEZL?=
 =?utf-8?B?RGdWMUw5enpYZFMxamUvL0dtYnBRWml2WHhxRXl2RTdySUJBL2Jlb2wzWkY3?=
 =?utf-8?B?UmNFZFdPcGN4emd2TkljYUliaW9Wak5vTXp5YWJjOWpNVXF4cFp0SlN0Q2R0?=
 =?utf-8?B?MXpnQ20rYjg2SW93QzZVTlZmS2hrNXlaaUNMUVJiOEtvYnR1OGpiQzI5L1lo?=
 =?utf-8?B?Wi9IU2ZiZmxHU05oemhPS1N2UFV3VHZhQkppdVFBVjdiaUZjQWx1aFhrR0lL?=
 =?utf-8?B?bWs4WjlXSVFLQ09QbUtURUJTQkpqdUFka3QxWk40RDVlUU10bmx4bkkyanVx?=
 =?utf-8?B?UFIvOGxvTnkzMXZ3RmR2Sk1NTlNMa2FxV1ZlZ0M2T3FVRVQzK25sSWFuN1Js?=
 =?utf-8?B?VnUycUMvOE5RdGtoQ0pPTFlsYXl3OTE4ZnRBL0pKS0hKWkthb2ptTXY4YkxO?=
 =?utf-8?B?bys0L1BtdXdRRmxwQ3p1dVl2YUIzbUhlenRVNWljRUcrY1JEYjFYYVI0TlFB?=
 =?utf-8?B?VytaL1B5VEdvTXRFR2NBa3luRGM0ZTNDOXhPaWl1MHZDYnlQbVZubkIrY05m?=
 =?utf-8?B?Z2RsdlJxb2w4a2dybU5FcThqcXl4QitqUk16ejI3YlRvOHNaS2NCeTlZTmJF?=
 =?utf-8?B?ZmdFMEFCTDdTOXhVOU1pU2RUWmpxanRaL0Q1cFpzS281SnpGRmlacUg2ZHg3?=
 =?utf-8?B?UWI4QWI5YlRKN2JtaXBIbzJnY0RKTnFkNUY2Wlk3emttT05OZ2dyT3Y1cHFB?=
 =?utf-8?B?UnBBQzRETlVES2hKM2IwS1R6OG1nbG5nWHVtdjJ6Tk9RelV3NzZMZjU4VU5Q?=
 =?utf-8?B?WXlQbEJJRi8zVHI4UmZ0ODZ0bDNFSmlOelluNlBlVmN3VG9EdVE3ckFoaGxi?=
 =?utf-8?B?VjVmVmkyVU9raTZJMkR4N0xWUnlNR1haVWQ0Uy9nL3BaYzhSOEhzbnE3VDlJ?=
 =?utf-8?B?Yk05Mm5JZmF2MW9JN2xUVkVMVzA2MHFtMTZTNlNrY1IrL0F5WWd1Mkg3YWJV?=
 =?utf-8?B?UTZQVTJqYUxlYm5leFE1RUxrL3VJL0VlS0VycHN3WmVXMkR4NU9uNUlWeFpK?=
 =?utf-8?B?bU9OU2ZtQkFNNmpQcnE0V2ozMW9adTA2MkIxWkUzVDJuUTIxcHpiYWxXYzBS?=
 =?utf-8?B?S29FK0RFSFd3OUtUUDJBRUcvTGFQVFFxL1hBTE1nY25GbU9nUENWRm5lRExz?=
 =?utf-8?B?cHpNNlAxZVhyd3pKcitESFhXMWRXaVZvR242a1JxMHQ1MUxCeVhZanVCQlha?=
 =?utf-8?B?Z3hySmtaeEhmZmhBYlIrU1d2bmtrbncrMWRYeUpDeWFlTHJaT3VDdnVSbW5j?=
 =?utf-8?B?b3BqUTZTb3ppYXJLeTlrdHpHU3U2aTV5MGhvSXl4cXNQMGhLSjVWQmJXdU9E?=
 =?utf-8?B?d2ZlUWp2bHh2YkZHeXQ0aFRDakhmOStLWWdtSmZIL1UvM0poaFg0Q2RlNm9Y?=
 =?utf-8?B?UGczd210ZmtBTXN2SHUrck1sUXBzVzRwUCtGRSt2VjFydDhEMXF5bXNNdWJs?=
 =?utf-8?B?STVxVUJ6RFVOYm0xRDJLc1h1d2E2a3pUK3JvVGVvSEhGQ3Nqc3BUVUpMODgx?=
 =?utf-8?B?TWMxbnZIN2JkU2ZMY2NkR2dONmFHVkwyRWpoTnFoQkZwajlTSmYvQzdMeFB5?=
 =?utf-8?B?OU1ZbXArYVJPYlB3bytDUk1vOEVXOG9oOHo1ZmV5c2twNmZKWUNaTmZDRHBq?=
 =?utf-8?B?NWxIU0dOQ0ZlTTZNYjdHL1VrQUFZdUpCQkkwbDA3a3VWZFRvTHdjY2hIQ0hO?=
 =?utf-8?B?b2x0blFoMm5vMWtmMXBaNTR6bkpqSVVHSmwxN240Uy9jMTJRREY1RjRkeEpE?=
 =?utf-8?B?QWxmNjJhNEJRajJScG5hWVFvcmgwZ0E1NEJ5NGlEL2RCbThRcjQwYSsvT2ZH?=
 =?utf-8?B?NVNZUnB4czJnZVJvYWtyQjZaUFFCVU1YM3RVemNxMGF3RkQ2M1FsZjhvdS9P?=
 =?utf-8?B?SW9BcEVtY00yV0NDbksvdlNSNzR3SFhRUG5hWDNwN0ptak1xUHNZTDNMd3Vv?=
 =?utf-8?B?dnRqdmRpdDl3U1lFTmsrVHBWekw0dEpQcTQ0UXplOGNkVXIvTmE1UzhKQkFR?=
 =?utf-8?B?MmFFSUVRTzJScWRXRTc5bU13WUREbHI1ZnlBa2ErQjU3ZmNmZ292K3I4MjZa?=
 =?utf-8?B?YWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 403f8c66-5e69-4268-1588-08dbfc261079
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 21:54:21.9718
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HO9Wr/VTBkx7HI8yeUoLCwVI1Uga7J+75Q4UUvdCZADhZljwFiH0inA5sSTsXLXn2bZgIKV8fgVzd7svorOK5JFNLpaOyDm7FWsXiHL2KIc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7581
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 13 Dec 2023 13:55:05 -0800 (PST)

Hi Ilpo,

On 12/11/2023 4:17 AM, Ilpo Järvinen wrote:
> A number of functions in the resctrl selftests return errno. It is
> problematic because errno is positive which is often counterintuitive.
> Also, every sites returning errno prints the error message already with

every sites -> every site

> ksft_perror() so there is not much added value in returning the precise
> error code.
> 
> Simply convert all places returning errno to return -1 that is typical
> userspace error code in case of failures.
> 
> While at it, improve resctrl_val() comment to state that 0 means the
> test was run (either pass or fail).
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette