Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <825e8dcd-b772-47a8-8222-e6245385c1d9@intel.com>
Date:   Wed, 13 Dec 2023 13:54:36 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 04/29] selftests/resctrl: Change function comments to
 say < 0 on error
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231211121826.14392-1-ilpo.jarvinen@linux.intel.com>
 <20231211121826.14392-5-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231211121826.14392-5-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHVSOENzb1RCNFFHdkhEVGpqWGgrYUN5MEhlK1YrZkhGS2phbHl6NndicHFR?=
 =?utf-8?B?WUdQRWR6WFRCblM3Ym5QMTNjY0FzQmZhdFVWQytEYWlqOFNpbWJQL1VncmtZ?=
 =?utf-8?B?TnF2SnNtUHoyTy8yOE9XVWdoaTY3S0Q5amZ1UzVCUGJUalFhMlgzbmsvNmdx?=
 =?utf-8?B?TXBHazI1ZlhOWVJJVjczRXpESXltTEFrVW5jOUtYTXZWOTNFTlJZVE04dWp2?=
 =?utf-8?B?VTBOQVJOSjNIViticDNnbjlCWWh1VG1CWExIbk5vZFNqZ0ZxVll2b1hXdzdL?=
 =?utf-8?B?b0orbS9nSzM5ZnJ4RnRQWGVHVnJEUWd1WVZlcHBmK2c5a2NzU3EzZzc2b3oy?=
 =?utf-8?B?L2NCRGFFN3BraUNHRTdhMHBUYmd5MHR0S2RBOHIrY0Nhbm83NGlBWWdXV1hm?=
 =?utf-8?B?OVZKOFJMbzhUbGkzU2ZJd2xVM0xNNTdtQ3duc1ZURittYit5a0gwN0FJZHhs?=
 =?utf-8?B?V2JWRnlUOEFkOHNzaStSL0FuUk9SY1h0djdOZWtCcUhYa200NG91Y1lyejJk?=
 =?utf-8?B?RDdXMDZUQ1ZPQXZtT2h6bW9Cb0VBVnVabDFSdmVzVEhJNGUvQTF5Wm54QjVw?=
 =?utf-8?B?TnljdzZiRGFPZkdYQXFNTzB3eGZlTGpXRGtNT1NuZ3MxTkI0NFUrK1FkaEFJ?=
 =?utf-8?B?R0RMVkhrcEUweGR3eWlsQmpvYzc5QzZubUxJa09ZV2EvdkloZmZYdWZmRXly?=
 =?utf-8?B?UmJmKzNSMGl6bTNDMm9NbXhTY3IyMTRJMjlJUmpaZnFUVzBpalU1UjE2eUNI?=
 =?utf-8?B?Qk1OSlYycVo5OHBQRnJqd1ZTNjZRZXZ5VUFFZEVlQkZ6cWM3MTZmZVRyVmFo?=
 =?utf-8?B?N1UweGd4SVkybUY2R0Voa3MrbGVSVjVxajJPQ1k1cEdNUy9FeEZDUjJ5dnlz?=
 =?utf-8?B?U0V3YitFcUN2UE15M0ZCS0IxOFhOMWQvNm1MNlVPalFOT0c2L3hBYkxTQVJR?=
 =?utf-8?B?dGR2K0xHQ1pQS3ZsOURPbVFLR1VXU0dSQVlxNGFVVDczN1R3N3ltaDVSTUlk?=
 =?utf-8?B?UEJER3p6T3BiUWVMMmtZYXNIQklpUSt6Z3BHVU1UYVhxNXNCY3YyR1BJWkZ1?=
 =?utf-8?B?Z1doMU5BdjZvRTkyQk16SUFpb3VjWXJhSTQ3UVlrYWxhdldPLzRIUUF2VThI?=
 =?utf-8?B?TWUzdUo5bGtScm41SzRXWWk5NWFBUlI0a0xuemVyTUN5eWxOemIycFFGc3pS?=
 =?utf-8?B?M3ZQY1ZpUnJaeVJqcko2MlU1Q21CQ052ZWppSzB2b1dSSGoxUG54bDN6cEJH?=
 =?utf-8?B?bGZOa2tZL1Rod1ZkZDQzSXdINDdnT0tHU1lsbVU1Vk54R2UzMkFqRExLbHNX?=
 =?utf-8?B?Z3ByNjVjTUZvM3M1dTNYalFiUXF6VmM3TUxuVmV5VlFxMVIzUDE0Y2Y1SGtS?=
 =?utf-8?B?c254K3BqMFlxbjBESmFmcFRuSHhmSUowSjhYWEI3N09LRDY2dmk1STh3bjY1?=
 =?utf-8?B?akZXNXNpNkJkeUhLMnR6WUhabXhIRkFIcUp4MitoR0s2a2Q4T2ZydFZ3Q1Fy?=
 =?utf-8?B?Nzkrc2RHdUc0cVd6VUt1OFhsL0FNNnFBWlNHQzdWTHN2b09acnBpSnlFWW5i?=
 =?utf-8?B?b2piNURaMmZZRWk0TkZyeTNBdXpiYlVKOHo0MHZpWmVJZU1ua2NMZmpmZzRi?=
 =?utf-8?B?T1Y4b0E4bVFUMkJqcWF4RVFLRldRVlFrcXZEMFoxUEVGYkRkdWx6VkI2MWlO?=
 =?utf-8?B?dkdROHdBNHA3SjNqR0U5UWoyak1qaUlMN0gxejRieTVIWC9iSUNjUnBsMGMv?=
 =?utf-8?B?Nk93ZHN5V3VRMStUSFFGbmJBR0NmamxrcExHeW04TGM3em1CMnEybEZTTkRj?=
 =?utf-8?B?bWJZODZiVGFROGNRc2hwKy9uUjBTYzg3RjJSTWoyMkNZUHRPQ2FlcjREemhT?=
 =?utf-8?B?TS9kdmRMam5Ka1V3YUdjMFFKNlRsbWtzZXpCMEQ0aGhQRzE5aW5Vd04rT2hm?=
 =?utf-8?B?Yy9mVkdRRWhRL0dBWFc2cHZ6WW0ySk5ZVWVsQVpsUUpYNVVBQytRdytiVWxj?=
 =?utf-8?B?VWszemk5MkhhOGtRMFFFREVaVmZoUHNpams1YUhwczBwRVRRNUZZMXd3eWYy?=
 =?utf-8?B?UGpOVHFlNXNCYm1QSEx4OHhzVlo0aWxCYkhEV3RDTkhERWZURlBzbisycDZp?=
 =?utf-8?B?NkxtbmJVSmgxSHF5OTh1bnNKL2J2REFPQWJGTjcyN3FPVkpoYlhXYlNBTmor?=
 =?utf-8?B?YWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 25b1dcf0-9f3e-44b9-c0e3-08dbfc2619bf
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 21:54:37.5451
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0nZrdDGhGhI2Egzg+eYTVJ3O7RTBQiVV5UO8SmV3LfOlkZwM/jSv8vpCrDgLiNfljAl30ASI7pkZM8Ug+rA6yU0w3Svor46U/ItIzzp+NPo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7581
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 13 Dec 2023 13:55:18 -0800 (PST)

Hi Ilpo,

On 12/11/2023 4:18 AM, Ilpo Järvinen wrote:
> A number function comments state the function return non-zero on
> failure but in reality they can only return 0 on success and < 0 on
> error.
> 
> Update the comments to say < 0 on error to match the behavior.
> 
> While at it, improve cat_val() comment to state that 0 means the test
> was run (either pass or fail).
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette