Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <150fbd26-cb36-48f8-bd23-fc2eb83f03f2@intel.com>
Date:   Wed, 13 Dec 2023 13:55:26 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 07/29] selftests/resctrl: Refactor get_cbm_mask() and
 rename to get_full_cbm()
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231211121826.14392-1-ilpo.jarvinen@linux.intel.com>
 <20231211121826.14392-8-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231211121826.14392-8-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXhrQVdFcDFaSmRGeWJNNFR5M1pKOUVrdlp4M0RjYWhwRlQ2eHZ6M3AzUTRo?=
 =?utf-8?B?VzUwd1prNkhIYWdTa0MzN0RCSUpVRXJCeVA2d2FueTlKQ0QvU0dPQkVaT09Q?=
 =?utf-8?B?cit0dHlJcXd2bFRLb1BQQ3phNmdER004bFJ3b21Pc2NTcEtBdDZ4c0tmbzNv?=
 =?utf-8?B?U3NRTEVuci9UNHRTaHphVmk5TGVSaFlVT0krMDcxNG0wRmR6Q3B3NlFnRDU3?=
 =?utf-8?B?TW0zdmZJS1h0enhiOWhubFR5MXEyelRxNWRLUS9zRktiU0xRVHlLUlZwQVRs?=
 =?utf-8?B?a2hXemNNUjAwMlBJbnUvTHhzYzZHdU5EVXdFUlJoTElpSWh2RzQyS2ZmL2xK?=
 =?utf-8?B?ckR2S2pqNDhZcFZpTnYvSTJ5enBWZlE0TzQwUnprZHpXVnhaSDhkNkVKTVJG?=
 =?utf-8?B?cHN4WEZEcTZTNnNHbXphODhCdGMrVGlic2tQSEJJZ0x0SjBXZ3BkQThLWHo3?=
 =?utf-8?B?TGU1Z052SHJDZHQvNFFUdlR2anJURktzb2hnNEVYWDFUd3B6VFNPTHNNS0J5?=
 =?utf-8?B?U2NITyt6YTN1dzNIa0dzaXdJVUJOMmRZTjcyc0VTenlwMG56anFxb2Y0QTJj?=
 =?utf-8?B?LzhOVFdURG15ZWJOTndaUmxReHlucHJqTExza1BLVHBxSXJIZzhuby9HdGtk?=
 =?utf-8?B?SURWcmVKelk3cXdVVWVsTE9hTWNTcjN4TGh4YUtXMUh2eU9hdUZsWXpEcmph?=
 =?utf-8?B?T28rb2hlbzFDdGNYRStsbGppRzFFbnplQ2NuUVJJdGVnSldMcS9HMURaUExO?=
 =?utf-8?B?RDdrcXlqaEY1NDRYZER0SWVBRE9kdzEvTldTL3hFTkxpYk1KTzBEVDBkNnJy?=
 =?utf-8?B?b1VQRFM2M3I1dFg1b1hvMi9RQUFaS21kaXM3K1JnZW1FSmo4MUhLTFNyL1Av?=
 =?utf-8?B?MS9mb3hUS2FCYXYxVkc3WG8zRkxUKzQyS3JoV1lDcnhmRmtpSTVUNytSY0hT?=
 =?utf-8?B?NkhnK2NBdGhKbWpIWCtmQ3MyajYwZ0VId084U3kzejVCZlNFTGk2dk1oOXhM?=
 =?utf-8?B?VDQvSkNPaWFZVi9kUElkNVJ3bSsxN2lKZFF2VW5BTXZGMjUwNUhzQUpIRVBh?=
 =?utf-8?B?VFArUVdJTmw2djE1SHdmRkszdXJzWmRVQUtXOWkxR2hMNERZLzdkOWM4RHdp?=
 =?utf-8?B?ZE12eVpVY0lZQURnU2FydHd4dEVQOW1SQzFaVkh5K0gzWENJaVNtQnhteGNP?=
 =?utf-8?B?YWtkcit0NGNDYlRYOFF5TDJYVDNIb2MvZmhJS1Rpdml2ZHZmY1o4bDVJa290?=
 =?utf-8?B?V1ZUeGR5QVkySEhIUXdIZVUzWDZVTld2ejlnNlZwdXVTQm5ZalNkU01HenFp?=
 =?utf-8?B?bXFjSVcxWERXazdrNGFaUWx2TXBDNk9PLzN5STg3MVdOdXA5N2xGdXdEVWdZ?=
 =?utf-8?B?YjU4K2VuUVlDQjZTSE5jZWNyYzRabGU2eEp3ZlpYWlhiY0s2bmlUa3l1cHhy?=
 =?utf-8?B?U3BnZ1J6RWhrc0RsekRab0pXS010dHN3dHhzOE1pS2ozSUlVSFBqY3VFeXJn?=
 =?utf-8?B?WUxJY253c2tkSU9lUlB1T0d4OUpnU3gwcStheEo5bEhPMXhWWFIwVTEvQTdT?=
 =?utf-8?B?aDRVbzBDUHJQT2JyTThzZGxrekJGMFlkWE14aFhscDhoVU9jSGVlMFlkTEFC?=
 =?utf-8?B?UWRZOElrclNvcEM5aHh0d1RjQTJLQWZuZmp3Zmk5YTQ0di9XRVExRXZVZ3Jj?=
 =?utf-8?B?UjMwbFgxbDRUSk05VjMrOWZXdXh1ZUZkZDB2V3BaZGhja2lOaVlsWFhma09G?=
 =?utf-8?B?OGFFRUNCSWcybVJ3SGc3VVFOb1ZGTzdvMHRvK0ZWSGU1K093eUtUYVpXNy8w?=
 =?utf-8?B?ZVpaWkFJS1cwUHhJb1E3Tm9tVjQwc0hqbHpIQ3d1NUVtOFdFR3B3MURjWTR3?=
 =?utf-8?B?SjhnZ2VzVmVlY0tNQXRMMSs4cVQycXJrUGlUcmNSN3lwbmdJMWlHR2xiSzkx?=
 =?utf-8?B?OVJ5cUZ0UTVJZkxkVjl2ODQ5Tm9yYUREaUZsdDQxQ04zUk9vdnZSamVkTmtN?=
 =?utf-8?B?Q0tscjBvbWJ3ckJYNHZGYkorY2lxMTloaDAxeDR0RG1RbUdyR3NZU0xFRU1M?=
 =?utf-8?B?bHlIb0p2M1VOdUlFdjdyVE1ybXYrSDV3K25pTGJaanJrNTAvZ3pKd1hOUkpN?=
 =?utf-8?B?MkNvMHZmMmdHaERaSTJIblJUaUNTWkV6VjI3RW5NWTYzdFdmbllzNm5VdEdP?=
 =?utf-8?B?QWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 99aac726-773a-4fe9-ea45-08dbfc26375f
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 21:55:27.2590
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VqSVqx6LJnacfF+YmLFoJ0vPIZ8iI8PHSC1W+zJ76XuOO2PWD5sUKlEKQYr8ThhUyt62Q0btd5t0Zajbx7o1htbs95svXOjkuP1SPUwjdpY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7581
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 13 Dec 2023 13:56:13 -0800 (PST)

Hi Ilpo,

On 12/11/2023 4:18 AM, Ilpo Järvinen wrote:

> -int get_cbm_mask(char *cache_type, char *cbm_mask)
> +static int get_bit_mask(const char *filename, unsigned long *mask)
>  {
> -	char cbm_mask_path[1024];
>  	FILE *fp;
>  
> -	if (!cbm_mask)
> +	if (!filename || !mask)
>  		return -1;
>  
> -	sprintf(cbm_mask_path, "%s/%s/cbm_mask", INFO_PATH, cache_type);
> -
> -	fp = fopen(cbm_mask_path, "r");
> +	fp = fopen(filename, "r");
>  	if (!fp) {
> -		ksft_perror("Failed to open cache level");
> -
> +		fprintf(stderr, "Failed to open bit mask file '%s': %s\n",
> +			filename, strerror(errno));
>  		return -1;
>  	}
> -	if (fscanf(fp, "%s", cbm_mask) <= 0) {
> -		ksft_perror("Could not get max cbm_mask");
> +
> +	if (fscanf(fp, "%lx", mask) <= 0) {
> +		fprintf(stderr, "Could not read bit mask file '%s': %s\n",
> +			filename, strerror(errno));
>  		fclose(fp);
>  
>  		return -1;

After seeing the new effort to correct the perror() messages it is
not obvious to me why this patch changes these particular messages to
use fprintf(stderr, ...).

Reinette