Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <ac7b59fa-f2f4-40b3-bf60-7d35b4fcc267@intel.com>
Date:   Wed, 13 Dec 2023 13:56:17 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 10/29] selftests/resctrl: Exclude shareable bits from
 schemata in CAT test
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231211121826.14392-1-ilpo.jarvinen@linux.intel.com>
 <20231211121826.14392-11-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231211121826.14392-11-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWgwREp6a1ZNbnppcHNYVlpRNFYxWmRBQ2ltc2FxdGRwdUtVbVdlVC8wRGlB?=
 =?utf-8?B?WW9BMlFxMFBDNXU3eEwrWXE4ZG85bS9wYTlXamc5TXBQMTR0V2VuREcvcG1K?=
 =?utf-8?B?c1prc1JWdzRrREt0ZWRqK2l2bjdmOTZsc0F4TGVuNHhwNUUvWUF6cXV2aEdI?=
 =?utf-8?B?b0kvd3dMK0c2Y1BmWDVLbW8wYXlhVm9kWEdaZjExSWlza1RDMFVLYUNDTEl0?=
 =?utf-8?B?NC9VVmlRY1NLVmFWb1E4L1EzaFhaZmU2YndBSEo1dnJveDJ3QnhDU3pqWG8x?=
 =?utf-8?B?L2RlY3cwNjZGSTZYTnB3Zk00M2J1MkE3c2NHeXlRZ1IwNng3L29zMStDYzJV?=
 =?utf-8?B?ZUtMaTZNUlFGRndQRnlkWmxBajhxdmxUcmVXMWxKYllpRzZNMEZGRXZyaFda?=
 =?utf-8?B?Zk5xdUxBU2VDQjAwUWt6RmxjcGVzeDhpeDJOSkhYcFMvSXdOdjNReDFHeXh4?=
 =?utf-8?B?QlBqUXJTbWZFOFgreURMcjhIQUVKYUpvMUh2N1NleXlZUG4zWWJOcFY1VEJp?=
 =?utf-8?B?eGY0MkhQVE5PSGFkbmRvK05CQXc2S1RURnZLWkhiUndPazhIeVhwYXVZZ21W?=
 =?utf-8?B?QnFjREJqUGRWWmw0MjBHcDdoLy9PVmlhTVk5dWRobSt0SDEyMlg4NGNRY0Ri?=
 =?utf-8?B?NmRBUTVGdy9xZTRyN09MV1hEV1JmTWdiTGRkWWZ5MEJLeXJtRFllRHBtV1V5?=
 =?utf-8?B?Z1hLQ2JUelFOS01DdDhOeXRid1N3SnBCcjQzZ1QybXdpaklOVXJrYzI0S2g1?=
 =?utf-8?B?RWMyZDR4NDBYcEVpMWswcnNVb0xrNVBUcmVaNlRqcTRxQVBua1N1NTIyRVhO?=
 =?utf-8?B?SjJ1ZklwZHRhN2ladVR2cEpIV3Y3RDRDbDBJQld0M1N1NVE2R1FCbFVVanc3?=
 =?utf-8?B?TzJTQWtpRFVqcFh2STRkemltaU54bmN3YnFSWEJUV1JyZ2JlTnQ5azhUMzBR?=
 =?utf-8?B?aXZwYlZrak1zMEhkMWtrTEk3UWh5bkJyNTBCdzFtT2txaW56NlNPZ2hUWWIx?=
 =?utf-8?B?SFFjQjQvYTF4SVMrTWdvQkxLOTZUdkdWMFVGVGJTZ2hxU1lQRGJwMHlvMXdl?=
 =?utf-8?B?K2FpQUlwVkxBNkJyQ2xYR0x0RHBBb0lPR216bTIvYlBLMUh2QUpXT1c4eU15?=
 =?utf-8?B?Y3NwRC9wOXRQNGZOVmYzTVhaRWVNMWkwQ0xRa0JNTFJzRkdqTGFVbjc3aEJm?=
 =?utf-8?B?bG93RTZvMFMxMHlBajI3MWQ2cnlVK0l5bHZPbW5qdzV5QzliU3d4blNPeElu?=
 =?utf-8?B?SXVkcC9lTlJLU0x2MmtjMWp3aFJtd3duRGY5dFFNSUk3d05SemJ5Y1dnc29M?=
 =?utf-8?B?NDJTMHhBV2N1V2c3YWJEL1VoZHJHMUZrZUt2RTNVWkpTU0hPSlUvNXRiV3Vw?=
 =?utf-8?B?c0JwRjR2dGZ2cEIzdTBwcHM3MWFsRHZFaUJiUC9FQ2h5dW5QQmVucjFFZys1?=
 =?utf-8?B?R3Q5MS80YjNUOEN6VHZ4bGIyVjhpNTVWTUpCS0xrSWhjenFkU0xZRW1sTjk5?=
 =?utf-8?B?LzBndVBwSkZoS25ZQk1qMXVOeDUyZlB1REhwZFlvUStENkd3M0FjZE1CTnpn?=
 =?utf-8?B?SWhDdks0WjNTcExDS0ZDWmhiZzRsYml6dHE0OFBNZ1B5ZFBjNVhXWmZuQVVT?=
 =?utf-8?B?QWZUbC9GbFkzb1BMdXNXU0xmQVlSNzdyZHd3WW5RbEkyUFBmWVJFZTgxMzcy?=
 =?utf-8?B?K3JTN1c2bW94NzdsenJmSmFlT3B3WmtYOHM5ejN4amV1aks4dS8zbFA3V0Ni?=
 =?utf-8?B?dGlpZVl2THVSUGNLTDFqcEE4U1ZTcFhHcmtuSktSMk1Wbnc2T08wZDRGaitj?=
 =?utf-8?B?VmxlS2Q0bzBnV2RRUXVpV2pOSDlVeEMrVUNvdU91WE9wbzIxVXhQeVpEcy90?=
 =?utf-8?B?bFgzRDh4d1MwZE9WREpGTkZ2a2NqUWhuaHFLUEVJRkU3R1RtTWU5Zis4bVZE?=
 =?utf-8?B?UTNGeXlHdDh1QVUyYjNSMjQwN2pHY1I1RnlsUysyUGtSbXlJK3RLVURKcXI1?=
 =?utf-8?B?TWdkbE40V3pIVjFhTXpRM2dXUjV0blhYZVBBQVdPemFORW9jVm5reUh0b0la?=
 =?utf-8?B?MVVwYjdsTjhibFUrWDR2Q0N1T2p6blIxamtTcFJaSGpQbE1MVEVOTmd4SUpE?=
 =?utf-8?B?YVo4U2lpRkU1S3g2bFJmQ0g1YVIxbWFxd1REWFJURmlud1FYTElQdXlRakhJ?=
 =?utf-8?B?VEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d7873c6-f647-4b44-7d9f-08dbfc26560d
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 21:56:18.7227
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mdItF5u9EwesElbYfYT86l7Ezln50ZC81rd9XHSyGQyXypJgAaX1GBK458ATxvRvzIiIH8BhJMq0Tdv+qNWp6z97oD/z2z1aOQq7e7vjDBc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5925
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 13 Dec 2023 13:56:32 -0800 (PST)

Hi Ilpo,

On 12/11/2023 4:18 AM, Ilpo Järvinen wrote:
> CAT test doesn't take shareable bits into account, i.e., the test might
> be sharing cache with some devices (e.g., graphics).
> 
> Introduce get_mask_no_shareable() and use it to provision an
> environment for CAT test where the allocated LLC is isolated better.
> Excluding shareable_bits may create hole(s) into the cbm_mask, thus add
> a new helper count_contiguous_bits() to find the longest contiguous set
> of CBM bits.
> 
> create_bit_mask() is needed by an upcoming CAT test rewrite so make it
> available in resctrl.h right away.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette