Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <40574201-9f54-4da5-9d58-0b080c8c7b5b@intel.com>
Date:   Wed, 13 Dec 2023 13:56:32 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 11/29] selftests/resctrl: Split measure_cache_vals()
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231211121826.14392-1-ilpo.jarvinen@linux.intel.com>
 <20231211121826.14392-12-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231211121826.14392-12-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SC9IbFY2V0lxZ2QwM1MvazF4Z3hlRGRzY2pNZmRlUUdtODRUdWErSm9IVERM?=
 =?utf-8?B?ZU0rR2JZQ0VjMWV6TUFKTW9LcERrbzVYdnZIRkwxbW5iWmEyTkpYT1orUU4w?=
 =?utf-8?B?MVc1Yko5Yk05cGFjdlVhT1hBc3FWbGpLempKWkxrTmROb2txZzMvaHI1a1h6?=
 =?utf-8?B?RmJZZFYrc0VPYUh1SlphUS9seDI3cjI2WHBEU2VITzBmY2IwSURVZER2VFFJ?=
 =?utf-8?B?OWxpdU4rMlV5ckMyMWZrbkEzcm1VWkFBYk5hNlM3RkhodTdheWpTQ0had2Mr?=
 =?utf-8?B?ckQ0VXd5M1hUa1ZKZXdFZzN1eXB1K0xUM3h5eTVvZHBJOUczb2wwZ1ZXVitr?=
 =?utf-8?B?TnpYT3c1SkY0YjNuYmNTYmpMaEdiZVdDYVR3RVM0RnRzRHdLc21LWjNJUUE1?=
 =?utf-8?B?Q0pXK2dkbFpkYjc3RW9NYW0xNGdWZXRCR2ZwcUhZeUt5NldpTFJLR1E2VzdU?=
 =?utf-8?B?ODJrVXVhT1puVDNEZ2xBZ1R4V0dMMTNBb0pLcCtDcUxYYzdLM1I0QjdRK0lI?=
 =?utf-8?B?ZGVOclBjd2g5ZVEvS1R4b0lxSW80cTFuaEdtcjVsdkhwdjMwWUtJRTBNZlNO?=
 =?utf-8?B?aVF4ckFBOWF2eEN2NEpCb3VBbzYwZGVnMCtwZXNWY2lrNE01VVhtZFBWb09F?=
 =?utf-8?B?di9YNjkxejd4aVVLMExXTGY3T01KNlRUTnpHa0VnbE9hakRTVjZRb0JKd0Rr?=
 =?utf-8?B?djVaNUtYelB2R21mTldoMlhtcGl0b0p3aE5GY1JocW1ERmZpV1BiaWVQVDh3?=
 =?utf-8?B?dG1HUWp0MTUzMUNpd3JZNHpneXdrRFFpV2FRRmkybEsxbjEzekxRdVRqRS9L?=
 =?utf-8?B?T2F1dzBZcG9BQVdTeVE5dzhGeCtRWHlZWXFPUjZXeUxoUVVkMkRMM3p0eXJj?=
 =?utf-8?B?ZHliejlncGdRcmxTZGZIR28wQ0tpWEk1Q05icmFUSFZneHc2eUtSYW0rblFX?=
 =?utf-8?B?RktURnRnTndzNzBWbG9FQnNRZ3RnUU9zKzBiWFJSYkZMeVA3eDFjNmRPaFRp?=
 =?utf-8?B?VEttbTI4NU5CUEs5L1dzZEFlOWpDZGNWTFdkY2tpa29jV2NEWTBUaUtmMUZy?=
 =?utf-8?B?SlJnMkJMdnFxUEFNL29wcjZ3WmJLeHZOQzFWYlFwaVZPMStiNmNpQXhIWU1G?=
 =?utf-8?B?a1BxU3N0M3lDY0Z2SlMwRWxoODV6R0xjbU5acERYNmhYL0RJVksrMTNpZ05j?=
 =?utf-8?B?cFpEYTVDWEZIVmNNcENRb1dYRzdSaUdOazloV0NjdEp0SmlnbmN6b3FhbEtZ?=
 =?utf-8?B?TUdBbzVUc1dWM2ZRelpoWjN6N1MzYTJ3emFnSUVQVVRUeXE2SzFwZFczdGN0?=
 =?utf-8?B?MWNZa2ExeTAxNnozdTF2TzQ5OFdiMGpQZTMveXN3SUloWS9jeWhiSnV5Q2Ev?=
 =?utf-8?B?TFQxV1NaamNDSld2WkN3YmJyNkl6dnJhampXcVN1OUZ5TE1UenF4V1lIUm56?=
 =?utf-8?B?bnlrRGg3eDZGNzZhbWp0L2wzTGNxdW5QajgvbTMzaHA0UmVzRVFXRWovd25v?=
 =?utf-8?B?TlpnMkdSOHIrdjBqcW4zM1pnSHN5WVJJZFRyZ3l2VVJ2ODdiUXp6TDduYWJU?=
 =?utf-8?B?Y09QSk5iZDByd3FPUDlST0E1OENEaVQzSmw4cUVaUXBBT3o2U0cxcWhIOU1n?=
 =?utf-8?B?VWRCZ3pNaU1JSGtwR001cFpmYnlKZlNhMFdaZE1HMUxVMXRCNnR3ZjVzL1JD?=
 =?utf-8?B?MnNTOFQ5eUVoMGVoTWVCSnFMMkFGZUF2bDRtTjRSS3pMUnJXd3diQjZaK0hN?=
 =?utf-8?B?ZHhiTzdkUGNDdjM4eW5PQjBDRW5Fb0VIWFZ0SjFucjFrWGVqTFNQMXRoNEpZ?=
 =?utf-8?B?Q3JUcnVpcnk3ZWQ0ZWNlYW80aXJ4ekpONE1uNHhGOGRVZitRQUlra2FtSlAv?=
 =?utf-8?B?K1dUY1hmVW5YQWY0cjhXdDlYSm9XdUQxenVLYzdxTmhVaWUxc1p4RTYxUXIz?=
 =?utf-8?B?UFpPMkNpTzJ0TUhDeUxpd2J0R01meCt5TG9tNmM2UXZCQVFwMFB6M3hiUk9Q?=
 =?utf-8?B?TEt6YzRwOTVhRGJwUUFtckx5REUyKzRVMFVHanVwVE5HSDNJZEw5NDQydmFp?=
 =?utf-8?B?NEFDUEltTGpPaUtNek93Ry9xNVAvbkM3Q05Hbm1oSW80bUtNTnBqeXhMREpD?=
 =?utf-8?B?VllESE9qMkRWUjQzR1JINVU1dWlCZy8wb2RwekpRK0E1bytzNDd2eHFXZ1Nn?=
 =?utf-8?B?T0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a5c51045-b1bc-408a-e33d-08dbfc265e8b
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 21:56:32.9728
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u7GK9/UqSHhuVInhea0xw+460PGlWsvbOSGl8uTQ9I5bahSeKf/B7MfzQ5B0fjz2C3MRhV3KVTbDCv+yTm1Ylvwu4/q9jhaK/q6ima6u/6A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7663
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 13 Dec 2023 13:56:56 -0800 (PST)

Hi Ilpo,

On 12/11/2023 4:18 AM, Ilpo Järvinen wrote:
> measure_cache_vals() does a different thing depending on the test case
> that called it:
>   - For CAT, it measures LLC misses through perf.
>   - For CMT, it measures LLC occupancy through resctrl.
> 
> Split these two functionalities into own functions the CAT and CMT
> tests can call directly. Replace passing the struct resctrl_val_param
> parameter with the filename because it's more generic and all those
> functions need out of resctrl_val.
> 
> Co-developed-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette