Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <1d96d1c4-d37e-40b0-b343-b143efd6440f@intel.com>
Date:   Wed, 13 Dec 2023 13:56:45 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 20/29] selftests/resctrl: Replace file write with
 volatile variable
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231211121826.14392-1-ilpo.jarvinen@linux.intel.com>
 <20231211121826.14392-21-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231211121826.14392-21-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SzY4R1F3VUpmcXA1ZzMvNkhGN280OURDSFJJRVkzOHhNdkJqYXMrWnIzQXhO?=
 =?utf-8?B?bHZYZ3FlejhkTi9qVHFEVVRQSXp1bHRIN29UaEFrS2hwanRVTnVRR3B5RHQz?=
 =?utf-8?B?YUV2NUd4Zlo0Y25WdnlQTVRodGN4WjZTYjZ4LzNtcXFBSmxVakRzTlJXWEFu?=
 =?utf-8?B?NFZaSDV1amxBMGdFYmRCV3NjMy9SN3lsWlJIWFE1K0RmVm8rUlpwamRnb0M5?=
 =?utf-8?B?dmN3WFkyWDMycDZlSS9CaGRSVzBKZE5DdEthaDJpcFFPNUJIdHViS3h0NHJp?=
 =?utf-8?B?OHlqWG5uekhSK0ZJVVF5Y0M2UVEvSVVVQW9QYnVzM2srZ1RVUVVXVWltVlRN?=
 =?utf-8?B?NGJtbjg0OHN3RWJQMTdzYUVINkxEbE9LZllBWEdFYVgzWTdieXRPTTI1Z0tz?=
 =?utf-8?B?aTRwdlJvTGZpUEdhMEVCVm16c2FnZzdOd2w3VFNmK0FrRTVOZDJCdFR1TGJD?=
 =?utf-8?B?dGx3VWc4amZrb3pKSDZJZHBVVzEzZmZaN3hQSmpWNW0rUXRJVE4zRDBHQVlm?=
 =?utf-8?B?ZnNsZ0pXdGxrNDZDQ2hqd2FMeWVkRnRtOFBySHFidENsWHN2R2s4Q2htTXox?=
 =?utf-8?B?WmV6K2t4NUNXY2pFN094TEZVUTgrWGhwWTZOZ3dDblhtNk5XaitBdGJsaklZ?=
 =?utf-8?B?aDd0RzhKSWhBTEtrTm0wNmxTSWt5NEhIV25qRjU5M1BzaGRxKzJacXB4YVFi?=
 =?utf-8?B?UUMyYnNVRm9pWjFwQnZoSEhWNlkzNG1OMXlaa2FyYmRaMXl2cG1vSHpRQnlz?=
 =?utf-8?B?ck1iRnhwd0tsUk90amxuOXd5SUdBRWtzNTRHQUlEWjhXNFhubnYwcmszQVZH?=
 =?utf-8?B?Ny8rL1dNS2dCUU10SHUrTmNUYXJzOHFkYlZpOGl2L3daZW9jWm1uQ0JVMFVK?=
 =?utf-8?B?dGJ0cVBYbGE0cUc3N2ZNV0h1SFdtWHVDWDl5d2d6VEdXL1Z1VTNMOUJ2R2wx?=
 =?utf-8?B?VVhTZlBZcklaQTMrYVc3UTN6Vmo4dkJyN1h4KzlaMFBDdkZ3TnIra21iWG5L?=
 =?utf-8?B?MlBrcHNnK0g0T0UxcVdBUXdhS2FlYm5Sd0oxRG9BZWVPL3RkRWxjOFJtWExW?=
 =?utf-8?B?RlBoQ0dic0FyRU1nMHN1TlY4elZUb1BqTUVPeUQ1NFh6R1h6NEt4QzJoMlZH?=
 =?utf-8?B?Z3Vsb1AxWDlVeW11WmlrNzNkTG9zSUcyZkQ2enRnUHB1Q1phTTVJRXhsdHZh?=
 =?utf-8?B?RkR2ZkRsYVBHL3g3Zmp0NW5DRC9pbEdtZTJybHlWRnpSM29vOFM1ZDBIYmMr?=
 =?utf-8?B?K0VMdFd1MlBaeTNKNW1ndEoxNUdjRURkeXN5NGkzZ0pLQkVWY0dCNS92bFpE?=
 =?utf-8?B?bHlsZklXK1l4emJOazQ2SlI1N2puejQ3dlgycHZRTlpkUnNyUGpjQUtvUDhI?=
 =?utf-8?B?UUdNK05sUjE5RjR3bEttcG93M3U2ZElWdXd5eWsydkdnbHN6RmxxV2lHOC84?=
 =?utf-8?B?OGMwdDV5K0d6MHNWNkQwRGhtUmRjTktzbUJrZE05WlFDSnREWEtRcDd5a09m?=
 =?utf-8?B?TVNWY3NaVWx5SWVUM2lZVVVOb3lEOW9DdzBNQklLbG9VaTQwUVZvMEZST3ds?=
 =?utf-8?B?a0dualkwV2lBMFZLYkc1NmxVeDJ1ajVGck0rbHB0cjROUFVuUGdFY08xa0JC?=
 =?utf-8?B?enh2RjFwWWdiUFpjQ1Nkc0JRMkpSOU92RjIwUVlrN3JMZmlWS240ejgzbE1v?=
 =?utf-8?B?eDZHMDEwZ1BPejBRTlZ5WmxRV3Jxc2lkdjVnc2dyT0dBWG5GdlVsSEI5OWdh?=
 =?utf-8?B?ajRWN1dGczh4amhYbW1DMmFBSVJSQS9pcG9MVHhOWGluVTlyZ0RNcUNIYW5Z?=
 =?utf-8?B?MzV1emhDNHdJU21nNDFWVXJDVHhQODdpM0I4Y3NReXpnQ2hvQzlpcnFLa3Ry?=
 =?utf-8?B?VUxzWWxUb3VEL0N5b2NhNkhVMXVSbmtYeDJPNFNoYVBYMVZqL0RBbVJ3bVB5?=
 =?utf-8?B?dDI4SitMWTRBZ0tHbGdEVmxYdWNHOEliTzN6MkVnM2xCNDY4NVE3bXFiWHdO?=
 =?utf-8?B?VHBSYVJQbXQycnJ0d29sMDdjVHVlSVIvK2JGeFBjT092NVRyV3BOUmFTZHFJ?=
 =?utf-8?B?V0JBME5kalY3bDNCK0pFMFRLRFdTblBGT1Exa2RDZ3dNSW0rZUNzWTN1V2VO?=
 =?utf-8?B?ZmtoNllyWEJkakpmS3dmdFNHZlhJYUx3YkdkWGJ5ckJvaU9rRGxpMXhFR0FG?=
 =?utf-8?B?RVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 45983953-f710-4425-767b-08dbfc266676
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 21:56:46.2356
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hRWly2ybgGUxWfOtVWZ7YOor4ea6cuB4Gtewlx33RVuJvKLNuwDot6yigD5xHC2Y7leR954oJ+xsTppm/0aSXlStmr6g6oyAxwK8bQli76o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7663
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 13 Dec 2023 13:57:12 -0800 (PST)

Hi Ilpo,

On 12/11/2023 4:18 AM, Ilpo Järvinen wrote:
> The fill_buf code prevents compiler optimizating the entire read loop
> away by writing the final value of the variable into a file. While it
> achieves the goal, writing into a file requires significant amount of
> work within the innermost test loop and also error handling.
> 
> A simpler approach is to take advantage of volatile. Writing through
> a pointer to a volatile variable is enough to prevent compiler from
> optimizing the write away, and therefore compiler cannot remove the
> read loop either.
> 
> Add a volatile 'value_sink' into resctrl_tests.c and make fill_buf to
> write into it. As a result, the error handling in fill_buf.c can be
> simplified.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette