Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <c8fb2854-6404-4378-967e-7724726e67a8@intel.com>
Date:   Wed, 13 Dec 2023 13:56:58 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 22/29] selftests/resctrl: Rewrite Cache Allocation
 Technology (CAT) test
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231211121826.14392-1-ilpo.jarvinen@linux.intel.com>
 <20231211121826.14392-23-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231211121826.14392-23-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVNXVVJvcjFNT2ZtOFdhVDl3ZXh0dENSVmRhdUR1Z3RwK0NPczQ3SVhOeUpZ?=
 =?utf-8?B?ci9md2tUR2FQSnByaTZ5WGw5ZTc2bTA0VFBQOHJMODBuWlYwaVJDRzlnUEJN?=
 =?utf-8?B?UDVHZlhCZFVQN3QrT3ZsYXNsdzA1VmpIK2h0eUk4bmZZcXd6TkpCUENNbW5H?=
 =?utf-8?B?cGFxOWtMUFY3Ny91dVE1dDZ3dVJzS0Z0dVlQWG8rTjQzYTdEWEpSMnVFM056?=
 =?utf-8?B?M3Ayc0M2THNGNXFsZEFVRm9oVUc5Y1oxWm5BS2FlWGRjSkVoL2p5UCtwWkdK?=
 =?utf-8?B?clM5ZzZBWUthRG9zclJMYktLY2xJUVNaeW5VRGtvOXYreE1wODcrQWZiK0tL?=
 =?utf-8?B?R3pZWmxVT0FHeWZTK05xM2tHZXQvcCtSL3ZXNVJHQzIzMUl1UEg3aTF2Vitw?=
 =?utf-8?B?d3ZOd1JPNnVRL2VlbUJRSFlnQmFYYWY2SG03UDBpdDJwNG5kWWJuL3hSTU45?=
 =?utf-8?B?VUlTV2UxTTdlaThFditqU2Y5YTlITFU4cHpMRlJ3bytORy9GQmNzZWRpWWo2?=
 =?utf-8?B?OUdZR2ZGWEgyOXBvOGdmaUthbUZLSHp2Vjhsd0pHeWdlWmQ1N1RYeHlHbHFC?=
 =?utf-8?B?S2tFV215cnd3YnB6aldpcWgwYUhTVzlTR3g2QTlCQzk5MHdXckdQb093dUxr?=
 =?utf-8?B?Z3lrcFFFRlNmZWNRbXZOMUpaelA3N2tBR2ZxQlo5V2NZbDlHSXYwR2NGS2lz?=
 =?utf-8?B?M1o2NTdGczEwL0o4dkZkZ0ZzZmpVTnlJQUYwWXk3WTVKSHduQ3hVN3ZPZEE4?=
 =?utf-8?B?bjI1Wnlackg1OHNQNDN5RHFxNmJ0SE14U25Jakg3WmozTlFkSURtTFBZSVE1?=
 =?utf-8?B?U1RzVDFGTVhURDlMNVJhTEp2ZTlTQkhibGdWRDhzOFFnV29hSHMwc0JIQnFE?=
 =?utf-8?B?SmswcGQ5L3A5QTU5R3NSK2lrcFI4c05QM0w5YWdxT1lzaFdrYldtN29qdXpX?=
 =?utf-8?B?TDlVK0p6R01ZRjNBQUtPcTJreWk1cVpLRWlmRzRlVDlxemdKalh2SjdyQjh0?=
 =?utf-8?B?YlNiSWQ4cERGZCttY25lMGxmQ1N0azRqYmlwWGE3MUJnL1Q5Y1ZmL3J0MnlX?=
 =?utf-8?B?MXpDcDMvRmRkRTJzRjVLM0dJdzcxd0piTnVTN2tLU0UwanhKdG1Lbm5KZHJj?=
 =?utf-8?B?a2o3RFRBekRjRkpzRGluclpSak16OGhRQlhuT3RKMUd4QkpoK0hTMEM5TnFI?=
 =?utf-8?B?VlVFUDBGc3JSbXVYczNlRzJZTUlrelpwbEJJNVlTbDc2MVV0UHV5WC92bzFW?=
 =?utf-8?B?OURaTDFCN1E3S0w5V2lKREVpZVdVcFR1ZFM3UGFSbitIS1ArQ3IzOXRZT2pw?=
 =?utf-8?B?ZXBVWVF3VDA0V0ovSnE2a241Qm5IVFdrbkUxNTRjcTZZaDJ5Uk1ua3NUcGlK?=
 =?utf-8?B?UTVhWmxWdHB3dVVIeFdIME9SQjBtOVVCVHRjNEZ1d2NWTlN3cEVvY010TlRo?=
 =?utf-8?B?TlNocytYNnQxbDF6Qk90WFR4dFByWHNsR0EwZGF5QStxOUVRd2dWNmE4QVFY?=
 =?utf-8?B?bVY4QUdZcmQzWEhuRUZid2tibkhsN252cXFPTENVVW1COUQwaXd0T2YxMytp?=
 =?utf-8?B?RTRHZHFSdkp5UTE0aHpHZGRmSEZORTNnQUtuYnVpS2RkN3Rvb0VaZ0dpcVFR?=
 =?utf-8?B?aG5MdWErMHVUdng4OXpneDkxOWZFMHV3WnJvYnBEQzU4djZ2WFNQNGpKT09I?=
 =?utf-8?B?ZjBEaW9YS2VWR2Z5NTFwOElhZVJNS1NNSjN2OE16ankvajVWNUNvamM4Z21m?=
 =?utf-8?B?djQ2Y0dLbDY2aGFqK0ZxTlphLzA5b09uOUF5MGM4OEZCV2ZvOFM1Vnl2WFlS?=
 =?utf-8?B?R3laVFV4Y2JQZTZPRFFQQmJoMWVCZWZsNkE3MklyRlZoNnZJR1BubnR4cUxq?=
 =?utf-8?B?UWl3Rzc1WG5VcEJaaktEaGdGb21TSnFTb1hIK2RnSFA5VWc3U3pUVTBPUzQ5?=
 =?utf-8?B?MzU3d2greS9xYlNFK3hEVkxGbkdXend3YlBiY0lFWHZOM0tHRzNkNXV6b0kx?=
 =?utf-8?B?alNIMzVyTmp4V1A0UlE4ZUU5c1Bvekl0OWxqVkZqYldxQTBoRzJtLzFWRzhG?=
 =?utf-8?B?UHNvNHNvZnE3b05yT0M5SVZ5cUFZQXdvNW1OMnZ1WlFka0JnUFl6K0R3UlpC?=
 =?utf-8?B?SnJPK05pU3l5QXJ0ak9kWTBMTTNXRWlwS0Z0VnF2cWlhelpReVJLYWwzclpR?=
 =?utf-8?B?dGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b07b7012-c280-45ad-5811-08dbfc266e6f
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 21:56:59.6305
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kMyQMEcZ3n+z+Wdw5tmH0Y3/FtS6q8Mn8d5MzRhTMJ+axFbjbc/QSOOKtuBZjgI/mUkO/6Mr+Jg1XYKmPPiZp7SRvjo3Je82gcIDa9z4y10=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7663
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 13 Dec 2023 13:57:19 -0800 (PST)

Hi Ilpo,

On 12/11/2023 4:18 AM, Ilpo Järvinen wrote:
> CAT test spawns two processes into two different control groups with
> exclusive schemata. Both the processes alloc a buffer from memory
> matching their allocated LLC block size and flush the entire buffer out
> of caches. Since the processes are reading through the buffer only once
> during the measurement and initially all the buffer was flushed, the
> test isn't testing CAT.
> 
> Rewrite the CAT test to allocate a buffer sized to half of LLC. Then
> perform a sequence of tests with different LLC alloc sizes starting
> from half of the CBM bits down to 1-bit CBM. Flush the buffer before
> each test and read the buffer twice. Observe the LLC misses on the
> second read through the buffer. As the allocated LLC block gets smaller
> and smaller, the LLC misses will become larger and larger giving a
> strong signal on CAT working properly.
> 
> The new CAT test is using only a single process because it relies on
> measured effect against another run of itself rather than another
> process adding noise. The rest of the system is set to use the CBM bits
> not used by the CAT test to keep the test isolated.
> 
> Replace count_bits() with count_contiguous_bits() to get the first bit
> position in order to be able to calculate masks based on it.
> 
> This change has been tested with a number of systems from different
> generations.
> 
> Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Thank you!

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette