Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <172d13f9-2ce8-43ad-b354-402d137b914b@intel.com>
Date:   Wed, 13 Dec 2023 14:00:45 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 27/29] selftests/resctrl: Add helper to convert L2/3 to
 integer
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231211121826.14392-1-ilpo.jarvinen@linux.intel.com>
 <20231211121826.14392-28-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231211121826.14392-28-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVZDOFhjbThOOE1JOHVOUzEyaisvekVXMHpQaUpYN0JtVkdqSksyMExuRHBG?=
 =?utf-8?B?c1I0SllIMDArWGU1Z1U1aDFEbGhhWitYd24zNWowekdVa0k2ZkVaeFZuYkhV?=
 =?utf-8?B?TTRNR3lYZUV2dHV3emdaU0x1U0hHZS8yMHliZkFjemU4UERwU1h0SEFXdzBI?=
 =?utf-8?B?elNoakIwQUI2Q1hiODFxNFgxNlJpRUJkb2ZhYXplTnN4MDN6WjFPekNLZzJr?=
 =?utf-8?B?aHowT0FrL2k0cWI5bW5sSExwbkcvaTVGOHJ0M0R2THlRZytFbklOVHBFVFlE?=
 =?utf-8?B?NmNIZ25DTFNESDR6UlhtYUNocURpN3F4QzBpRVRuMXB4aFhXVllTaFR0UVhO?=
 =?utf-8?B?RFdDZnV2ekp0L0N3aE9mcmRuckMvQzBKWm0vcHZ2czVvOUdpMXJkUHJibjJN?=
 =?utf-8?B?Y3dhS29qTGx1ZlpUM0lnQXVlRnllZ05ob0d5TVFjWkRvalBXZFpqc3huQnVy?=
 =?utf-8?B?WGxJYzM5MWUxaUxoK3REU2Y1TUNvR09iTnRKZVMycExTUmJCd0EzblJiSUFv?=
 =?utf-8?B?dThFWG0wY202RGV3dTNGVll2OFQ1eDhMaHZORjZVTml5aitxTHNvSHZMbXVI?=
 =?utf-8?B?WGkzdFpVYitZVVNsSVhNTFF4aUMwVFhsTUEyaUQwSXc4RFlpd2NiSThKMlV5?=
 =?utf-8?B?WE9PajBtdStCZWlPeHRtMXBuaVpzY0ptYkhyUXZkYVREL1A4aDIvRUo2cHo4?=
 =?utf-8?B?VERWQ3Z0Z3VPMGwxRSsveVZxWnZoNW13QU1kTlI1RURkQjNyb0dkYzZHMDNl?=
 =?utf-8?B?d1Ixa1lKTGZDUDJmNk0vbEl1K3pIbTRkV21PVSt2RXRsMmZBZE9WV1Q3dEhz?=
 =?utf-8?B?UHhIMHBxd1dBWGJuaTR5WnpIQ2pobDJLcDVmSnNWenVTMjlLS1dFMkVQZW4y?=
 =?utf-8?B?cEN4UW94RUlNc0VFbFJVRWxXT2h2cVlUVlhjL1QvSEJXMk5MRmhBWnRtbFdG?=
 =?utf-8?B?dXlGWGhlcGNVakptR3VUbHRMa1J4WHRLZXRScEJVZzQ0WUsrVFY1alkwL0V4?=
 =?utf-8?B?MWt1L21HVU9IVWxFMzE1YVo4TlBDM2trTS83NTc5NU9NbTNZYkc3Snl2eFZT?=
 =?utf-8?B?dThQeDY0TmxDR3RLRnlSZTlzck1zYUxaRHloRXBQakdWSEdjb2ZVQ1pnZnNr?=
 =?utf-8?B?cXlMeHMyeERwUm5ISjFGVU84MUQ5aWg0ZEsyTEpnRGtYN24zVXpkWkhnR1Z4?=
 =?utf-8?B?VzBCWmxoM0ZpL1IycVdnUTVjZ09JQ2lEb3dpOTlMMEx4V1ZZbEJ2UFNPbHUw?=
 =?utf-8?B?UHJEMFBRYXpXNUY3YnA0Ulh5dHJNUFFzZ1BaZXhkZXBQeEQ1Z2NMMkoySzI5?=
 =?utf-8?B?RkpjSEtCa2tNazlvS08yc3QyZVU0NWdpVlQ4Y1hHemRNL3VISC9VTjE5bXRi?=
 =?utf-8?B?cEdwdmtvZ1dWNzFtOVVueEdXdE5BYUtCMXA0Ui9hWHo3UDJwV2JRQzZVZS9y?=
 =?utf-8?B?N0p3MktoQURtc2kyMnhDcExJTFJkRnkwdlpRdDh4QS94andGWEdPb0lNd2dP?=
 =?utf-8?B?bnlvaVNzMWs0eWExNDFyZWE1L3ZMRmhkdnYveEhtTElzMVh3QzhxNnd4SGx6?=
 =?utf-8?B?VEZsWkMzSEhMbGVRTkI2eFpMeW8xRC90K3FIMDNSdVRncHdoZG45NTdMdXdk?=
 =?utf-8?B?QkZGZzAyNUpsVlJzc1pjSGFUNmxacXdwM1RORi9MSStJZ0Y2dTBGemlGaExO?=
 =?utf-8?B?NlB2dStiSVlqalpFZGVyVkJqQkZoQzNSUk1yTGlRNG83TmFzNHVRM0JjSEFn?=
 =?utf-8?B?ZUt0cmZmcU9CWVFqR3hVOHdud2lTb1ExS1JidWRhMTR6alNMTFo0bWZ4OVRF?=
 =?utf-8?B?dHFSOFNwTXFMV3RyME9aSUZIMDlZdlBMTDlSQWJqeWhCdElXMURXK2Z6Vkcx?=
 =?utf-8?B?WWhjdTUzbUZxUjlyYzZjeW4wOWxZdHEzeFVOVXZBZ29RNVkrYWNOVllxSzdE?=
 =?utf-8?B?ZjJDa3RsYzZuMzJCYmo0KzZQMWczK2pnM1JkQWdvb0NvcE1NS0pSZENVbkJw?=
 =?utf-8?B?RUlDV0RaRTBGYlpBcS9nZ2RncVdlVzBXS1JMUXFNWVBtaGh0aHhXQWJQOGZH?=
 =?utf-8?B?aFFyS0RWTmpaeldTUUpraEFmSHkrVVVWcVhENE11Zm44VGVROWZwU09wSzc3?=
 =?utf-8?B?bkNpOEIzakcwbU5hYnpYVHFYb2VNTk9TZFd0eVJBcjlHRHh4STJXejNRWW5E?=
 =?utf-8?B?RlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 76db1cc1-8c09-4603-a8d1-08dbfc26f569
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 22:00:46.3169
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hc1PhlBSXvHGJJXpB4DzRS/WSaCDTOgLOOLLt39dDuvyIrUSMyod8kD2BDKxfQZX1ZoK2vae35PjMHlL5NEyalAI/yacth+Gh4yygThH99c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6131
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 13 Dec 2023 14:01:03 -0800 (PST)

Hi Ilpo,

On 12/11/2023 4:18 AM, Ilpo Järvinen wrote:
> "L2"/"L3" conversion to integer is embedded into get_cache_size()
> which prevents reuse.
> 
> Create a helper for the cache string to integer conversion to make
> it reusable.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette