Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <19d47295-35af-4046-963f-efb7838c3eaf@intel.com>
Date:   Wed, 13 Dec 2023 14:00:29 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 25/29] selftests/resctrl: Introduce generalized test
 framework
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231211121826.14392-1-ilpo.jarvinen@linux.intel.com>
 <20231211121826.14392-26-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231211121826.14392-26-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWVVQ0pkSWtXR3hOMWdLNW9XdWpHVzVVQ1BNcHl2V2NQMit6VEpnbjQyeHhC?=
 =?utf-8?B?VkVJOWliL2JtMDVhY3gwa1pBVzN2dGN4cytiakxXRHljMWY0ZUFtdnNmSk5U?=
 =?utf-8?B?QmJjcHEvYk0yNFVMcEs2UVdldDdWak0ramtiZmZqQm8vVlNjZEQyS051YjNi?=
 =?utf-8?B?WUcvK1BpV3RUdThTNEhRdm1LWjBIZWZ5c1JPdjhLL0lwWEtwMXJEN0J2dWMv?=
 =?utf-8?B?MEFwQnhUU1lwMGh6UzNUSVh2eVNjaWpVSElFaGxkai9hVHBjY2pEaTV4QWVl?=
 =?utf-8?B?ZktHQm44eEx3ODZPYnlQYW5KY3FJN0IxSjRMMmtja3dJd3F2SEk0eXpDRGhs?=
 =?utf-8?B?WmFNUm9KMU1tRDFPZiszQmU3c0VjTDJLRys4VWhlcEVsNDhSaCtkYTlZVGM1?=
 =?utf-8?B?U3N1K2k0bFZsdkxHM1BoZ3B4MnI0dnNDakhUZktlczlCVTZBN1ZyaWVFc3Y2?=
 =?utf-8?B?aG5rYTdjZVcrUWZCaDhyazRKbTRLeHBYRmFMQnNmcjZKMitTVUl4MkZ0cEVp?=
 =?utf-8?B?RGgzVkcyRlkyVVordERkalNTUnRTQ09tOUwzK09aSVIvUjAwREh1VjRTQ2RF?=
 =?utf-8?B?MGhFK2xWSXV5M01GY29mSUJJSVltU1N1dURYRXN0UURPcS9TY3A0cG1LS2Ux?=
 =?utf-8?B?NFFteDNUNUx6R0xJY0g5Q09HMmw3bWt0R3QvdURrN285WnZpTmVmNys5MFpO?=
 =?utf-8?B?UHFLRVFrdzhJcEc0cHFPY2w1Rlgwc2U5cWJpUE44YUZudFk3VHF5UHhtNUVq?=
 =?utf-8?B?NHlCcWFBdTFjVC9oZjdtdkg4SHdsdVpaQXVjSTUvR0lBNVN0Z2tZOWJkdTFV?=
 =?utf-8?B?N1NScXFhVWZiYnk4U3pubHBCcjV2aFhFZnNZTllxejd2VjJaMENCTG45b3Iz?=
 =?utf-8?B?YzBxSzNiYnlML1FOOW1NUnBTUEZTd1pNQ2oreUY3M1cwQ202U25KdFAxWGND?=
 =?utf-8?B?UTlTOHI5K0JPUXkxSEtvaEU2clpaY2l3V1ZVdVpjeVVkaktGU0pCbWE2T2tl?=
 =?utf-8?B?YmNibFVGaklwYlI2WkNobmlwTzNGcWY4RW1QTGlpeElyNHZLYVlVeVhLclN6?=
 =?utf-8?B?WUI2VUYvUThYdWgxYjgwak1EbDIyZjFiSk12WENxVmZXSis4WFgvMm85VU1Y?=
 =?utf-8?B?U0NMU1ZUdGhiVXNWR2ZjNGNnUzZBRmNHcTVSSmE3TVlxdjZrd3NFWXU4eVhz?=
 =?utf-8?B?YURKYUZoTy9oSExDK0JmVTcza3E2bG1YbjdLOFUvTFFpRkZoNlhpemJ4T2pB?=
 =?utf-8?B?SitJc2NnSnJESXNqenZCcHRmS0NaSHlodlJrSWVmUUlEK0NWOG5tUHF2Wi9B?=
 =?utf-8?B?eUdhbDVsY3NxQkhaYmxDVCszTHJsQ1FMbHdISHhnaFJzMy84OHBoZ0k1azJB?=
 =?utf-8?B?bUFpcms0cFQ3a0sySktIdWVncDRKS1hDRGdVbHlrZWtORXBNalNqMytTbHZG?=
 =?utf-8?B?YVdZVkZleElJcGN5TFVUeUI1OTEvK01NU0VCaTF3TWhGcEFZbjB5YVpNMmt2?=
 =?utf-8?B?TXZramI5cWRQbEQyREhaazRVMk9VdnAzV3RweUlGT1I0bHRJWUxXSlhFTHZi?=
 =?utf-8?B?K1hiUkdXV3NKcE5XSDlTRzRnVWwwckl4c1BzemFpamZGaHBJNGtpYzFXeUov?=
 =?utf-8?B?S1UxOHp5bmpreld1ZExuSWFHTmZGcE1YdUlmdW1rWmlnV3lsaUdUb2EyNlJj?=
 =?utf-8?B?R0tLcVBNMzBiS2kwYmVGZjcwZEZBUklZdDF4L2ZBN0FLZEFEMUtZK1plbTdk?=
 =?utf-8?B?Ykh5VjJ5VWlOeWhMZ25mQmZNU2lxLzc2Z0lhaGVzQSttSnVSY0xwVXZ5U09s?=
 =?utf-8?B?c2hIQ3FkaGtseWd3QURKUW9OMnRvNVFrOVRiSUZPYUJYbm00Q1pHbjRzOHRI?=
 =?utf-8?B?dE53UVduMFY1SmZWRnpSNTV1eXYyd1VVd2lPMGx1Zy9qTU5CemdGUE9ML1R0?=
 =?utf-8?B?eXA5ZnZsb01Id3NkUXFuVGM3UDltR0NWSEpydFhqK0x5Y2NMbllYVWdCVUhn?=
 =?utf-8?B?ZmphdU1ucnpxbSs3OWw4ZklRNUwxMm9oK2E2cERWVkpuTXY2ZklYZ3BpZkk0?=
 =?utf-8?B?SjJKblBwYjBLcUQ1czkyZFIxdWdsd0txTmtsWTU4cHg2cDQ2MGoxSURkOTNa?=
 =?utf-8?B?NWhjbnpYN25OTDhTRGUzNVVxOENMZUFuemdVcUQ0UEZZVnk5emwyWjc5L2lp?=
 =?utf-8?B?MGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a0b5d102-13d6-42b1-1294-08dbfc26ebf8
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 22:00:30.3618
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L4zJHoB2dQIDVDG5D4IL54K/QG9422C2cJEyyrvJkf9ANsEkAKsiqSZPcBFMOcpRuiSBIBA5tk6TuFUVTHCeyPyzk/u93Joapw8GvBqC3vQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6131
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 13 Dec 2023 14:01:08 -0800 (PST)

Hi Ilpo,

On 12/11/2023 4:18 AM, Ilpo Järvinen wrote:
> Each test currently has a "run test" function in per test file and
> another resctrl_tests.c. The functions in resctrl_tests.c are almost
> identical.
> 
> Generalize the one in resctrl_tests.c such that it can be shared
> between all of the tests. It makes adding new tests easier and removes
> the per test if () forests.
> 
> Also add comment to CPU vendor IDs that they must be defined as bits
> for a bitmask.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette