Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Wed, 13 Dec 2023 14:28:03 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Ira Weiny <ira.weiny@intel.com>
CC:     Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Shiju Jose <shiju.jose@huawei.com>,
        Yazen Ghannam <yazen.ghannam@amd.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Dave Jiang <dave.jiang@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ard Biesheuvel <ardb@kernel.org>, <linux-efi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH RFC v4 5/6] firmware/efi: Process CXL Component Events
Message-ID: <657a2ff3bcc0b_25c9c7294ab@iweiny-mobl.notmuch>
References: <20230601-cxl-cper-v4-0-47bb901f135e@intel.com>
 <20230601-cxl-cper-v4-5-47bb901f135e@intel.com>
 <7ec6d2af-c860-9b05-7eaf-c82f50f8e66e@amd.com>
 <65674a71ef4d0_a1b25294e4@iweiny-mobl.notmuch>
 <20231213171351.00004579@Huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231213171351.00004579@Huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fwWjiUfk6UVshTWJ9RpNZJmnYgF5kd++vyqkTMDrTgf93xDeP9UAkPLw62uB?=
 =?us-ascii?Q?UliXldWz5upmmXRNF/wuS46ww35T0yE0sDOlIKkMTC92VtyTEDcCYIQ4/8o7?=
 =?us-ascii?Q?vR5jGK1bKsbDutkS7iGD5CI8SjjjwMPJuPbL8eWOacXKeT/eb/O8+iR9iYXO?=
 =?us-ascii?Q?YlQynnX+DiX17vf+FdaQU/XfPYOFqVDJWAFyo5v+7w7HIAJNs06L3VNLSm6x?=
 =?us-ascii?Q?idWUtsqaid72Cl/z38+2DlzVYbCUnAT6/VR03Xrm0iSYUYpHsTceummbhgLs?=
 =?us-ascii?Q?s4uG8zwSCkls8a/HQmFHw58gmQCufbqLqByC4FMuTHijtgMxRiM8LybHwmES?=
 =?us-ascii?Q?POvtpch0XaSQSUwNEW0CTS2ttbPeQOV8nUsiJdWKFbtogke+sgb215okFbVU?=
 =?us-ascii?Q?1moywFwxXMynaNR74Y9ZKm6YYqapvfkWe35GKHUsnLeD6uF+2asR6tamVIaQ?=
 =?us-ascii?Q?MVS7LsgGK//Wv4HxuHdLzfuqyRL5W1LtT99WrU5W1TpR8Cwe/V6X6924btKk?=
 =?us-ascii?Q?M63i87IQOTESYP4mGlTUrkpvnQKy0YIbHZlE8OfjV67OpEoCgsn5/XoUeo9q?=
 =?us-ascii?Q?VitvTMFkhwEkFZDjrkk5CUONXtvfnJA/MUfuy5LwB5F/VdRSpXVhjNKKTicV?=
 =?us-ascii?Q?aKPVEVsI/PABZKSCTrpc48zKVTdTFnsIBYoh//pSsLFEwMiaINZjX+vn12q4?=
 =?us-ascii?Q?pnJxHZGcEM0ikVaEfE0uGhBk0C7PuDiV99fkc/csur56P1fh86sH0bC+eEYy?=
 =?us-ascii?Q?vwW7a79GjtOU+CxeC8cLmbt+Tj8V8fcKlEvYwvOIwRG26CThFJhnGCNFNkyv?=
 =?us-ascii?Q?BZZiaPX9xUR76ddUMlCz8Z9RnliKZrtKUAmzt8bTArl7EJz3zckUeCWohyOG?=
 =?us-ascii?Q?zq6XdRKAN8wZrvKLj1KsmcET1EFhK6/5u8K44MKHdz/perq4xAPtgbsGS8zB?=
 =?us-ascii?Q?wAv9rlDqpAg2NxEXhV2/6rDrLTlY6eiBCzj5K16PIxAb22ZTIPdDXFgz1Ur4?=
 =?us-ascii?Q?4kHqpRAa7IIKj9YuPQqmTdbVj3yZQZ/isSPquYAz4/Sc9DzWUjijEoSfuFbe?=
 =?us-ascii?Q?GXPf6uAvbVN1LGn3ugRJpn7HyX3BhfP15VesZN8tz/oYThrxRoYkS7WjMApc?=
 =?us-ascii?Q?DVfzQAgmUgYaM75rQM2OoOtYQ1ZNjGdHNnnWl9fsfe2GhdcX0BIW9Zxfgotz?=
 =?us-ascii?Q?QeaJTt//OZMtdgHCDvKRVX4ghGmt29+2+5nclFT6oBlGP4329taBOcKWW4tN?=
 =?us-ascii?Q?HwPquvR15QJyYMLNNxjHyPWRIXOBUrmX/8zVpY93GAswp3sSo5ledZG5CujU?=
 =?us-ascii?Q?QdP+hKUzIyHlReKi+aVIbOWHr5Pqsgz36Mf2fz+Ec4dlM47aikZ0NarhuVTO?=
 =?us-ascii?Q?wiG13k/ehAftC7GJ17N6XSCLkq3vB1tVQqUSETWBUDMLYQg7hSu+1zpdsOq4?=
 =?us-ascii?Q?84DzN1kDU48Hh/MVCp55OyKaSQRFWA6rlxGgbE6gCZybPRAQz18RKvuiDS1+?=
 =?us-ascii?Q?+pRQWma674Qvh+sj6g88OdDuRO32LtCydd3jmuMzMp7oRfysR/9AQQUGU3wb?=
 =?us-ascii?Q?nrAl5AHJtUVPFPcXFc5fNv9cS0/sOiI4CKhwPhfv?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c1a3ace-f9cd-4b3b-9a36-08dbfc2ac7b8
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 22:28:07.4101
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oeJij8eccGH5qdukUWmMa3ooGu2WrunQtKz0Wp8XGTUJ1NonKiOKrwqI/Ge3GEknFgvq2FqgBj5MXCF44oJ8lQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7687
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 13 Dec 2023 14:28:22 -0800 (PST)

Jonathan Cameron wrote:
> On Wed, 29 Nov 2023 06:28:01 -0800
> Ira Weiny <ira.weiny@intel.com> wrote:
> 

[snip]

> > > __packed attribute just for cper_cxl_event_rec still fails to properly 
> > > align structure elements. Looks like, __packed attribute is needed for 
> > > all structs (cper_cxl_event_devid and cper_cxl_event_sn) inside 
> > > cper_cxl_event_rec.
> > > 
> > > Seems easier to use global pragma instead.. I could test and obtain the 
> > > output as expected using pragma..  
> > 
> > I did not know that was acceptable in the kernel but I see you used it in
> > cper_cxl.h before...
> > 
> > Ok I'll do that and spin again.
> > 
> > Thanks so much for testing this!  I was out last week and still don't have
> > a test environment.
> 
> Easy to hack into QEMU :)  Hmm. I have a CCIX patch set from years ago
> somewhere that does similar. Would be easy to repurposed. Looks like
> I never published them (just told people to ask if they wanted them :( ).
> 
> Anyhow, if useful I can dig them out.

If you have a branch with them with a somewhat latest qemu that could work
too.

Ira