Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <cover.1699936040.git.isaku.yamahata@intel.com>
 <1c12f378af7de16d7895f8badb18c3b1715e9271.1699936040.git.isaku.yamahata@intel.com>
 <938efd3cfcb25d828deab0cc0ba797177cc69602.camel@redhat.com> <ZXo54VNuIqbMsYv-@google.com>
In-Reply-To: <ZXo54VNuIqbMsYv-@google.com>
From:   Jim Mattson <jmattson@google.com>
Date:   Wed, 13 Dec 2023 15:18:25 -0800
Message-ID: <CALMp9eQUs44tq-3mbqGxcnXjmAx=-jHOLxmW+DuMfeVXGVSDzg@mail.gmail.com>
Subject: Re: [PATCH v2 1/3] KVM: x86: Make the hardcoded APIC bus frequency vm variable
To:     Sean Christopherson <seanjc@google.com>
Cc:     Maxim Levitsky <mlevitsk@redhat.com>, isaku.yamahata@intel.com,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        isaku.yamahata@gmail.com, Paolo Bonzini <pbonzini@redhat.com>,
        erdemaktas@google.com, Vishal Annapurve <vannapurve@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Dec 13, 2023 at 3:10=E2=80=AFPM Sean Christopherson <seanjc@google.=
com> wrote:
>
> On Thu, Dec 14, 2023, Maxim Levitsky wrote:
> > On Mon, 2023-11-13 at 20:35 -0800, isaku.yamahata@intel.com wrote:
> > > From: Isaku Yamahata <isaku.yamahata@intel.com>
> > >
> > > TDX virtualizes the advertised APIC bus frequency to be 25MHz.
> >
> > Can you explain a bit better why TDX needs this? I am not familiar
> > with TDX well enough yet to fully understand.
>
> TDX (the module/architecture) hardcodes the core crystal frequency to 25M=
hz,
> whereas KVM hardcodes the APIC bus frequency to 1Ghz.  And TDX (again, th=
e module)
> *unconditionally* enumerates CPUID 0x15 to TDX guests, i.e. _tells_ the g=
uest that
> the frequency is 25MHz regardless of what the VMM/hypervisor actually emu=
lates.
> And so the guest skips calibrating the APIC timer, which results in the g=
uest
> scheduling timer interrupts waaaaaaay too frequently, i.e. the guest ends=
 up
> gettings interrupts at 40x the rate it wants.
>
> Upstream KVM's non-TDX behavior is fine, because KVM doesn't advertise su=
pport
> for CPUID 0x15, i.e. doesn't announce to host userspace that it's safe to=
 expose
> CPUID 0x15 to the guest.  Because TDX makes exposing CPUID 0x15 mandatory=
, KVM
> needs to be taught to correctly emulate the guest's APIC bus frequency, a=
.k.a.
> the TDX guest core crystal frequency of 25Mhz.

Aside from placating a broken guest infrastructure that ignores a
17-year old contract between KVM and its guests, what are the
advantages to supporting a range of APIC bus frequencies?

> I halfheartedly floated the idea of "fixing" the TDX module/architecture =
to either
> use 1Ghz as the base frequency (off list), but it definitely isn't a hill=
 worth
> dying on since the KVM changes are relatively simple.

Not making the KVM changes is even simpler. :)