Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753959AbXLFJzs (ORCPT ); Thu, 6 Dec 2007 04:55:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752100AbXLFJzh (ORCPT ); Thu, 6 Dec 2007 04:55:37 -0500 Received: from vervifontaine.sonytel.be ([80.88.33.193]:43121 "EHLO vervifontaine.sonycom.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751270AbXLFJzg (ORCPT ); Thu, 6 Dec 2007 04:55:36 -0500 Date: Thu, 6 Dec 2007 10:55:35 +0100 (CET) From: Geert Uytterhoeven To: Yasunori Goto cc: Geoff Levand , Andrew Morton , miltonm@bga.com, clameter@sgi.com, apw@shadowen.org, linux-kernel@vger.kernel.org Subject: Re: PS3: trouble with SPARSEMEM_VMEMMAP and kexec In-Reply-To: Message-ID: References: <20071205151147.9db4640b.akpm@linux-foundation.org> <47573806.8000808@am.sony.com> <20071206142552.694B.Y-GOTO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-584337861-88997924-1196934935=:6524" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2041 Lines: 57 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---584337861-88997924-1196934935=:6524 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 6 Dec 2007, Geert Uytterhoeven wrote: > On Thu, 6 Dec 2007, Yasunori Goto wrote: > > > I'll try Milton's suggestion to pre-allocate the memory early. It seems > > > that should work as long as nothing else before the hot-plug mem is added > > > needs a large chunk. > > > > Hello. Geoff-san. Sorry for late response. > > > > Could you tell me the value of the following page_size calculation > > in vmemmap_populate()? I think this page_size may be too big value. > > > > ------ > > int __meminit vmemmap_populate(struct page *start_page, > > unsigned long nr_pages, int node) > > : > > : > > unsigned long page_size = 1 << mmu_psize_defs[mmu_linear_psize].shift; > > : > > ------- > > 24 MiB Bummer, messing up bits and MiB. 16 MiB of course. With kind regards, Geert Uytterhoeven Software Architect Sony Network and Software Technology Center Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@sonycom.com Internet: http://www.sony-europe.com/ Sony Network and Software Technology Center Europe A division of Sony Service Centre (Europe) N.V. Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium VAT BE 0413.825.160 · RPR Brussels Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619 ---584337861-88997924-1196934935=:6524-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/