Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <e40aa928-4bcd-4acd-924a-d2f154845908@vivo.com>
Date:   Thu, 14 Dec 2023 10:00:02 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V4 1/2] mm: add defines for min/max swappiness
To:     Dan Schatzberg <schatzberg.dan@gmail.com>
Cc:     Johannes Weiner <hannes@cmpxchg.org>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Yosry Ahmed <yosryahmed@google.com>, Huan Yang <link@vivo.com>,
        linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
        linux-mm@kvack.org, Tejun Heo <tj@kernel.org>,
        Zefan Li <lizefan.x@bytedance.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Michal Hocko <mhocko@kernel.org>,
        Shakeel Butt <shakeelb@google.com>,
        Muchun Song <muchun.song@linux.dev>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Hildenbrand <david@redhat.com>,
        Matthew Wilcox <willy@infradead.org>,
        Chris Li <chrisl@kernel.org>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Yue Zhao <findns94@gmail.com>, Hugh Dickins <hughd@google.com>
References: <20231213013807.897742-1-schatzberg.dan@gmail.com>
 <20231213013807.897742-2-schatzberg.dan@gmail.com>
 <86984d9b-c955-4b06-9097-2a757b1bacfe@vivo.com>
 <ZXnexTxt3JE8mEMV@dschatzberg-fedora-PF3DHTBV>
From:   Huan Yang <11133793@vivo.com>
In-Reply-To: <ZXnexTxt3JE8mEMV@dschatzberg-fedora-PF3DHTBV>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVpTNjNFWHpvbEFvVERGSGdmcW1tUGhJaW1MUHY4Qzh3TEsvWExwbkxhVUlO?=
 =?utf-8?B?dm8zRkcrTC9UV2hCNldNa0gvRzUvUGFubEdvYXVLbnBZRlQ1OU1SUkNmT3dl?=
 =?utf-8?B?Qy9WQ054WGFKWFk2OGVPOVRXclM5VHc4VTFTNkpxN3RrYUprcU94NUFQREVP?=
 =?utf-8?B?Z09iaTRyMXQwayt2WnZrU1RUOUlYN0FVbEVlMkg4cTNjdi9McUllREkzaEZX?=
 =?utf-8?B?NkZ3NHBoTjlodUpWbWJ1U1ZXTUx4SVo1QUpJMjJuelVKQlExb0lOSlVPaFk2?=
 =?utf-8?B?TVBYMTdadGxlT0hSNWxpVE1jbXB1TDZaMVNReHVYYTFyQ1F1ZHJFV2pWRURZ?=
 =?utf-8?B?S0g4Q3BLUWpuZXhBNTNlOWhMdlhGU3hNTmpDbWhHeEE0SjI0dzlIRjV2a3NQ?=
 =?utf-8?B?TW9WNlcvdGdIbnhKOTMwWWc0dGdBK3NIQXhPWGcrOGtoWkxZalh2d1hqdzRW?=
 =?utf-8?B?N2o0ZXd5Zy82Ukg5RWREZWk1ejd6N3pTNWdNSFdLQVAzT1BTMHhyOE5ZWGFO?=
 =?utf-8?B?Tm9yYUE5eWUyMEhvSzFQTFBCc0xBVTFOZHkrZXdZR2RrQnQ0eElRVmpKbHpk?=
 =?utf-8?B?RWNxTyt6ZnlYZFo5TXM0MTlVVUkxR01XL3pnYWV0UHJQSzNSNjhLa2dEb0lN?=
 =?utf-8?B?anRPMWMvTEhGcThmclM0TjRuM2xNTkxsakVnODkxNkdnUXZEYjM3SCtVRVhK?=
 =?utf-8?B?V0JaeUdhTWlyNlljam14am02Q2s3Z0pzR0NSUHM3MCtrWm02UGhzQmF1ZHRM?=
 =?utf-8?B?WGQxZU9rMkgrRU9ra2hFRitIZElsWUtkd0Erc1Y0S0lzMmhoaklyVzBZMEJY?=
 =?utf-8?B?YkkrMVNtQzNiazhGdkZFaXNMN3RTQ3FNc1FwT3A1bTdjMGdlWU51WG1OVVFQ?=
 =?utf-8?B?OVhRaWtjMXhJRXhUSDRtTUcrOVlMcm5VTXdFUnRZTHNDeUVmeFdBWitIZ0tz?=
 =?utf-8?B?V2tBRmYyaEJvQWhYczlvYk9GazZTY0kvS2lITnBNMTZ3enhoMW1LRWErOGtz?=
 =?utf-8?B?dXF0NjhXNC80b2hLajVwWk9UV0FCb1RBWDY1cFF3K0d5R0hPdklzOFJWeTcx?=
 =?utf-8?B?K1ZPeWRmRDdrWlhFL2hHaXhnckEwaXQyRHRkNEpEY3ptd2Fzdk0vZ2xWTUZM?=
 =?utf-8?B?aTgwUnI5WmdhalhtQUoyTmp1dEFWWHlqbGovRHVsbkRIU0o0TVhBN2t2QWVt?=
 =?utf-8?B?WGo5RzRkSU9RbWZGT0FZVlIyeElUMjNqQW1NWGRXS3IzYXJVZVFvL2JhTXU2?=
 =?utf-8?B?bGxnZTZZeFgyMGFZR3pseEpxaktxY1AwZHFQNllEUUd0dXVtU3grZktWd1VK?=
 =?utf-8?B?YmloSmRXZ2pEczlMZVg2QnJPa0R1SUNJRU9VZVhrankvcW9RbjVsVUF4UTNT?=
 =?utf-8?B?ajNWcE56ajhJRTBKditLajFoMUhwcXQweHBZdnMvQStHa3N1bmRtTTY3WjFF?=
 =?utf-8?B?N3Q3cXBweTFXNzlTZEhRdFFoSWVMSUNSRmdzbG9UNG5VVzN6OVM1eU5meVdW?=
 =?utf-8?B?azdDbU1UVkJoYVRveFZSNVpUdzhBVC9SL0gxS0gyV1kzdmxRa1phNlJjdXhM?=
 =?utf-8?B?RXR1VkFpNTdhYmhkZURSdktOZ09obHdRUlRSOXMweXVxYVJ1VjlwQ21TZEhn?=
 =?utf-8?B?ZHpVZEVwOE5JNzI2bHdpYlM1RjkyVnRUdWV0WHdYUUxKWFFacjM3TUxWT3NE?=
 =?utf-8?B?UUZIUVRHYXJSUDA0QUlIeWdsK3REVjVoZ25EaVIrbzBJSXFhcElIRTE0S0Z4?=
 =?utf-8?B?R3Z5djY5VGZiK2t4WmVrRTJCSEFMS3Bnb3BGNVV3dXZQblJBYVNoVmZ4L3Br?=
 =?utf-8?B?WVg5aVBES3JLT1R1alFmVjlQLy9CUDlpRXBnUlZOSkxpOVBtcllPajFFMGYz?=
 =?utf-8?B?K2x2R0t2eGhmRzVkYThXS2Q1T3gzWWhwdjJhSTkzRDBoUVNnMFBrR3IzK3A5?=
 =?utf-8?B?T0srN0w5bE05NFpQQzFEUWNJUmM4a3RuRlR4L1NCV3VQSDZNZjROeUpPZlRy?=
 =?utf-8?B?WTBhemNyQldDRkk4bzdHYU1QdG9ldzZOZUZVMTU3V3hzRENJaWNzVnlKVzB3?=
 =?utf-8?B?T0JRVU9Gd3JBZTI3aHRkWFBad3llaFVSL1NhZmJsZDBCeHFXUXBLYjZPQVB5?=
 =?utf-8?Q?kA2yxE5vZkk4LsM0CzYh2NsNW?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c17c09c-c7be-4ab9-10e8-08dbfc48673f
X-MS-Exchange-CrossTenant-AuthSource: PUZPR06MB5676.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 02:00:10.5242
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iVE252FprsM52cLzBXfYdEoTmZgJMUz2GVP3D7uqgKK+u0eGuF3n+fsXkzYB54wud7VlV+RuO31O1uPjg+smAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI6PR06MB7562
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 13 Dec 2023 18:00:33 -0800 (PST)


在 2023/12/14 0:41, Dan Schatzberg 写道:
> [Some people who received this message don't often get email from schatzberg.dan@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> On Wed, Dec 13, 2023 at 09:58:26AM +0800, Huan Yang wrote:
>> 在 2023/12/13 9:38, Dan Schatzberg 写道:
>>> [????????? schatzberg.dan@gmail.com ????????? https://aka.ms/LearnAboutSenderIdentification,????????????]
>>>
>>> We use the constants 0 and 200 in a few places in the mm code when
>>> referring to the min and max swappiness. This patch adds MIN_SWAPPINESS
>>> and MAX_SWAPPINESS #defines to improve clarity. There are no functional
>>> changes.
>>>
>>> Signed-off-by: Dan Schatzberg <schatzberg.dan@gmail.com>
>>> ---
>>>    include/linux/swap.h |  2 ++
>>>    mm/memcontrol.c      |  2 +-
>>>    mm/vmscan.c          | 10 +++++-----
>>>    3 files changed, 8 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/include/linux/swap.h b/include/linux/swap.h
>>> index f6dd6575b905..e2ab76c25b4a 100644
>>> --- a/include/linux/swap.h
>>> +++ b/include/linux/swap.h
>>> @@ -407,6 +407,8 @@ extern unsigned long try_to_free_pages(struct zonelist *zonelist, int order,
>>>
>>>    #define MEMCG_RECLAIM_MAY_SWAP (1 << 1)
>>>    #define MEMCG_RECLAIM_PROACTIVE (1 << 2)
>>> +#define MIN_SWAPPINESS 0
>>> +#define MAX_SWAPPINESS 200
>> Do MAX_SWAPPINESS apply for all swapppiness? If so, maybe better change
>> swappiness sysctl define:
>> ```
>> sysctl.c:
>>
>> {
>>          .procname    = "swappiness",
>>          .data        = &vm_swappiness,
>>          .maxlen        = sizeof(vm_swappiness),
>>          .mode        = 0644,
>>          .proc_handler    = proc_dointvec_minmax,
>>          .extra1        = SYSCTL_ZERO,
>>          .extra2        = SYSCTL_TWO_HUNDRED,
>>      },
>>
>> ```
>>
>> Here hard code swappiness in [0, 200], and now add a new define.
> Yes, MAX_SWAPPINESS is a hard limit. I'm not sure what you're
> proposing here - the SYSCTL_ZERO and SYSCTL_TWO_HUNDRED values are a
I mean, MAX_SWAPPINESS and SYSCTL_TWO_HUNDRED  all limit swappiness,
but  are different definitions.

If swappiness change 200 into 400, you need to change here extra2 and your
MAX_SWAPPINESS. It's wierd.
> little different than the defines I added. I think most of the value
> is just consistently using the defines in the core mm code.
>
>> And many other code hard reference 200 into max value of swappiness, like:
>>
>> ```
>> memcontrol.c:
>> static int mem_cgroup_swappiness_write(struct cgroup_subsys_state *css,
>>                         struct cftype *cft, u64 val)
>> {
>>      struct mem_cgroup *memcg = mem_cgroup_from_css(css);
>>
>>      if (val > 200)
>>          return -EINVAL;
>>
>>      if (!mem_cgroup_is_root(memcg))
>>          memcg->swappiness = val;
>>      else
>>          vm_swappiness = val;
>>
>>      return 0;
>> }
> This one is already fixed in my patch.