Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5727117rdb; Wed, 13 Dec 2023 18:45:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IFH3lECcYguwu+hWEg4fL8SEsT6UQ19l3mWZ3dh1+Jh9FF+eCubvkfetTk/WmEX+ukr47Fn X-Received: by 2002:a05:6358:7e0e:b0:170:2539:efa6 with SMTP id o14-20020a0563587e0e00b001702539efa6mr10849242rwm.27.1702521906722; Wed, 13 Dec 2023 18:45:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702521906; cv=none; d=google.com; s=arc-20160816; b=WDjpkvUmqk5QE0CX97iVyR4pawD/tWtX1i2obCeSiL43IklZfEUJJqSZXpcSAj+YrZ M4FCb3DoWOTGrIuul//APpje4Q0UDqyuqWOarlzef+lEvWhH4iCBjROyMPYnrHhOOJfd jSXV6HG6CbmEbfNQ2H77DEZJwaJyZawXIG1HThwXoIpkeURrQJ0omSj0ziGkBPR7dx0U B2ReA/Y7XayjqCrLhpsdzf1VqzFw19b0px2ef5C06UbXQL5zxZRKE+jNKuq4o7kScnYV az/a2nQ3ScFre67km32j+qAu5tMNSvjvNAj3L7JhbH3H7Bra+di/tASZ/mfAwTl7l0zN B6sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id; bh=UIInUdfdVn40maxcu6EJC9GTr8Zfn6G6dPO9NnxxcJ0=; fh=yrVbhNl8ypGYygIYdZN9UJUgpmQ9BPFb3sl6v7qr+0Q=; b=xwLfYn56VTx9ie8h+rtAgry+k+kwpKax/rJftiKm10oVJ8QA9z/srCu6K+2f1zr/16 v8k4A0Hh0isTzXgik5meKflprLLtyp/b1+xR9YI7MSMGICYq+d6umABm40+aPOedzsWw FOalfO3ohj6G+yyH6QaCsLpXkwmEIDCtjVnLYOOdCYdIFSgl+3YmdezpC+SJNj4q6KGW 9SqcBO8h4xhru3hBuhifSgYmScXnmme8oWsaW3yVSNyN+zSv+3QMROP0ep4eDvdoiP/r O0o0CepULySnrvF6Wi0fSaUt9XCWPBIT0m95/BQe1l304uuz9jDCUzc4cl3xnfvaKGOi 180A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id b12-20020a6541cc000000b005c1cd1ba05csi10637234pgq.240.2023.12.13.18.45.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 18:45:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 36ACC80BFED7; Wed, 13 Dec 2023 18:45:03 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229725AbjLNCos (ORCPT + 99 others); Wed, 13 Dec 2023 21:44:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229525AbjLNCor (ORCPT ); Wed, 13 Dec 2023 21:44:47 -0500 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8BC1BD; Wed, 13 Dec 2023 18:44:51 -0800 (PST) X-UUID: 5c39719a134f4eef9e0ffa98abcdc5f6-20231214 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.33,REQID:6d9f5f62-07da-4d5b-a2a1-77fc2a26c4b6,IP:5,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:-10 X-CID-INFO: VERSION:1.1.33,REQID:6d9f5f62-07da-4d5b-a2a1-77fc2a26c4b6,IP:5,URL :0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:-10 X-CID-META: VersionHash:364b77b,CLOUDID:91082d61-c89d-4129-91cb-8ebfae4653fc,B ulkID:231214104438TKVN4X1A,BulkQuantity:0,Recheck:0,SF:17|19|44|64|66|24|1 02,TC:nil,Content:0,EDM:-3,IP:-2,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,CO L:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_FSD,TF_CID_SPAM_FSI,TF_CID_SPAM_SNR,TF_CID_SPAM_FAS X-UUID: 5c39719a134f4eef9e0ffa98abcdc5f6-20231214 X-User: chentao@kylinos.cn Received: from [172.20.15.254] [(116.128.244.169)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 238258755; Thu, 14 Dec 2023 10:44:37 +0800 Message-ID: <9250b0e9-360d-447d-b4bf-30e4bc4f697c@kylinos.cn> Date: Thu, 14 Dec 2023 10:44:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] igb: Add null pointer check to igb_set_fw_version To: Jakub Kicinski Cc: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, jacob.e.keller@intel.com, przemyslaw.kitszel@intel.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kunwu Chan References: <20231211031336.235634-1-chentao@kylinos.cn> <20231212132637.1b0fb8aa@kernel.org> Content-Language: en-US From: Kunwu Chan In-Reply-To: <20231212132637.1b0fb8aa@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 13 Dec 2023 18:45:03 -0800 (PST) Thanks for your reply. I'll try to use snprintf in v2 patch. On 2023/12/13 05:26, Jakub Kicinski wrote: > On Mon, 11 Dec 2023 11:13:36 +0800 Kunwu Chan wrote: >> kasprintf() returns a pointer to dynamically allocated memory >> which can be NULL upon failure. >> >> Fixes: 1978d3ead82c ("intel: fix string truncation warnings") >> Cc: Kunwu Chan >> Signed-off-by: Kunwu Chan > > The allocation is rather pointless here. > Can you convert this code to use snprintf() instead?