Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
To:     Justin Stitt <justinstitt@google.com>
Cc:     Hannes Reinecke <hare@suse.de>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Bart Van Assche <bvanassche@acm.org>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] scsi: fcoe: use sysfs_match_string over fcoe_parse_mode
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1le9xh3e1.fsf@ca-mkp.ca.oracle.com>
References: <20231212-strncpy-drivers-scsi-fcoe-fcoe_sysfs-c-v2-1-1f2d6b2fc409@google.com>
Date:   Wed, 13 Dec 2023 22:25:17 -0500
In-Reply-To: <20231212-strncpy-drivers-scsi-fcoe-fcoe_sysfs-c-v2-1-1f2d6b2fc409@google.com>
        (Justin Stitt's message of "Tue, 12 Dec 2023 23:19:06 +0000")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vX/lR487xlpPFATHmgsV0sy3bSHMuWXqnyMl3tG/S8ov9NLvXGDdq+Ya/cgZ?=
 =?us-ascii?Q?8TfpwQa/0W3y7dPFW2ffyPlRqo1+06yUYZVCmqQVXCDWXfs6fLuhyf3NfwWz?=
 =?us-ascii?Q?F8//tjOaKONCMkxQJPmdOOuB4WiTmbLnPmIMNyGR9h8sx7vYmUtfyuoh58yM?=
 =?us-ascii?Q?11e3/vU7o3R4RcuL10qaY/2aIs4nMZIKsh5uyP0MIUOgcw9ajbky8rmybjGR?=
 =?us-ascii?Q?6bAouGdD5KAqU/Jk47pqKluHYENjPRS/sfwQ3qZWGphNvW7YRXb5L6DOK2cD?=
 =?us-ascii?Q?jzuY9kYKUC/m65DBToV2BI0MRw+PTPHyA7rn/OPP/RakMPjindvo6M+v+xt+?=
 =?us-ascii?Q?WKYMsBfR4sddUgN/7xwnuP59nNkbticN8DIlGNLetdGMom16B41Enxzb/GLH?=
 =?us-ascii?Q?ylZvZDfZWstLJ6rXBBbgE1LVQpV7MbO0I/2zzT/t6A1yix3U+Q+3paeqJM7D?=
 =?us-ascii?Q?/58XofvuifCLi3320zFLKLCEf9j0Q6wcqqiTjIz0ZeNKARDueurvWn6mU/7e?=
 =?us-ascii?Q?gw3RaneeJrT2H24SwRg51aT6+gGai1OtBDFuOA6GqdWqQxU5X+ZSQOZikem2?=
 =?us-ascii?Q?6yWbO6mezNeQaSlyMnkhh+YKZXzApbyT3lq7ymiSP02IiLNLpp+WIajio0Cp?=
 =?us-ascii?Q?wJKuMSqH1grHUCk8ohAEaZBhYqJ7mQgmR8NtlkXXxCuACCiZYT5CHgE/wd6E?=
 =?us-ascii?Q?tZS7cN2xRHudO04GZFA2ZRWHoZ8+1XFJ1jP8AzP2lAZe8ahBwnb7Q4cuwRi1?=
 =?us-ascii?Q?+epWeSSCqDP/fEvP0KzXkj6nFOVIdnxEoR1vbgJfQEYaIfQ+dH85paxyBLIV?=
 =?us-ascii?Q?yu0BVrzhKbUjda0ezBoH+Ht/R+dlh71w3B3qsI0qNdcpW4AREIGsb0K9/EYY?=
 =?us-ascii?Q?rKLCurXfucexxm82ypvC8OP+Cat8XNuMI/6+RruRPv9eiVleyiI5FxYUfxhk?=
 =?us-ascii?Q?R8Mw8NtMPc35yFLQaJTrlKYxqgwe8TonSqWhh7OQqC01qqAkWChdDochK/oc?=
 =?us-ascii?Q?PsJONfzZplAbM/g/Cu7aeiO3hoMRdVDbekJ/XKHAwvkBsvEzFBBHOTB9vwCU?=
 =?us-ascii?Q?SuxE9n7K1RE+ZA5Obzc4VOYBZCiitAixWmkKB9CJe/b0CW6jUupqi6zu7ICw?=
 =?us-ascii?Q?rCReLNBnrD3UEIa9Jer0jyn0Cc0xyHk9wgO9648A/NH/0VdHO00FqmjjCrHL?=
 =?us-ascii?Q?/iTaUcyDTs6AEGE6YQCubHvHoEKlKXQhshnG9v4Pi/etF/Zp2HoGmu2ROK0c?=
 =?us-ascii?Q?yGhnwhkDna5SaVpF01xFZM0C5yfLjXQmVC72z8AUkDlPuM9mjHqa9mkehBGm?=
 =?us-ascii?Q?VHmeQFKQuIVv+GGoVCp5iNh3rpqb+EoWF+d+8RHOarn2k6hCeZ6Ib0HV2Mto?=
 =?us-ascii?Q?uS8WE4HMAV3KCydvqdJpQDrNCc9rqczh1/t5ZmmesL0XgS+V8oPOCKiyyVO0?=
 =?us-ascii?Q?vZSEpSPDqjTL5yPeNpGhz+y1ht2ow9CFdXxKxtcMTH8t/7l5FGlr2lmtH4a3?=
 =?us-ascii?Q?pGnjJxQG6+y5p0oNFWsUDv0tDx6tJ/k0VeXdUnh/z7qSc1PIYtpcqepZnduc?=
 =?us-ascii?Q?oHeraxMUINNE7LOiToUq9LrhS9kmkU6sSIxHx0TFE4a10wuyExdyjEjTd2di?=
 =?us-ascii?Q?Fw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: IM3fwxKmOQyUJKP3YNs+Y31IYe9CSAJU3MPxumn2XqGrWEC+znpB0tipI9CmGWi8P8bOFCDjkBC/30ZqszQHO6iZZWlKos1eEyxDZnd7c3MUbNrJCoCk8BZCVtw+9x+YmS+JsKy1qHuucuA/EON1frMRnXMeIie1NfkfRstFtEHBnIbbNGvleyM4aeZEPyt8wd8Pv9sOXvpadD8eLeKPcTVJJnbMXUdFMBFuc4Hl+PkCuN+w8/566qiuJvpBJz4BnGRuVc6MS9WRNpiH3hF/cgt7PYDTtx4Gd6qSB0YOgvNZ/9gTZSZlz/8NUAKegf9Kf8yDUYwW9AaxiIp8ycH5u206Em2ZyJ+IHmxQu0XObBtkNEA7lHxoQRDVL+51Btv7yzdd3WQTHhHbB5xzIM7cvMJE2gFssiDZXAMKkqkYpU0OkdZxLRDYMG8auhNynF7dQcteF6hh2TV2aVRc7kfK0tm7c8cNYLpgx+SivKGCoflRkI10YjgRCjsOzLdCeLrmXEtBgMTzzE/7HoxAI1EonoeS/ftmgnoj5u4bZM0hkQY7bxAQ/zCS9Cx4Dro9tjBSudjkY2eDrxQF0weRTwfgN0WytHv4NoAEQyR5+hVZ02w=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9fb6761e-a7a0-48f3-cad7-08dbfc544ce9
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 03:25:20.2598
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NFt3EjYA7jdl3p66dMjsc4UNFhSoZlCeZR/Vyz0rnSu9nIitHQV1G4i4U3mvUhmie9Zvi2JsXxVnhf7d79XmcttDKf5IV20u68S6xNbgZvQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB5685
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-13_16,2023-12-13_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 spamscore=0
 malwarescore=0 mlxscore=0 mlxlogscore=942 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2312140017
X-Proofpoint-ORIG-GUID: XY1RNJ6exhIK5ACg3oscf2Bqjd8EquC8
X-Proofpoint-GUID: XY1RNJ6exhIK5ACg3oscf2Bqjd8EquC8
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 13 Dec 2023 19:25:55 -0800 (PST)


Justin,

> Instead of copying @buf into a new buffer and carefully managing its
> newline/null-terminating status, we can just use sysfs_match_string()
> as it uses sysfs_streq() internally which handles newline/null-term:

Applied to 6.8/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering