Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5757677rdb; Wed, 13 Dec 2023 20:29:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IGDmck6IiNkzevjNHjl669t0iaIgqccYliBnW2rUSgEqhTSPFuw/nnSGDbOMBT6qfmSwa3W X-Received: by 2002:a17:90a:e616:b0:28b:5f2:df64 with SMTP id j22-20020a17090ae61600b0028b05f2df64mr378109pjy.28.1702528192435; Wed, 13 Dec 2023 20:29:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702528192; cv=none; d=google.com; s=arc-20160816; b=H9K+eky0+MwwUWbT4LXSuDn2fsENxGudv3Tr7Lb0ixryi0PlzjYO+SYrwD8wMO/CfA BIde39Sl4VdFYoprrx+tJDlS/BOCGI/LTeArHpAfeTYPbuKi0H10hQ3HST3QxEfKDx2l dJ1runZBtDrvZr2vpsyDofP/S/CpfZYdk4o07zI6QuNsJmzPhDsR0OaaTTX/Pe52wBbN KaR/du/wGblHtUVuP4HMF++0bUCdfTft28927je+CDHnhjSnCPvj9zAPxUZtCUwjWzH4 +OC2G20owUXp8ak87lA5aEoHwfZ02WEe2YjRdWzdb2r4JE+8jAZlg8rkkxNMuMyxzp8K NMYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qLo4F9bKbXaifxLi8iqNoDBZ23Xqd57qPgu1xnIoFao=; fh=9/50dVd27lJH900ht8cnCI6lC1BW6F0/Sj/PdwI8nyk=; b=nIZjjXYnrIoAa6X3cZN4UCi7UNQxoyBnee2M6SChQmiOl+0iQrmUt7txz0vyd1nYyc KgSssaeJ10fmbQEJBsViumgKcofixHyqh9tFdfYBDO5qkVxDp7wbSY1RBi8iPD61aMOe P8ubEfcB8+0GmTHUwlMiMGvvF8EuiQUuBv0u9rqmoD6vhFbfM9k3fRyGNAsFisEhkdp8 cueuqdg1+tryLIa15fllbfONnMTTtPS/ZOHXBasbazTkOPdiWVYpqdOjEAmhjVpZQxIB mwnt9gZ2tgvS5oxkE+JYIePZubqoNXn2RjOtA+cm39+BwiSTebd8QUblAtKQ2ydo28fQ izxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=SYu4gdI1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id t9-20020a170902e84900b001d09711b7b7si10769921plg.334.2023.12.13.20.29.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 20:29:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=SYu4gdI1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 53FD6802AF21; Wed, 13 Dec 2023 20:29:51 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443155AbjLNE3h (ORCPT + 99 others); Wed, 13 Dec 2023 23:29:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235192AbjLNE3a (ORCPT ); Wed, 13 Dec 2023 23:29:30 -0500 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A731C121; Wed, 13 Dec 2023 20:29:35 -0800 (PST) Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3BE0S5XO004531; Thu, 14 Dec 2023 04:29:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2023-11-20; bh=qLo4F9bKbXaifxLi8iqNoDBZ23Xqd57qPgu1xnIoFao=; b=SYu4gdI1DkZ7jRlbX6SVsyrHjavmO5ybf4eGhOU6gTszOeTgKC34ggM75lobVWyleXyG Va1rBq5O5sN34k5qs2pRDYzq4zDv16UysOkzPS7Us4tE6bYuZUca6bft2fXew9a6O91p pzWq7331etHoLBR7L630jS3OIgWV98p6yzRZzjLaIAOqx4laOOoPIje4ThBBOnWquneP hkf960bACbKdrlH/ZTguiR4tPF9PPNuL/w6T6W21FLciH7Q+bt53Nrbvm4KyBZtS2LnH dGiGYdTlVeD8sq+Pk7+8xBK2RBVJcgfDxgnTfufFWu6mnswO6VdeNYLnEOhok6ztphdx ww== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3uvg9d9x67-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Dec 2023 04:29:28 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3BE4OpQr010147; Thu, 14 Dec 2023 04:29:27 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3uvep9ev1c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Dec 2023 04:29:27 +0000 Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3BE4TQM6035965; Thu, 14 Dec 2023 04:29:26 GMT Received: from ca-mkp2.ca.oracle.com.com (mpeterse-ol9.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.251.135]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 3uvep9ev0g-2; Thu, 14 Dec 2023 04:29:26 +0000 From: "Martin K. Petersen" To: Artur Paszkiewicz , Artem Chernyshev Cc: "Martin K . Petersen" , "James E . J . Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] scsi: isci: Remove redundant check in isci_task_request_build() Date: Wed, 13 Dec 2023 23:29:07 -0500 Message-ID: <170205513100.1790765.12899400140723714931.b4-ty@oracle.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231128121159.2373975-1-artem.chernyshev@red-soft.ru> References: <20231128121159.2373975-1-artem.chernyshev@red-soft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-14_01,2023-12-13_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 spamscore=0 mlxlogscore=694 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312140024 X-Proofpoint-GUID: utGaaMgoq3zbU9IOdwtezrU9gMvlvGYS X-Proofpoint-ORIG-GUID: utGaaMgoq3zbU9IOdwtezrU9gMvlvGYS X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 13 Dec 2023 20:29:51 -0800 (PST) On Tue, 28 Nov 2023 15:11:59 +0300, Artem Chernyshev wrote: > sci_task_request_construct_ssp() have invariant return. Change > this function to void and get rid of unnecessary checks. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Applied to 6.8/scsi-queue, thanks! [1/1] scsi: isci: Remove redundant check in isci_task_request_build() https://git.kernel.org/mkp/scsi/c/25cba909ade2 -- Martin K. Petersen Oracle Linux Engineering