Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
To:     Ming Lei <ming.lei@redhat.com>
Cc:     John Garry <john.g.garry@oracle.com>, axboe@kernel.dk,
        kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
        jejb@linux.ibm.com, martin.petersen@oracle.com, djwong@kernel.org,
        viro@zeniv.linux.org.uk, brauner@kernel.org, dchinner@redhat.com,
        jack@suse.cz, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, linux-scsi@vger.kernel.org,
        jaswin@linux.ibm.com, bvanassche@acm.org,
        Himanshu Madhani <himanshu.madhani@oracle.com>
Subject: Re: [PATCH v2 01/16] block: Add atomic write operations to
 request_queue limits
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1il51flnj.fsf@ca-mkp.ca.oracle.com>
References: <20231212110844.19698-1-john.g.garry@oracle.com>
        <20231212110844.19698-2-john.g.garry@oracle.com>
        <ZXkIEnQld577uHqu@fedora>
Date:   Wed, 13 Dec 2023 23:34:37 -0500
In-Reply-To: <ZXkIEnQld577uHqu@fedora> (Ming Lei's message of "Wed, 13 Dec
        2023 09:25:38 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?du34uuax/nkU58dxoXn7xm17iJGAT8FVT1T7LgGef7BrHMJDBqhkQ+vk61cl?=
 =?us-ascii?Q?40DyChZHXTlTxQONbQiujFVEkqkngRoRZXss0yCvyCQRHRuy/gX6Q7mtLhIt?=
 =?us-ascii?Q?gZS79qPsmd4T6S1Zha5IYFerw6+rwzeAbCLF/+SZcZc5ouWdzm26dfp+dbwL?=
 =?us-ascii?Q?ECtGwsJwDF5absD58D9aq+re57g/mFWZ36eVEoJZhqoCfwDY9XzweMf9xjip?=
 =?us-ascii?Q?kDClkaRdFcgEeGyXMd2fhxWgCvw8ZJV8VgjygPSGvTNqfsTvqWxDKjilnVyz?=
 =?us-ascii?Q?UX5Uhfw6vAvbMp3Iww7IntITAKJagkLj0wxE6YlPArSPncmerf1WhrmfX/SF?=
 =?us-ascii?Q?L/wML1iD5ghrExwZTr/1xdDQLkG6LUtjBhVQCPMvKkWYGxICCi6NhFWMjkP7?=
 =?us-ascii?Q?tyHhTVOhpMuCAzvk6/oMhT9S9wmVYPCs10ZF9VErH6RWky+3bXG7j7IAr5kz?=
 =?us-ascii?Q?+fwjvPESPbJlw8xevmPLzATY566NLPbc0XTcR1TivFlzGd7mAAIj+ZiQQQaC?=
 =?us-ascii?Q?ggLCl8moOUztu6tY7VqIKQDL+wrNaznPOWTK6R/ydaXKGFQ8pkdd2ReDQc5s?=
 =?us-ascii?Q?tw/YE1NOyjBiNLicz6ua41eUmShrdFlB9DvswEL1CKafS0tNnPmyFsmG6AhY?=
 =?us-ascii?Q?0dh4tykHO+3PMaAxGnlu9vTsGyCMlyS2DWwZH7wDBwaWHsFrwe2s90rUtv3c?=
 =?us-ascii?Q?NPBOcF+Yoz7h31cFzx77PFwjSfdYOoSYBo/aPByYroUXXg8eGL2sHrWYNWwy?=
 =?us-ascii?Q?QawKFC0p/4J9+Wpr4rtbBeN8X0dRSeH3egwT6asms+kiMST9PK3ALWtuVxTB?=
 =?us-ascii?Q?hI/VJeHFTtsx5oIKQWhKNWMWuE5P/75PBy0Hcy+zRiAHdPn5HbxRCffCJWK4?=
 =?us-ascii?Q?0A6Ck9re8x1qp7Vd9tVmmTq0pC6ktvZuXAhT3r5PtbDGLrIJh0kyoyH+5IXz?=
 =?us-ascii?Q?HUlYRRnyp5OE6H4CzMwHRBhQ7LR5tjKbqFQlOTstRKJV7vknOGWMbWpit873?=
 =?us-ascii?Q?qc4FfW4fvS5PP63/jXUnJuCteinmvR8/hzEWDUQc2R8HBI3ootNO126hkNGU?=
 =?us-ascii?Q?6xMkfUWtMWLA9P3Y6Lhhl9QyEzrgr4CCRt1446N5BB29pp8LYNNTbJ+o4qOy?=
 =?us-ascii?Q?m06FHgJexU6H3046KFl8iWHkf3LyypXc9QOZjkonMWTy0qeMg+qCnadfaOCo?=
 =?us-ascii?Q?5dJY1Au8uMyDrw3d7O5/y1RM3hxSJdRKGFLEtNQczlmWSAOmvx05Ulw3JRb1?=
 =?us-ascii?Q?M4+aj/bRdjFpx1PtuYxTM3wXIpZoCYUrXo92mE8Ev02NZllJZ5tZQM3xR93q?=
 =?us-ascii?Q?Uofl38d7HBMTH1V9l37tkRqujwtKDQ/hZmfdbFpbe40mR85+weC8iXpieEFI?=
 =?us-ascii?Q?ROAdapRuUMDoaj+EL2NRyzeVCA3MZ9hID5hQuLUdNeXFh97gpkpNrKcEd4P8?=
 =?us-ascii?Q?ZB0bO3gJnMLe7BG1WvG/Cf3bWq6rmgdhjM4Whxl+1DGn3xMc5lYnnqAutDza?=
 =?us-ascii?Q?mMA8aEbh5Vq2cP2HSpanzEBWhDWFt33meCWGwW0eB46IR5FcLpG7/8jn/r/D?=
 =?us-ascii?Q?2mubmNV94OHrsjUVugybRp7XymTlOs1bOAA74Ig9hMGNAUbawxkRw2RQe1Tg?=
 =?us-ascii?Q?ug=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: GTo7gIznNzRromdPyZ+g/oWRKlV7ER+AuXsPX4Upf5DmKSbSAGulx2QxVSb3/mX/5iRCAs3bp22Jk2qf6++l9jQQPt49HSeYbqareTCI8pBFejZ3Vu8P5PoEppfprCitx3rbbjn8g95/Na/V1swh4WDc3lXTEU4xbjMQ0E58tFkSGb3X8+jUZTJN2i8DJgT5+ejmv+71cqCtySlKC7S1aPpGp9x4YyixX7D5ET+1jYgRYOHNc/CkANJv1yKPmxrf8WcOJhTo8BlfAqOHKtui36QIMUTssR7wZSfeXD/JrrL1HntJrW7Ze40PvmcwT/OaSnI0qeO7m02T2nsSf7o+0zFh/lm5pWrKTdKragFghu9owZDfWBiEaZ/S82xWM3typpsb+BGhH6BRD+nhCRlAsid89pDMTwLR9Crutp/LieRCkKRzvKpXqPOAPWkVzliG6+Xgws4+2RBtd7+zXbIFl850LVQqr83zqrmc4SOwUUJJDNjLMFS49ZDGOaaJHjeAwgqhdpYfOwXNruv/e0cvV69Dg0DkjiLrN+iiH8P0qdGwOFQ7Sqf2Mxm3r1yB23+317uS56CoGqdvg0an/gWKQLNAZ8bfn+ysq2fpyWKu9+A=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 07f95380-e308-4315-ed11-08dbfc5dfbcc
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 04:34:39.3078
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5qBumKp/KCl5PT6Ljx0beDAZKUBiOiTfIByr9YITgHLbePrhrgH+H9YuoTqFa4y8qB6piuhD+H+QN7NVCJ4KbfVjA1eyRIaXS0UYWKLo548=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB5865
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-14_01,2023-12-13_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 suspectscore=0
 phishscore=0 adultscore=0 mlxlogscore=782 bulkscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2312140024
X-Proofpoint-ORIG-GUID: 2okomzqzP-A77CCi_1M0DD3yTweOsuvC
X-Proofpoint-GUID: 2okomzqzP-A77CCi_1M0DD3yTweOsuvC
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 13 Dec 2023 20:35:28 -0800 (PST)


Hi Ming!

>> +	lim->atomic_write_unit_min_sectors = 0;
>> +	lim->atomic_write_unit_max_sectors = 0;
>> +	lim->atomic_write_max_sectors = 0;
>> +	lim->atomic_write_boundary_sectors = 0;
>
> Can we move the four into single structure and setup them in single
> API? Then cross-validation can be done in this API.

Why would we put them in a separate struct? We don't do that for any of
the other queue_limits.

-- 
Martin K. Petersen	Oracle Linux Engineering