Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5770622rdb; Wed, 13 Dec 2023 21:10:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IGMauc/W1ejgn6uX/bwv2YQHej34PPBW4wOXYsvrMo7OkHhPKGPLTArm5pnTMv5hDJrera6 X-Received: by 2002:a17:903:22c7:b0:1d0:7965:f530 with SMTP id y7-20020a17090322c700b001d07965f530mr9541084plg.88.1702530642211; Wed, 13 Dec 2023 21:10:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702530642; cv=none; d=google.com; s=arc-20160816; b=iewiV9ijm56EltQOB8fOu/8Q6tm5gJZ5oSO0wE7SxDwqun4oOneTvfL7+zJVGYogby 8VgLC34VZ/C/C6gPLVpN3c7CUqnHyepqUddUpU3vhFbxrBWJw/3eRFbAmObbMjzQQ19a Rcrr7LD2BLmrTZRD/WNjs2AeO9oUMerG7Bq9zzsTgPfsL8ARbgnUOCMkOyPuC9b2R3dG xDx4pGUmYuv5K8Ad1cpxtyeFrsaouIdoR9R/eNN/iGBcYEiHbCdEaguC91p74IQ5T4Yu j/Z8VAEO+Ov+AN2LlEAFtv7xSCW8Z0bcfzY+/ugICsD2UtO0natPeA19t1AUDUh7rkeU F1/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=HRQN/5Gl+E+Y/YwiwR7f4dgjP1vz1MfNF5W9YJDw5ro=; fh=ZvWfYo8qCwzSJkETMTOIJpXM+xs+Nu/s/oJ/5JDEK6A=; b=FCLueqZC4lkEzOCMKR+biOSGLJTlVubYbtHcuqokv4+V3fgZErgxKP7Y0IQJYAZhQo FH9A44K6MZ2c6YiCyIsUf/lEMu791mtzjevTLVD4nCg3UhFrcGj1b0p+gVj3XDaVmrNt nzoQHq0PJaUz6izHiUoh3yc3rDOtFbVJYRMdNlQwXv3mlqDRN3s+HIIMXaIVBmP9itu/ CxqueoR3X8g84iH84+MPbLxU2xJayhe9zACt3PxZJ86JsmasfQ+Bh4l+NH+tNlp7gI7D oP9w6mR3/ZeMBhcNGSBPaLJnw5ucfL6xu2p3uKgFyY/dKFUiqXWXrsi105qHoY2HP//O jGIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=muls9Ixx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id i5-20020a170902c94500b001d352a49698si1975932pla.397.2023.12.13.21.10.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 21:10:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=muls9Ixx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id C7CFE82CEFDD; Wed, 13 Dec 2023 21:10:05 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443137AbjLNFJt (ORCPT + 99 others); Thu, 14 Dec 2023 00:09:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234253AbjLNFJr (ORCPT ); Thu, 14 Dec 2023 00:09:47 -0500 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB007112 for ; Wed, 13 Dec 2023 21:09:50 -0800 (PST) Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-6cebcf8a48aso6537095b3a.3 for ; Wed, 13 Dec 2023 21:09:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702530590; x=1703135390; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=HRQN/5Gl+E+Y/YwiwR7f4dgjP1vz1MfNF5W9YJDw5ro=; b=muls9IxxcvhgabpJnsNRrjQqVmbLHeRx9Z19ijPtLKdd6DTHqLeN9szmdTQFEwpc2o XvWXG/Ug7BQ5NCowzMWQXhdGAqdRSQ36nmPSem1r+rFZ6QjmZjkKoTjzblD+7jb/p5uC uRil78WewuDF5wHA3/X+olXRHjfQLDe676duAZpmEtBMxC+uigAe0ZAJn4KR78fAvoNQ C7Cf4W7AyFuHOJNjS08euBGaoDXQ4HOkNnYB0mxGQPk+NLfLDFxl9rOPAIQ1BCdCqr3c SWA2IVRpgQ3eAtZJ0YE+qYtkrdo430yg5lzdw6mGQGnoXhTAI9aCXdi9xelC674BykLY TMtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702530590; x=1703135390; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HRQN/5Gl+E+Y/YwiwR7f4dgjP1vz1MfNF5W9YJDw5ro=; b=Xz2qDr2FfLygerLynq3KKuB9tW0Ky3FUlU8mUnUgA7ScoUAXNOl+eLt/vQNvw0IpHt hdQfZ7aIF0roZXbvIMGZEA/XKj5AyIhfvC8IS5UZ89a/pYxyD1nwivp6NeR7mpsQtjtO MbWOolMRIi6gyNInbwjhlX5MXlbczxUovxqSeBoatM4QMHEIrMGh6nI138ymGlb5nN+W KecGi6XWymGrQkrmRyg0QCt9ovX01vHjVsWRA9+Lm4g+I5Ol8iK7+ZOen0dpOojfg684 4coiJtKirPvUNr6+OShXeYovkajSKPd4eR2bkURWtV/xsQhZrRzSfCJPD3DtSeGcEREr Kiog== X-Gm-Message-State: AOJu0YyhIkg5xXo7OiS80B+gARTrT63yzekezlOEEZs9crMZf33a68IB 4dMPs8nMlW5AdByCHUi5ttwh X-Received: by 2002:a05:6a20:1604:b0:190:3b35:5999 with SMTP id l4-20020a056a20160400b001903b355999mr12233369pzj.9.1702530590210; Wed, 13 Dec 2023 21:09:50 -0800 (PST) Received: from thinkpad ([117.213.102.12]) by smtp.gmail.com with ESMTPSA id z17-20020a17090ab11100b0028a69db1f51sm7950911pjq.30.2023.12.13.21.09.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 21:09:49 -0800 (PST) Date: Thu, 14 Dec 2023 10:39:43 +0530 From: Manivannan Sadhasivam To: Konrad Dybcio Cc: martin.petersen@oracle.com, jejb@linux.ibm.com, andersson@kernel.org, linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com, ahalaney@redhat.com, quic_nitirawa@quicinc.com Subject: Re: [PATCH v2 00/17] scsi: ufs: qcom: Code cleanups Message-ID: <20231214050943.GC2938@thinkpad> References: <20231208065902.11006-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 13 Dec 2023 21:10:06 -0800 (PST) On Sat, Dec 09, 2023 at 06:42:31PM +0100, Konrad Dybcio wrote: > On 8.12.2023 07:58, Manivannan Sadhasivam wrote: > > Hello, > > > > This series has code some cleanups to the Qcom UFS driver. No functional > > change. In this version, I've removed code supporting legacy controllers > > ver < 2.0, as the respective platforms were never supported in upstream. > > > > Tested on: RB5 development board based on Qcom SM8250 SoC. > > > > - Mani > > > > Changes in v2: > > > > * Collected review tags > > * Fixed the comments from Andrew > > * Added a few more patches, most notably one removing the code for old > > controllers (ver < v2.0) > FWIW i found this snipped from a downstream commit from 2014: > > 8084 : 1.1.1 > 8994v1 : 1.2.0 > 8994v2 : 1.3.0 > > I'm yet to see any 8994 production device utilizing UFS (it wasn't > very good or affordable in 2014/15 IIRC), so I think it's gtg. > Thanks for digging! I was told that SoCs based on UFS 1.x controllers were not widely used in production, though I don't know why. - Mani > Konrad -- மணிவண்ணன் சதாசிவம்