Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
From:   Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
To:     <conor@kernel.org>
CC:     <conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
        <jisheng.teoh@starfivetech.com>,
        <krzysztof.kozlowski+dt@linaro.org>,
        <leyfoon.tan@starfivetech.com>, <linux-kernel@vger.kernel.org>,
        <linux-watchdog@vger.kernel.org>, <linux@roeck-us.net>,
        <robh+dt@kernel.org>, <samin.guo@starfivetech.com>,
        <wim@linux-watchdog.org>, <xingyu.wu@starfivetech.com>
Subject: Re: [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100
Date:   Thu, 14 Dec 2023 13:17:17 +0800
Message-ID: <20231214051717.9795-1-jisheng.teoh@starfivetech.com>
In-Reply-To: <20231213-rectified-unmindful-4064c852930f@spud>
References: <20231213-rectified-unmindful-4064c852930f@spud>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Wed, 13 Dec 2023 16:35:39 +0000
Conor Dooley <conor@kernel.org> wrote:

> On Wed, Dec 13, 2023 at 10:57:59AM +0800, Ji Sheng Teoh wrote:
> > On Tue, 12 Dec 2023 16:47:59 +0000
> > Conor Dooley <conor@kernel.org> wrote:
> >   
> > > On Tue, Dec 12, 2023 at 04:46:00PM +0000, Conor Dooley wrote:  
> > > > On Tue, Dec 12, 2023 at 11:17:31AM +0800, Ji Sheng Teoh wrote:
> > > >   
> > > > > Add "starfive,jh8100-wdt" compatible string for StarFive's
> > > > > JH8100 watchdog.
> > > > > Since JH8100 watchdog only has 1 reset signal, update binding
> > > > > document to support one reset for "starfive,jh8100-wdt"
> > > > > compatible.
> > > > > 
> > > > > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
> > > > > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
> > > > > ---
> > > > >  .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > > | 2 ++ 1 file changed, 2 insertions(+)
> > > > > 
> > > > > diff --git
> > > > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > > index 68f3f6fd08a6..02572b16ac08 100644 ---
> > > > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > > +++
> > > > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > > @@ -27,6 +27,7 @@ properties: enum:
> > > > >        - starfive,jh7100-wdt
> > > > >        - starfive,jh7110-wdt
> > > > > +      - starfive,jh8100-wdt
> > > > >  
> > > > >    reg:
> > > > >      maxItems: 1
> > > > > @@ -45,6 +46,7 @@ properties:
> > > > >        - const: core
> > > > >  
> > > > >    resets:
> > > > > +    minItems: 1
> > > > >      items:
> > > > >        - description: APB reset
> > > > >        - description: Core reset    
> > > > 
> > > > This relaxes the constraints for the existing devices, please
> > > > add per compatible constraints to avoid doing so.    
> > >   
> > Thanks Conor. Just to clarify, are you suggesting to add what was
> > done in v1?
> > v1:
> > https://lore.kernel.org/all/20231209142723.2060196-3-jisheng.teoh@starfivetech.com/
> >  
> 
> No, but similar. Add numerical constraints that vary per SoC without
> changing the names of the resets on a per-SoC basis.:wq
> 
Sent out v3, hope it addresses the comments.
v3:
https://lore.kernel.org/all/20231214033056.3953143-2-jisheng.teoh@starfivetech.com/