Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5773956rdb; Wed, 13 Dec 2023 21:21:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IHQrwQx3S/9froAVFm11WHIfugR+CKrazbtaN4q0BNRIot+cvzl1VUOA6K+kKc0ydOTuRWB X-Received: by 2002:a05:6e02:152c:b0:35d:5b16:60e3 with SMTP id i12-20020a056e02152c00b0035d5b1660e3mr12850701ilu.11.1702531307336; Wed, 13 Dec 2023 21:21:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702531307; cv=none; d=google.com; s=arc-20160816; b=JSnRg6DUfPAVoZ4Qs9qBkNbGiQFdE4jlrIqo/SGX6FE+GVt1b9vu0E1L7fyfRvSkKr nmP2r+Z72OM1fmiWbLNHEO4qMxBQBwFz7UnC70Z24xLLImzIFuWO4TwOVHKf/nrXUL4y evH83ONB5Ihiz0oP6AerLxW4NDAHMzkZF8L8t0THC+q7xqu8Q78uC25PecwE4gmICDz3 NCKCr4e+xVT1H5/bQ0r9nvFTQbr0UZkvZ/YGvju0UEbz8XhzMPYvNsl74j/vLltjUehf Ivl9KQAOhUEnI2qQiTRohI1q7sJ/xSx5QB10qN0ViOYWm1GfMnoe2daMKpJ7CXa1hXkm dYYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=+EpxA/oQdOsjZ3ZViQvYoAgBSxxBD7k1MJl0VMHDlZw=; fh=vGiJHGqu/5Yt6t3z37zxcx+lCH3j9LwNmuhKr9MLkXc=; b=sYgDsSVl3HMqBsaVeLVNT+vaDyvqIBjZgVEkuB4TN8P8ex13zKz4b7HHz3rCxm9dKs q292SbYgu4Px7wY2lr7UVV/OXkAvzhF6BGQ7mFB9LwavfoWF9g5eGuTQIMAMkgBujbCh t04tyVDwdwrEZ1wvfyN/WcPSTv2MxfTLyZ2NHXUCiYocOqqiSoVe32BfWmD9JL3RNxTS XA9HV9Oai8z6lR7YGzAfYOZyk6lztFbxNLwhEqoGarh31KOVD+6GFxylJgVIQxyzELwS 1HrbxjneOYZB2CAwpHQtz95qPuAC2cq0DuSYmcxdbNfZx0Iam0wIkP9CyI058le5sPeI UOBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="UAspA/Is"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id p3-20020a170902e74300b001d3622d0c97si1145740plf.631.2023.12.13.21.21.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 21:21:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="UAspA/Is"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 4F07D80775BA; Wed, 13 Dec 2023 21:21:46 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443162AbjLNFVg (ORCPT + 99 others); Thu, 14 Dec 2023 00:21:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1443143AbjLNFVf (ORCPT ); Thu, 14 Dec 2023 00:21:35 -0500 Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CA95D0 for ; Wed, 13 Dec 2023 21:21:42 -0800 (PST) Received: by mail-ot1-x334.google.com with SMTP id 46e09a7af769-6d9f7af8918so4634570a34.0 for ; Wed, 13 Dec 2023 21:21:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702531301; x=1703136101; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=+EpxA/oQdOsjZ3ZViQvYoAgBSxxBD7k1MJl0VMHDlZw=; b=UAspA/IsK57VOg0BoQsC8pQj/alUB8bxVhcPY94S9xw0qBtoS6fSqtfuOfoj24I4YM hftxh+s0oa4pjgxi2/tYMVnmQssr0FvmF9pkEb5aMNcpxpkCQVRhM4kLLX1kadDLkvkl LIRt4qXHKFKwnFOhHlx1dMBVX+f11KLvwadj7Rmcs+DO05MWggQ97+Nn6Vn+cfPsU46N FXlahyJe/0A3xV8O4B2350ah4759Nog1Q9WCrgFx5R+V3paXNzrxM1zlL8ZdmttRNqA2 lOId9/NGlvX8salpEXBEpoyqoGu3rVUwa6C14SkjvcKF/qQ/7QTCg7pqW+JNBhA82ztb clyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702531301; x=1703136101; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+EpxA/oQdOsjZ3ZViQvYoAgBSxxBD7k1MJl0VMHDlZw=; b=ENykyNhyErOtWdXkHKt5GwwrztVSmgsyKvgcsgmuOk45/cYoBZ0PFMfw+nlZigVKbf 4XFZyZjHT1yuvHny2XJ4HTwvK1OTQ/QYLGajMY2bm1O3bPF88nJb/Z98zL94c/i8TIni 7E4IwNhIfC0XmvLsybXFxd7wfleP5awvJWlq05siFnoxnl976gaLQpkzqOZxl1S67dSs 7LUwqQrGY91+LflU1R0gUvLzacuqzqVObA89IUYOIPpj9GmOCh/0Zq3txRToGomeZa++ IVRiCBQHFO0rvGvwnoiY2ptLq/QQUxPKJ+sQJLpj1kxdTAQia2vdXnCrcw2wS+jFlhJI uttg== X-Gm-Message-State: AOJu0YxteCfkJdNM2tnt0LU/au+6vRJb3/tZF4kXpC+piSzZQbUs8EuI AOSA3VYwQSr13QINznVYSMC8 X-Received: by 2002:a05:6830:10cb:b0:6d9:e37f:5c54 with SMTP id z11-20020a05683010cb00b006d9e37f5c54mr9479978oto.9.1702531301439; Wed, 13 Dec 2023 21:21:41 -0800 (PST) Received: from thinkpad ([117.213.102.12]) by smtp.gmail.com with ESMTPSA id gu4-20020a056a004e4400b006ce4e3e2524sm10907827pfb.135.2023.12.13.21.21.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 21:21:41 -0800 (PST) Date: Thu, 14 Dec 2023 10:51:33 +0530 From: Manivannan Sadhasivam To: Bjorn Helgaas Cc: lpieralisi@kernel.org, kw@linux.com, kishon@kernel.org, bhelgaas@google.com, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/9] bus: mhi: ep: Add async read/write support Message-ID: <20231214052133.GF2938@thinkpad> References: <20231127124529.78203-1-manivannan.sadhasivam@linaro.org> <20231213193103.GA1054774@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231213193103.GA1054774@bhelgaas> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 13 Dec 2023 21:21:46 -0800 (PST) On Wed, Dec 13, 2023 at 01:31:03PM -0600, Bjorn Helgaas wrote: > On Mon, Nov 27, 2023 at 06:15:20PM +0530, Manivannan Sadhasivam wrote: > > Hi, > > > > This series add async read/write support for the MHI endpoint stack by > > modifying the MHI ep stack and the MHI EPF (controller) driver. > > > > Currently, only sync read/write operations are supported by the stack, > > this resulting in poor data throughput as the transfer is halted until > > receiving the DMA completion. So this series adds async support such > > that the MHI transfers can continue without waiting for the transfer > > completion. And once the completion happens, host is notified by sending > > the transfer completion event. > > > > This series brings iperf throughput of ~4Gbps on SM8450 based dev platform, > > where previously 1.6Gbps was achieved with sync operation. > > > > - Mani > > > > Manivannan Sadhasivam (9): > > bus: mhi: ep: Pass mhi_ep_buf_info struct to read/write APIs > > bus: mhi: ep: Rename read_from_host() and write_to_host() APIs > > bus: mhi: ep: Introduce async read/write callbacks > > PCI: epf-mhi: Simulate async read/write using iATU > > PCI: epf-mhi: Add support for DMA async read/write operation > > PCI: epf-mhi: Enable MHI async read/write support > > bus: mhi: ep: Add support for async DMA write operation > > bus: mhi: ep: Add support for async DMA read operation > > bus: mhi: ep: Add checks for read/write callbacks while registering > > controllers > > > > drivers/bus/mhi/ep/internal.h | 1 + > > drivers/bus/mhi/ep/main.c | 256 +++++++++------ > > drivers/bus/mhi/ep/ring.c | 41 +-- > > drivers/pci/endpoint/functions/pci-epf-mhi.c | 314 ++++++++++++++++--- > > include/linux/mhi_ep.h | 33 +- > > 5 files changed, 485 insertions(+), 160 deletions(-) > > Mani, do you want to merge this via your MHI tree? If so, you can > include Krzysztof's Reviewed-by tags and my: > > Acked-by: Bjorn Helgaas > > If you think it'd be better via the PCI tree, let me know and we can > do that, too. > Thanks Bjorn! Yes, to avoid possible conflicts with other MHI patches, I need to take this series via MHI tree. - Mani > Bjorn -- மணிவண்ணன் சதாசிவம்