Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-1283-g327e3ec917-fm-20231207.002-g327e3ec9
MIME-Version: 1.0
Message-Id: <af1f937b-37e0-466d-ac94-4f57e086f326@app.fastmail.com>
In-Reply-To: <ZXmtqc7fTeZbRW5B@kekkonen.localdomain>
References: <20231213124310.761638-1-arnd@kernel.org>
 <ZXmtqc7fTeZbRW5B@kekkonen.localdomain>
Date:   Wed, 13 Dec 2023 15:42:08 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Sakari Ailus" <sakari.ailus@linux.intel.com>,
        "Arnd Bergmann" <arnd@kernel.org>
Cc:     "Tomas Winkler" <tomas.winkler@intel.com>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        "Wentong Wu" <wentong.wu@intel.com>,
        "Alexander Usyskin" <alexander.usyskin@intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mei: fix vsc dependency
Content-Type: text/plain
Precedence: bulk

On Wed, Dec 13, 2023, at 14:12, Sakari Ailus wrote:
> On Wed, Dec 13, 2023 at 01:43:05PM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>> 
>> The Kconfig dependency in the new module is reversed from the dependency
>> on the exported symbols, so it fails to link with CONFIG_INTEL_MEI_VSC
>> disabled and CONFIG_INTEL_MEI_VSC_HW enabled:
>> @@ -64,6 +64,7 @@ config INTEL_MEI_VSC_HW
>>  	tristate "Intel visual sensing controller device transport driver"
>>  	depends on ACPI && SPI
>>  	depends on GPIOLIB || COMPILE_TEST
>> +	depends on INTEL_MEI_VSC
>
> Oops. The dependency indeed seems to have been reversed.
>
> Could you also reorder the entries so the one that depends on the other
> would be below?

Update: I actually misread the code and the original dependency
appears to have been correct. Instead there is a different bug,
so I'll send a new patch after I have done enough testing on
the new version.

      Armd