Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5834864rdb; Thu, 14 Dec 2023 00:19:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IFZD+E2tpW1Eo7SoF3h8zG4wSjrOHLO7xZibCc2tY00hiBRK7Ep8YfKGLDA/Mgt7Dcr/YTG X-Received: by 2002:a17:90a:fe89:b0:28b:c3f:b9b7 with SMTP id co9-20020a17090afe8900b0028b0c3fb9b7mr250912pjb.13.1702541953845; Thu, 14 Dec 2023 00:19:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702541953; cv=none; d=google.com; s=arc-20160816; b=USWkAXmi6ihlsENJoE2cUVv99jn9XxMofqlrttHSlhBPRiYuDEk58CAFJ8H1QkiEU+ c2Eab/8YKtWhJG424YZuqvolnnBlM4WyBxxGOgD7xY3h0dBfLNqZ0Gw/pvpW4f8qBkI5 nu1xBcpvdx2ims6BrSDkWqq+SLdVDha2vOYOBsH1vPJct//ngeIec87kVcFhGv7lmtl7 lt5baXsq37fm1Ii56HJ1MQIqwHtAOMQGOwHfExGpIIunhcV7wfVG9eze3673k5jaQD9n opXxsqC1vf3SYIcMD/n3W5PN5B8+Yp+YZ9NmdhQ6OmRbdfka6Vs+q+66r4J708D6cP19 edsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=NUzmmsL1ZYH26dLfyMCpbQFSCnHCb1FNohT2hgdN0Ic=; fh=L5blFZhM7ka7cCoctgmd6M5+vyw6nsMZ1DpHic9fTjg=; b=ARnXBgWRtkrO8PWUGBHrqLRm4Xs2MzCFYJdzeR/QQReh0JpV4J9B1vsFuxWr4bnWEY wKux93mEJIvUKf37YT4d91kDRbSCcyee9M/8Hz3tfTjGKPwqSX6h1rZUlrz0+LXlHF9H wlX3s95nVuzqVovjX5m9J9bQVVvbJEHrafvARczzorMwCli3gCIrckq9yDrlG9RNSmA6 tZxD3gaecyBIfITej0ckBjsAA/o2+N8mOREczPC+CjXjv9ZMUIRgyHQOq2q9hKM53vrR 5tfeplZGUxHWy8RNkMMDfUGf2cipxKOUV0WZmJWj7xawVCyDc7qA2jKfg1JpJFs5GAzE DrxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=h4nsaLKJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id i7-20020a17090332c700b001d34932e41bsi2953505plr.167.2023.12.14.00.19.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 00:19:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=h4nsaLKJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 6378180A9900; Thu, 14 Dec 2023 00:19:12 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232935AbjLNITC (ORCPT + 99 others); Thu, 14 Dec 2023 03:19:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229769AbjLNITB (ORCPT ); Thu, 14 Dec 2023 03:19:01 -0500 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B6C0109 for ; Thu, 14 Dec 2023 00:19:08 -0800 (PST) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6d2350636d6so372144b3a.2 for ; Thu, 14 Dec 2023 00:19:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702541948; x=1703146748; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=NUzmmsL1ZYH26dLfyMCpbQFSCnHCb1FNohT2hgdN0Ic=; b=h4nsaLKJOjBrM/V7EAavCciOLQrR1T2wr1JLC6L40T+OzRHgotHDQ8Q221H0APPKC6 2TINIkmEjkUsxCbAPrbgSMqg9MbO4ku7HF2q4kTXNYZmoYp2MFgBo9JKkPO7AlfEqCbX MA+hU0s5FRP+6ZMpeCpJXQMqeClKnsR673xJMuYnoOWEGhvt4WpWI0OYF0+Q2TOiZZZe 3tn1nTxHDmrPSQ4kT83JuQ+tBmOfI/WT5ZVCAv0IMnVCB4zb9sYTHUHfghIeTk9wpsPY SMtwWVJ+V6y4p0lW6Y892e5XO2GZr1x9sizPiiyMUgkYNPrdS3xoi9uZMwNN31aSFEfA v/8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702541948; x=1703146748; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NUzmmsL1ZYH26dLfyMCpbQFSCnHCb1FNohT2hgdN0Ic=; b=Xg8dw0WfZFrMPW29ILIGwCFCuudt4FkVdTeiI5bfedAXG5Xp3w7n9HSpdCOjSTfXww xFA2hM6/sRRFLV4ShwDnk3e5R1uRL/7xuucpct+ZAU6o1OnrY206yhSd/kd+nrK+UcP6 WLgayfo3l9q1K/QlNZW+7LUTNobH8ipVdQcEaQGRjSKJC4xh59Jftc6YiAujUZU77jNM 0JaOlUjT7WSKyXGw54wGmus2Fyi4waTfqfenOYggFb2L9BBS9Xd0tmi/RvwC3pipBbV+ h7y0dBuA1NymwoSRJKDFZiQrXoIyLWI0Il1l91dLT9+uixmwQkq+Cay47MOhK7+cepWm /t7A== X-Gm-Message-State: AOJu0YxpiTQIRKSZwb7dxJLsCFf6K9E2KynkvJWekRoI9WeYCicEDNkm hhzMBEF0btF1777nAtMZVEUXNVdqXib4yzXQfoansQ== X-Received: by 2002:a05:6a00:98e:b0:6ce:10ed:7754 with SMTP id u14-20020a056a00098e00b006ce10ed7754mr10885356pfg.31.1702541947775; Thu, 14 Dec 2023 00:19:07 -0800 (PST) MIME-Version: 1.0 References: <202312141319+0800-wangjinchao@xfusion.com> In-Reply-To: <202312141319+0800-wangjinchao@xfusion.com> From: Vincent Guittot Date: Thu, 14 Dec 2023 09:18:56 +0100 Message-ID: Subject: Re: [PATCH] sched/fair: remove next_buddy_marked To: Wang Jinchao Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org, stone.xulei@xfusion.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 14 Dec 2023 00:19:12 -0800 (PST) On Thu, 14 Dec 2023 at 06:20, Wang Jinchao wrote: > > Remove unused `next_buddy_marked` in `check_preempt_wakeup_fair` > Fixes: 5e963f2bd465 ("sched/fair: Commit to EEVDF") > Signed-off-by: Wang Jinchao Reviewed-by: Vincent Guittot > --- > kernel/sched/fair.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index d7a3c63a2171..d2028bfa4e94 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -8210,7 +8210,6 @@ static void check_preempt_wakeup_fair(struct rq *rq, struct task_struct *p, int > struct task_struct *curr = rq->curr; > struct sched_entity *se = &curr->se, *pse = &p->se; > struct cfs_rq *cfs_rq = task_cfs_rq(curr); > - int next_buddy_marked = 0; > int cse_is_idle, pse_is_idle; > > if (unlikely(se == pse)) > @@ -8227,7 +8226,6 @@ static void check_preempt_wakeup_fair(struct rq *rq, struct task_struct *p, int > > if (sched_feat(NEXT_BUDDY) && !(wake_flags & WF_FORK)) { > set_next_buddy(pse); > - next_buddy_marked = 1; > } > > /* > -- > 2.40.0 >