Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <a3901226-c5b8-4a97-968e-7be156a42046@oracle.com>
Date:   Thu, 14 Dec 2023 08:56:08 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 04/16] fs: Increase fmode_t size
To:     Christoph Hellwig <hch@lst.de>,
        Christian Brauner <brauner@kernel.org>
Cc:     axboe@kernel.dk, kbusch@kernel.org, sagi@grimberg.me,
        jejb@linux.ibm.com, martin.petersen@oracle.com, djwong@kernel.org,
        viro@zeniv.linux.org.uk, dchinner@redhat.com, jack@suse.cz,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-xfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com,
        linux-scsi@vger.kernel.org, ming.lei@redhat.com,
        jaswin@linux.ibm.com, bvanassche@acm.org
References: <20231212110844.19698-1-john.g.garry@oracle.com>
 <20231212110844.19698-5-john.g.garry@oracle.com>
 <20231213-gurte-beeren-e71ff21c3c03@brauner> <20231213160357.GA9804@lst.de>
Content-Language: en-US
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20231213160357.GA9804@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWdaS21md0NJajhMUzNwL1hDNjZlc2NRYlh3VEZ5V216aHRKNkpTeWdCazNq?=
 =?utf-8?B?SmFuL2RKZlBtMDZwTkE1RGhHSlBKUGRvMm02UXplK3krRVpBcElXZnZEMDhD?=
 =?utf-8?B?RzVzcDd3WUswQWlld2JzSFFLblpLRzNCYmlNdEllZlExSGd6N1FtNkkwNkNG?=
 =?utf-8?B?K05GWS9qdXJzaFc5bjVZUnNZZk0vdnYyYlVOdzl6bmZaZ0t1RmNUdFNnVG0r?=
 =?utf-8?B?QXJwenNSRURVSzZwVm5MZ0ZEVTJnOEpFaERFV3NraE1lZmtyTDE0bVRmUkwz?=
 =?utf-8?B?Y1NmNEE3azlmL2pSM2VmQmlUTE1pZDRYL0F2aFlKODJnNEx1eHVCRDNIMURB?=
 =?utf-8?B?VDU2cHhRUWdkdlFON3VVellIdUFhMm93ZTBMeVlxamxlMHI4Q2pWV3pteGFP?=
 =?utf-8?B?NDI0SWwxZ1lpRUhudlEyYjB3WklwaFlqSjRnVXRBOFd4NnYreGh3N3FYRzZ1?=
 =?utf-8?B?dTFud2tFRk5aM1Y2cndtMzlId2RXaFhENmtnVmpLMkV0dVFKdGxzVm43SGov?=
 =?utf-8?B?bDlRNUdIQ3RXM25jdXpNZzhObFVjZWdmTXdMUXVuZlFheVVLR3E0ZmVNZjRZ?=
 =?utf-8?B?Si90R016d0FWUEtrZDNxTGdkWEtvclE2R3A3N0tNUlVzbUloY0hJQ2dZTTJW?=
 =?utf-8?B?UkdPQVBydWI2Q294YzRaaE5Od1RpUGhYa0srSG9FWVMyRWZiRm9NZVN4ckZQ?=
 =?utf-8?B?ay9tSEgvMmZMYm02dzhmeEZZS281YnAwY2NQRjBVQUFIMEh4d2hsbER1TXdX?=
 =?utf-8?B?TUpQQlMwUEMwSjNTQ2wraXd4SGoyajlrdW1ickFGMWpGaWdtLzlianpCOEJH?=
 =?utf-8?B?Yk51eEM2cm9kcmRnT2FIQUFpTEloang3UndxYmFJdW9kaG0xaFNrN09PZ21D?=
 =?utf-8?B?WE54WXFQZzVzb0d3RUpWZ0UvSjRYM0tYeG1VdHVkVm5yTG1YS0FnekF1WTBB?=
 =?utf-8?B?TmQzYlhzRVdJRWduQ0trUXBOYSs3QlJPNEJhalR2enZrYUpRajk2OGJRVjRy?=
 =?utf-8?B?R24xM0pUSkdPWWpqRlEwZVdaUXE0TzE2eTB3dllvc3J6WDFsaGZkZ3IvSVcr?=
 =?utf-8?B?VFlraVBHb3ZIVjlXT1l1aEpkejlxb09jQmx2SXE4dDBzYmZ2RkFaemJxR2RT?=
 =?utf-8?B?V081KzU4TG9jbkNnb3Q4K0ZsRlBGVnpUdUg5SVFiQ2VveDFpakZWVndxRmZM?=
 =?utf-8?B?ZVIvOTZBMnNDNDRsRlA1VmpLR2hGN0ZFOWVEQjBDS2xCUmRGUGI0Wmkyc3F4?=
 =?utf-8?B?SW8ybHFCbUtsNUd1Q1pjdGkzMXFYNmdrWkpkV2QvcXpEUG5qTGZGZTRZN0t4?=
 =?utf-8?B?b3pUOUZoVGNBRGt3dTlNSTgzOXBmemU0VjFMS3hjSldmT2dmWGdSTllhMGN1?=
 =?utf-8?B?VGRWNmJXU1NJajNLMDZHcDdrTnUvTjlKcWFuQ3NUYVR2blZsZ291RHpJd1RW?=
 =?utf-8?B?NkJsS040eDY2TEpqZE1OM21uRkRuUEN3VFljV3NCQ0RrcTVFMUxHVGpLVk5r?=
 =?utf-8?B?M01RYk9rbkJMU3JkZElKeTFkSUF6WEpHV1JpUncvS1VCR2xsM1JTeGpoazIw?=
 =?utf-8?B?L0hRMzgyOEJuQ2lnYjBHSFZWczNPeUgwVGtkRTZqNkNtSTNra3hHYW1WTHNS?=
 =?utf-8?B?Z2xGeFhLT3NmSjh4UHp0bXpKWGVMZndiRGdYQUU3elNIb0xra0hENnFDRXln?=
 =?utf-8?B?UUdzNDZWUnpFMG11MG1FWWgvcHdFSm5ybFk5TTAydGc4c1VGZTFaT3IxL054?=
 =?utf-8?B?OWV1bEhhbHp5Z1EyZXIxQWYzMSsvdlZoWTBmL1RPN3dRUTVhakZtU29TZFZr?=
 =?utf-8?B?anMvUzZRb0cyNCtJUU5RSXNwNmgzS1ZWeHE2NVlTMmNQY1kzRlFTUDJoa2Mr?=
 =?utf-8?B?SSt5RHNLTE53OHNpY1JBeHp2UWM3MjNiWUg1ejkwbWVBaldKV1hLQlZJdkJI?=
 =?utf-8?B?SWdPb2VhY200d2FGTXowbU10QmxWWkQ3blViVUtSTEtmVHVqa1VaVTRabSt4?=
 =?utf-8?B?QmVpUGtUYVhmbDBBMzlqaW1BRWRUUWNkazJJVkp2OFhDZ0U0MHgxUVkyN0xO?=
 =?utf-8?B?SHFReE1DWUFkdnI0UzYyYzNpVmtrdEhNVG1FOU1NMlViSkVMLzVqWkM4RWtM?=
 =?utf-8?B?YmVjb2J4RURKc2p2bkt1clZ4ZUhJUmlEY0JJYTNmSGhXZkZjU2JieFR2bXZN?=
 =?utf-8?B?VUE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: TngF/NTLGl5d+iE0Sf9OFkECbHrSNUJCEYR7aVgBdMNsFOxyD5M8tuVCIHbvbsp0kzjevW4gqQrYlLD8npOuNTIDj8N8OI47IcraQ59enzOzu1di6FirbAkT0BOY9neFj1zIW3uZ0BU/rUGNabOW8o8kh2f+gMEjbZpFfnpjLWQ4hjlgxu7PcEbEh1DKiTIz+uoq19HBCXX8MxlrIVbyMRjYmVFCAmMTHXHJzzJDSbVr4OAnkybInFRwUi/M0ZdbYfVQ1QI1qQhnEUhD568vmoiTOAgnp9qeRzTQZWS87waBMcuvktVnWuUim/OJosB8ZFuOb8NM7xFNzsvLZ5I9HQOBgJOKdQsaZqQ22EuvtpfIU02rk14cu8+uCs2nhexwCTEcz8cvwvknBxAaI6roRv0DcjwnVT8lnGABwSU0FCjc2mDq4KnKiPv+VH1hXBvyRJuHIZSbQSjApVT3gtja0lMj964M4T1TBtYPSgYg7q+1qz+dUKuLuhE8dz2EC8RbKSNegWm41QfGmTijVFbuazXG17zjDKpGPqJ6GRfRJ6RZ0AdrTzefdSV3LECqyJlJ1pw2NCgF1MXeN1cK0u/cE6zrk/74YOYWxHNStzpnlrc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e0181803-eb80-4fb7-7173-08dbfc8284d9
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 08:56:11.0253
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qn/ajEs+0/F80rwaKuEWqhtvqdxnGOaKAR3cmTGDMXk8K+8jL8wLqZpxjZTX2xExJsXRHGYyCt3AB7ao7FT+gw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB7554
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-14_04,2023-12-13_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 phishscore=0 malwarescore=0 spamscore=0 mlxlogscore=949 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2312140057
X-Proofpoint-GUID: RxVA8dJkEjIGuEagPRwZdLuS-3tl4uEO
X-Proofpoint-ORIG-GUID: RxVA8dJkEjIGuEagPRwZdLuS-3tl4uEO
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 14 Dec 2023 01:01:54 -0800 (PST)

> But even without that do we even need to increase it?  There's
> still quite a lot of space after FMODE_EXEC for example.

Right, I can use the space after FMODE_EXEC, which came free after 
removal of FMODE_NDELAY, FMODE_EXCL, and FMODE_WRITE_IOCTL in v6.5.

Thanks,
John