Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
MIME-Version: 1.0
References: <20231113105234.32058-1-glider@google.com> <20231113105234.32058-2-glider@google.com>
 <ZXiVX5FAWZqHfr7m@arm.com> <20231213121605.GB31326@willie-the-truck>
In-Reply-To: <20231213121605.GB31326@willie-the-truck>
From:   Alexander Potapenko <glider@google.com>
Date:   Thu, 14 Dec 2023 10:27:12 +0100
Message-ID: <CAG_fn=X60dDWKAC6Yswr3RCW15Jpd8BOtRCYP-ijCDZZDzo14A@mail.gmail.com>
Subject: Re: [PATCH v9 1/4] arm64: mte: implement CONFIG_ARM64_MTE_COMP
To:     Will Deacon <will@kernel.org>
Cc:     Catalin Marinas <catalin.marinas@arm.com>, pcc@google.com,
        andreyknvl@gmail.com, andriy.shevchenko@linux.intel.com,
        aleksander.lobakin@intel.com, linux@rasmusvillemoes.dk,
        yury.norov@gmail.com, alexandru.elisei@arm.com,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        eugenis@google.com, syednwaris@gmail.com, william.gray@linaro.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Dec 13, 2023 at 1:16=E2=80=AFPM Will Deacon <will@kernel.org> wrote=
:
>
> On Tue, Dec 12, 2023 at 05:16:15PM +0000, Catalin Marinas wrote:
> > On Mon, Nov 13, 2023 at 11:52:30AM +0100, Alexander Potapenko wrote:
> > > The config implements the algorithm compressing memory tags for ARM M=
TE
> > > during swapping.
> > >
> > > The algorithm is based on RLE and specifically targets buffers of tag=
s
> > > corresponding to a single page. In many cases a buffer can be compres=
sed
> > > into 63 bits, making it possible to store it without additional memor=
y
> > > allocation.
> > >
> > > Suggested-by: Evgenii Stepanov <eugenis@google.com>
> > > Signed-off-by: Alexander Potapenko <glider@google.com>
> >
> > Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> >
> > > +void mte_tags_to_ranges(u8 *tags, u8 *out_tags, unsigned short *out_=
sizes,
> > > +                   size_t *out_len)
> > > +{
> > [...]
> > > +}
> > > +EXPORT_SYMBOL_NS(mte_tags_to_ranges, MTECOMP);
> >
> > I may have asked before, what the reason for EXPORT_SYMBOL_NS? Is it fo=
r
> > the kunit tests? Otherwise we don't expect those to be accessed from
> > modules.
>
> It looks like it. The Kconfig option for the test is tristate and it call=
s
> this symbol directly.
>
> Will

What Will said.