Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
From:   Wu Bo <bo.wu@vivo.com>
To:     Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, Wu Bo <wubo.oduw@gmail.com>,
        Wu Bo <bo.wu@vivo.com>
Subject: [PATCH] fsck.f2fs: fix orphan inode check fail
Date:   Thu, 14 Dec 2023 03:01:48 -0700
Message-Id: <20231214100148.3422585-1-bo.wu@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Lk0L0dBeKJB/t/VAbZlptk8PQfnyzUaiav+ZU6HDGEmnFTXiPzvTaq/Wvnhi?=
 =?us-ascii?Q?1t/fsvBWAKQjwEfMxoVdUywx3mfUO5ZqFQ/axquMuPdRdWEYLF71DtRj8n6m?=
 =?us-ascii?Q?HNFQepW2gFEy3JA8+Pi5kGWQsHfIoetEvPsBLgQ6W0MNj85MntF+GOSnI6XI?=
 =?us-ascii?Q?YBjzcwvHmHpQ8hWNywdTALkHpHcKkNqDS0pGElnC9YO45nwt20mQEnqMJZQx?=
 =?us-ascii?Q?JltP51kP2jb/iGpBZ/JGcr6Nn3lST5KBU3M1M6OHdGEOBhBBuLJOiiJznkD8?=
 =?us-ascii?Q?pf+Ax2Z21zGuwCnfDBJDQiVatReqlbP9bwl+BBEgbVOm1+XCX0hq6dAmC08P?=
 =?us-ascii?Q?ROTQXIaNP9spwFBXgK4cgdAVh5i5eshlK675WH9OuLe6ye8gMv5HaGLaymQO?=
 =?us-ascii?Q?oLNFZdJ7bXVVZbJYsA2y91qrxi8X/aXW3epyHeNfjCoUG3hi9fzkQRm0xzg1?=
 =?us-ascii?Q?cdWnhgZoZZ/ZR16mseLHak5yZw1L78v/1k+eyKV4JZzn3zMNYxLXiMLLPvxe?=
 =?us-ascii?Q?x7Dt+QyKcCaNjpRPiWUku4vS979yLAmWxn1gDgaV9YtM/9EbnNWf+IeF+Amd?=
 =?us-ascii?Q?KbWCbGMJ+aFN2uFl4dir4CajrnYdNX2GrjcQ+bTS5ZZd8oVBGUpDsJskzPUk?=
 =?us-ascii?Q?SwxJo5+wlREp1qGZLzWcJ4cuBpfF5q/xr7S90ezF+7NxVKUhz4TDm1tkgsSR?=
 =?us-ascii?Q?Hd05QOuM5taxd38Pbmk3t0icflDte2tHDhDm6kDVLyrw2iGzyuju9xRhsVNM?=
 =?us-ascii?Q?E5zx2z3F8wR4/SRCqJUzcoUrX4GoH/XMWa/TWHcIJVyaQt+NpytH7Z1u16MN?=
 =?us-ascii?Q?aY8NxecLd+1xQbI8J44fJeG3YvLCa7ckpQQYJI1xQ4kGyTuTikTWHQZwGzJ1?=
 =?us-ascii?Q?IciI4FVr3im5+xQ1G9YrhSyWcpFiMUKCzB5t5QyU60FpRqQ/zBL5KCmBPBnG?=
 =?us-ascii?Q?GFxShXX4riAo2r4bHENRem280B37VmmFaGImt2GY1c1LzAPiUDCumRzofpWs?=
 =?us-ascii?Q?t/oIkyc7KTceFTNlB2AtpBPkUXIO3ZBz9JAjbJtM1tuKZ3yMhIp05q8eoPgp?=
 =?us-ascii?Q?/ZfOnheCgVkegmy3Zz1QrFLiNxFjQDSByibVxc0B6uDCrytpUKC7nlEU4n4O?=
 =?us-ascii?Q?4+O2ivIaBM1oIxSAnIOjTRh0DMAhVSifWd8pKnpcx0WtnEO+lp8xJ8BXhSZL?=
 =?us-ascii?Q?wc/LlhTWynzT0EdXRajY7FyK15yLwcPLuQ9L+lYKZEwBdFfx1A4R6XNKwjxX?=
 =?us-ascii?Q?V+FBUA/a8XdxpKH4JyJKut8Lx+sQg80A1o4L00p3Cs9rnXaFq29TmHoruqnH?=
 =?us-ascii?Q?rAY4CZnpj7yzPKhcBO7F+kvYa7UYQvhnVjZAUgA8N4gsxNmPZa8QtMEfYJa8?=
 =?us-ascii?Q?eQ7nINziivuT+f0nX2h+a+Df5pa5LO3t/Y+NXENYCodDXb0sLQKkzNxLTdt1?=
 =?us-ascii?Q?6GWI6eTBD3obM21joGOjmXh/+flcb/+r/oca1stypIuYbivd6+VU2Gt1vf0o?=
 =?us-ascii?Q?8u3vrbLSY0fxeNhBZOc4Rf8GIJpLiOD3f/HnsJgUoSn05isnk41tfWVjLvAl?=
 =?us-ascii?Q?Vh2p/PyyNObmPJHpOuP+r0jPXBB7+EqHpd5uFj8O?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df8a96e1-307d-4ac4-83bb-08dbfc8a4fd3
X-MS-Exchange-CrossTenant-AuthSource: TY2PR06MB3520.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 09:51:58.4928
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Vu7DnOaXZIn16W49Rb3ZbNQLjlZ/ybzApa54FvtNP5RMN8+b25SiXUdGqVsmgT6qfTumJdiVGYIKgtdmAplXdg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4381
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 14 Dec 2023 01:52:53 -0800 (PST)

Call path:
fsck_chk_orphan_node
  fsck_chk_node_blk
    fsck_chk_inode_blk

'F2FS_FT_ORPHAN' will pass to fsck_chk_inode_blk(). If the orphan inode
is a DIR, it will be wrongly fixed.

Fixes: 8fd836f ("fsck: clear unexpected casefold flags")
Signed-off-by: Wu Bo <bo.wu@vivo.com>
---
 fsck/fsck.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fsck/fsck.c b/fsck/fsck.c
index e93db82..3461a52 100644
--- a/fsck/fsck.c
+++ b/fsck/fsck.c
@@ -1052,7 +1052,7 @@ check_next:
 	ofs = get_extra_isize(node_blk);
 
 	if ((node_blk->i.i_flags & cpu_to_le32(F2FS_CASEFOLD_FL)) &&
-	    (ftype != F2FS_FT_DIR ||
+	    (!S_ISDIR(le16_to_cpu(node_blk->i.i_mode)) ||
 	     !(c.feature & F2FS_FEATURE_CASEFOLD))) {
 		ASSERT_MSG("[0x%x] unexpected casefold flag", nid);
 		if (c.fix_on) {
-- 
2.25.1