Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Thu, 14 Dec 2023 12:16:43 +0200 (EET)
From:   =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
To:     Reinette Chatre <reinette.chatre@intel.com>
cc:     linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        =?ISO-8859-15?Q?Maciej_Wiecz=F3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 09/29] selftests/resctrl: Create cache_portion_size()
 helper
In-Reply-To: <0d6cff29-9cda-4501-a29b-48e76fe2a9d8@intel.com>
Message-ID: <bcef4bc4-796e-f0f1-4fa5-8c6a232a3a64@linux.intel.com>
References: <20231211121826.14392-1-ilpo.jarvinen@linux.intel.com> <20231211121826.14392-10-ilpo.jarvinen@linux.intel.com> <0d6cff29-9cda-4501-a29b-48e76fe2a9d8@intel.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-204481810-1702549009=:5690"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-204481810-1702549009=:5690
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Wed, 13 Dec 2023, Reinette Chatre wrote:

> Hi Ilpo,
> 
> On 12/11/2023 4:18 AM, Ilpo Järvinen wrote:
> > +/*
> > + * cache_portion_size - Calculate the size of a cache portion
> > + * @cache_size:		Total cache size in bytes
> > + * @portion_mask:	Cache portion mask
> > + * @full_cache_mask:	Full Cache Bit Mask (CBM) for the cache
> > + *
> > + * Return: The size of the cache portion in bytes.
> > + */
> > +static inline int cache_portion_size(unsigned long cache_size,
> > +				     unsigned long portion_mask,
> > +				     unsigned long full_cache_mask)
> > +{
> > +	return cache_size * count_bits(portion_mask) / count_bits(full_cache_mask);
> > +}
> > +
> 
> Even after you added the new zero check the static checker I tried
> was not able to recognize that this is safe. Could you please add a check
> to ensure that there will be no divide-by-zero here?

Okay. I also now noticed the return type is not what it should be.

-- 
 i.

--8323329-204481810-1702549009=:5690--