Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <2a064fde-0c90-4ef5-86bf-5dc9172149ab@quicinc.com>
Date:   Thu, 14 Dec 2023 15:52:57 +0530
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V2 2/2] arm64: dts: qcom: sc7280: add QCrypto nodes
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
CC:     <neil.armstrong@linaro.org>, <konrad.dybcio@linaro.org>,
        <agross@kernel.org>, <andersson@kernel.org>, <conor+dt@kernel.org>,
        <davem@davemloft.net>, <devicetree@vger.kernel.org>,
        <herbert@gondor.apana.org.au>, <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <marijn.suijten@somainline.org>,
        <robh+dt@kernel.org>, <vkoul@kernel.org>
References: <20231212133247.1366698-1-quic_omprsing@quicinc.com>
 <20231212133247.1366698-3-quic_omprsing@quicinc.com>
 <c848f874-3748-4d59-8e78-9ae044fb760a@linaro.org>
 <6b79c66d-7591-443b-92e5-beeff6c93ae4@quicinc.com>
 <5bc96a31-8869-483c-9427-1f4a90263874@linaro.org>
Content-Language: en-US
From:   Om Prakash Singh <quic_omprsing@quicinc.com>
In-Reply-To: <5bc96a31-8869-483c-9427-1f4a90263874@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/14/2023 12:52 PM, Krzysztof Kozlowski wrote:
> On 14/12/2023 06:41, Om Prakash Singh wrote:
>>
>>
>> On 12/12/2023 8:32 PM, Krzysztof Kozlowski wrote:
>>> On 12/12/2023 14:32, Om Prakash Singh wrote:
>>>> Add the QCE and Crypto BAM DMA nodes.
>>>>
>>>> Signed-off-by: Om Prakash Singh <quic_omprsing@quicinc.com>
>>>> ---
>>>>
>>>> Changes in V2:
>>>>     - Update DT node sequence as per register ascending order
>>>
>>> Hm, I don't see it...
>>>
>>>>     - Fix DT node properties as per convention
>>>>
>>>>    arch/arm64/boot/dts/qcom/sc7280.dtsi | 22 ++++++++++++++++++++++
>>>>    1 file changed, 22 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>>> index 66f1eb83cca7..7b705df21f4e 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>>> @@ -2272,6 +2272,28 @@ ipa: ipa@1e40000 {
>>>>    			status = "disabled";
>>>>    		};
>>>>    
>>>> +		cryptobam: dma-controller@1dc4000 {
>>>
>>> It still looks like not correctly ordered by unit address against other
>>> nodes in the file.
>>>
>>
>> Hi Krzysztof,
>> Probably I am missing something basic here. I am trying to put entries
>> addresses that are sorted wrt their current adjacent.
>>
>> And it looks fine to me.
>>
>> 1c0e000 (current exist)
>> 1dc4000 (newly added)
>> 1dfa000	(newly added)
>> 1e40000	(current exist)
> 
> Then why the diff shows:
> @@ -2272,6 +2272,28 @@ ipa: ipa@1e40000 {
> above your changes?

my mistake! Local change was not added in updated patch.
Submitting V3

> 
> Best regards,
> Krzysztof
>